From: Archit Taneja <architt@codeaurora.org> To: daniel.vetter@ffwll.ch, robdclark@gmail.com, airlied@linux.ie, treding@nvidia.com, p.zabel@pengutronix.de, benjamin.gaignard@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [RFC 2/6] drm/msm: Remove local fbdev emulation Kconfig option Date: Tue, 10 Mar 2015 15:11:29 +0530 [thread overview] Message-ID: <1425980493-27533-3-git-send-email-architt@codeaurora.org> (raw) In-Reply-To: <1425980493-27533-1-git-send-email-architt@codeaurora.org> DRM_MSM_FBDEV config is used to enable/disable fbdev emulation for the msm kms driver. Replace this with the top level DRM_FBDEV_EMULATION config option where applicable. This also prevents build breaks caused by undefined drm_fb_helper_* functions when legacy fbdev support was disabled. Signed-off-by: Archit Taneja <architt@codeaurora.org> --- drivers/gpu/drm/msm/Kconfig | 14 -------------- drivers/gpu/drm/msm/Makefile | 2 +- drivers/gpu/drm/msm/msm_drv.c | 4 ++-- 3 files changed, 3 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig index bacbbb7..d6f3a4f 100644 --- a/drivers/gpu/drm/msm/Kconfig +++ b/drivers/gpu/drm/msm/Kconfig @@ -13,20 +13,6 @@ config DRM_MSM help DRM/KMS driver for MSM/snapdragon. -config DRM_MSM_FBDEV - bool "Enable legacy fbdev support for MSM modesetting driver" - depends on DRM_MSM - select DRM_KMS_FB_HELPER - select FB_SYS_FILLRECT - select FB_SYS_COPYAREA - select FB_SYS_IMAGEBLIT - select FB_SYS_FOPS - default y - help - Choose this option if you have a need for the legacy fbdev - support. Note that this support also provide the linux console - support on top of the MSM modesetting driver. - config DRM_MSM_REGISTER_LOGGING bool "MSM DRM register logging" depends on DRM_MSM diff --git a/drivers/gpu/drm/msm/Makefile b/drivers/gpu/drm/msm/Makefile index 674a132..40726ad 100644 --- a/drivers/gpu/drm/msm/Makefile +++ b/drivers/gpu/drm/msm/Makefile @@ -48,7 +48,7 @@ msm-y := \ msm_rd.o \ msm_ringbuffer.o -msm-$(CONFIG_DRM_MSM_FBDEV) += msm_fbdev.o +msm-$(CONFIG_DRM_FBDEV_EMULATION) += msm_fbdev.o msm-$(CONFIG_COMMON_CLK) += mdp/mdp4/mdp4_lvds_pll.o obj-$(CONFIG_DRM_MSM) += msm.o diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index a426911..d3e816a 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -54,7 +54,7 @@ module_param(reglog, bool, 0600); #define reglog 0 #endif -#ifdef CONFIG_DRM_MSM_FBDEV +#ifdef CONFIG_DRM_FBDEV_EMULATION static bool fbdev = true; MODULE_PARM_DESC(fbdev, "Enable fbdev compat layer"); module_param(fbdev, bool, 0600); @@ -305,7 +305,7 @@ static int msm_load(struct drm_device *dev, unsigned long flags) drm_mode_config_reset(dev); -#ifdef CONFIG_DRM_MSM_FBDEV +#ifdef CONFIG_DRM_FBDEV_EMULATION if (fbdev) priv->fbdev = msm_fbdev_init(dev); #endif -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Archit Taneja <architt@codeaurora.org> To: daniel.vetter@ffwll.ch, robdclark@gmail.com, airlied@linux.ie, treding@nvidia.com, p.zabel@pengutronix.de, benjamin.gaignard@linaro.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Archit Taneja <architt@codeaurora.org> Subject: [RFC 2/6] drm/msm: Remove local fbdev emulation Kconfig option Date: Tue, 10 Mar 2015 15:11:29 +0530 [thread overview] Message-ID: <1425980493-27533-3-git-send-email-architt@codeaurora.org> (raw) In-Reply-To: <1425980493-27533-1-git-send-email-architt@codeaurora.org> DRM_MSM_FBDEV config is used to enable/disable fbdev emulation for the msm kms driver. Replace this with the top level DRM_FBDEV_EMULATION config option where applicable. This also prevents build breaks caused by undefined drm_fb_helper_* functions when legacy fbdev support was disabled. Signed-off-by: Archit Taneja <architt@codeaurora.org> --- drivers/gpu/drm/msm/Kconfig | 14 -------------- drivers/gpu/drm/msm/Makefile | 2 +- drivers/gpu/drm/msm/msm_drv.c | 4 ++-- 3 files changed, 3 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig index bacbbb7..d6f3a4f 100644 --- a/drivers/gpu/drm/msm/Kconfig +++ b/drivers/gpu/drm/msm/Kconfig @@ -13,20 +13,6 @@ config DRM_MSM help DRM/KMS driver for MSM/snapdragon. -config DRM_MSM_FBDEV - bool "Enable legacy fbdev support for MSM modesetting driver" - depends on DRM_MSM - select DRM_KMS_FB_HELPER - select FB_SYS_FILLRECT - select FB_SYS_COPYAREA - select FB_SYS_IMAGEBLIT - select FB_SYS_FOPS - default y - help - Choose this option if you have a need for the legacy fbdev - support. Note that this support also provide the linux console - support on top of the MSM modesetting driver. - config DRM_MSM_REGISTER_LOGGING bool "MSM DRM register logging" depends on DRM_MSM diff --git a/drivers/gpu/drm/msm/Makefile b/drivers/gpu/drm/msm/Makefile index 674a132..40726ad 100644 --- a/drivers/gpu/drm/msm/Makefile +++ b/drivers/gpu/drm/msm/Makefile @@ -48,7 +48,7 @@ msm-y := \ msm_rd.o \ msm_ringbuffer.o -msm-$(CONFIG_DRM_MSM_FBDEV) += msm_fbdev.o +msm-$(CONFIG_DRM_FBDEV_EMULATION) += msm_fbdev.o msm-$(CONFIG_COMMON_CLK) += mdp/mdp4/mdp4_lvds_pll.o obj-$(CONFIG_DRM_MSM) += msm.o diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index a426911..d3e816a 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -54,7 +54,7 @@ module_param(reglog, bool, 0600); #define reglog 0 #endif -#ifdef CONFIG_DRM_MSM_FBDEV +#ifdef CONFIG_DRM_FBDEV_EMULATION static bool fbdev = true; MODULE_PARM_DESC(fbdev, "Enable fbdev compat layer"); module_param(fbdev, bool, 0600); @@ -305,7 +305,7 @@ static int msm_load(struct drm_device *dev, unsigned long flags) drm_mode_config_reset(dev); -#ifdef CONFIG_DRM_MSM_FBDEV +#ifdef CONFIG_DRM_FBDEV_EMULATION if (fbdev) priv->fbdev = msm_fbdev_init(dev); #endif -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2015-03-10 9:41 UTC|newest] Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-10 9:41 [RFC 0/6] drm: Add DRM_FBDEV_EMULATION Kconfig option Archit Taneja 2015-03-10 9:41 ` [RFC 1/6] drm: Add top level Kconfig option for DRM fbdev emulation Archit Taneja 2015-03-10 9:41 ` Archit Taneja 2015-03-10 9:46 ` Daniel Vetter 2015-03-10 9:46 ` Daniel Vetter 2015-03-10 9:54 ` Archit Taneja 2015-03-10 9:47 ` Daniel Vetter 2015-03-10 9:47 ` Daniel Vetter 2015-03-10 9:52 ` Archit Taneja 2015-03-10 9:52 ` Archit Taneja 2015-03-10 10:05 ` Daniel Vetter 2015-03-10 10:05 ` Daniel Vetter 2015-03-10 10:22 ` Archit Taneja 2015-03-10 10:22 ` Archit Taneja 2015-03-10 12:17 ` Daniel Vetter 2015-03-10 12:17 ` Daniel Vetter 2015-03-11 8:21 ` Archit Taneja 2015-03-11 8:21 ` Archit Taneja 2015-03-11 15:17 ` Daniel Vetter 2015-03-11 15:17 ` Daniel Vetter 2015-03-13 6:25 ` Archit Taneja 2015-03-13 6:37 ` Archit Taneja 2015-03-13 6:25 ` Archit Taneja 2015-03-13 9:06 ` Daniel Vetter 2015-03-13 9:06 ` Daniel Vetter 2015-03-13 9:06 ` Daniel Vetter 2015-03-13 9:46 ` Jani Nikula 2015-03-13 9:46 ` Jani Nikula 2015-03-13 9:46 ` Jani Nikula 2015-03-13 11:00 ` Archit Taneja 2015-03-13 11:12 ` Archit Taneja 2015-03-13 11:00 ` Archit Taneja 2015-03-25 8:17 ` Archit Taneja 2015-03-25 8:29 ` Archit Taneja 2015-03-25 8:17 ` Archit Taneja 2015-03-25 9:21 ` Daniel Vetter 2015-03-25 9:21 ` Daniel Vetter 2015-06-30 7:10 ` Daniel Vetter 2015-06-30 7:10 ` Daniel Vetter 2015-06-30 7:10 ` Daniel Vetter 2015-06-30 7:56 ` Archit Taneja 2015-06-30 7:56 ` Archit Taneja 2015-06-30 8:31 ` Benjamin Gaignard 2015-06-30 8:31 ` Benjamin Gaignard 2015-06-30 8:31 ` Benjamin Gaignard 2015-06-30 9:04 ` Daniel Vetter 2015-06-30 9:04 ` Daniel Vetter 2015-06-30 9:04 ` Daniel Vetter 2015-07-03 12:32 ` Thierry Reding 2015-07-03 12:32 ` Thierry Reding 2015-07-03 12:32 ` Thierry Reding 2015-07-03 13:33 ` Rob Clark 2015-07-03 13:33 ` Rob Clark 2015-07-03 13:33 ` Rob Clark 2015-06-30 9:06 ` Archit Taneja 2015-06-30 9:18 ` Archit Taneja 2015-06-30 9:06 ` Archit Taneja 2015-03-10 15:33 ` Jani Nikula 2015-03-11 4:57 ` Archit Taneja 2015-03-10 9:41 ` Archit Taneja [this message] 2015-03-10 9:41 ` [RFC 2/6] drm/msm: Remove local fbdev emulation Kconfig option Archit Taneja 2015-03-10 9:41 ` [RFC 3/6] drm/i915: " Archit Taneja 2015-03-10 9:41 ` Archit Taneja 2015-03-10 10:01 ` Daniel Vetter 2015-03-10 10:10 ` Archit Taneja 2015-03-10 10:10 ` Archit Taneja 2015-03-10 9:41 ` [RFC 4/6] drm/tegra: " Archit Taneja 2015-03-10 9:41 ` [RFC 5/6] drm/imx: " Archit Taneja 2015-03-10 10:54 ` Philipp Zabel 2015-03-11 4:53 ` Archit Taneja 2015-03-10 9:41 ` [RFC 6/6] drm/sti: " Archit Taneja 2015-03-10 9:41 ` Archit Taneja 2015-03-11 14:12 ` Benjamin Gaignard 2015-07-13 6:42 ` [RFC v2 0/6] drm: fb emulation: Step 2: Create a fbdev emulation config option Archit Taneja 2015-07-13 7:15 ` Daniel Vetter 2015-08-05 6:58 ` [PATCH v3] drm: Add top level Kconfig option for DRM fbdev emulation Archit Taneja 2015-10-27 8:10 ` [PATCH v3 0/3] drm: fb emulation: Remove remaining driver level fb emulation configs Archit Taneja 2015-10-27 8:10 ` [PATCH v3 1/3] drm/imx: Remove local fbdev emulation Kconfig option Archit Taneja 2015-10-27 8:10 ` [PATCH v3 2/3] drm/sti: " Archit Taneja 2015-10-29 13:33 ` Vincent ABRIOU 2015-10-30 10:25 ` Daniel Vetter 2015-10-30 12:30 ` Vincent ABRIOU 2015-10-30 12:37 ` Archit Taneja 2015-10-27 8:10 ` [PATCH v3 3/3] drm/tegra: " Archit Taneja 2015-10-30 10:27 ` [PATCH v3 0/3] drm: fb emulation: Remove remaining driver level fb emulation configs Daniel Vetter 2015-11-04 5:01 ` Archit Taneja 2015-07-13 6:42 ` [RFC v2 1/6] drm: Add top level Kconfig option for DRM fbdev emulation Archit Taneja 2015-07-13 6:59 ` Daniel Vetter 2015-07-13 6:42 ` [RFC v2 2/6] drm/msm: Remove local fbdev emulation Kconfig option Archit Taneja 2015-07-13 6:42 ` [RFC v2 3/6] drm/tegra: " Archit Taneja 2015-07-13 6:42 ` [RFC v2 4/6] drm/imx: " Archit Taneja 2015-07-13 6:42 ` [RFC v2 5/6] drm/sti: " Archit Taneja 2015-07-13 6:42 ` [RFC v2 6/6] drm/i915: " Archit Taneja 2015-07-13 7:10 ` Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1425980493-27533-3-git-send-email-architt@codeaurora.org \ --to=architt@codeaurora.org \ --cc=airlied@linux.ie \ --cc=benjamin.gaignard@linaro.org \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=p.zabel@pengutronix.de \ --cc=robdclark@gmail.com \ --cc=treding@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.