From: Sanidhya Kashyap <sanidhya.gatech@gmail.com>
To: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: taesoo@gatech.edu, changwoo@gatech.edu, sanidhya@gatech.edu,
blee@gatech.edu, Sanidhya Kashyap <sanidhya.gatech@gmail.com>
Subject: [PATCH] afs: kstrdup() memory handling
Date: Sat, 21 Mar 2015 12:50:09 -0400 [thread overview]
Message-ID: <1426956609-27273-1-git-send-email-sanidhya.gatech@gmail.com> (raw)
Handling kstrdup() failure in case of memory pressure even
for new_opts.
Signed-off-by: Sanidhya Kashyap <sanidhya.gatech@gmail.com>
---
fs/afs/super.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/fs/afs/super.c b/fs/afs/super.c
index c486155..477f38e 100644
--- a/fs/afs/super.c
+++ b/fs/afs/super.c
@@ -360,10 +360,13 @@ static struct dentry *afs_mount(struct file_system_type *fs_type,
struct key *key;
char *new_opts = kstrdup(options, GFP_KERNEL);
struct afs_super_info *as;
- int ret;
+ int ret = -ENOMEM;
_enter(",,%s,%p", dev_name, options);
+ if (new_opts)
+ goto error_out;
+
memset(¶ms, 0, sizeof(params));
ret = -EINVAL;
@@ -441,6 +444,7 @@ error:
afs_put_cell(params.cell);
key_put(params.key);
kfree(new_opts);
+error_out:
_leave(" = %d", ret);
return ERR_PTR(ret);
}
--
2.1.0
next reply other threads:[~2015-03-21 16:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 16:50 Sanidhya Kashyap [this message]
2015-03-21 17:07 ` [PATCH] afs: kstrdup() memory handling Jeff Epler
2015-03-21 17:11 ` Sanidhya Kashyap
2015-03-21 17:13 ` Sanidhya Kashyap
2015-03-21 21:02 ` Jeff Epler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426956609-27273-1-git-send-email-sanidhya.gatech@gmail.com \
--to=sanidhya.gatech@gmail.com \
--cc=blee@gatech.edu \
--cc=changwoo@gatech.edu \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sanidhya@gatech.edu \
--cc=taesoo@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.