From: Cao Minh Hiep <cm-hiep@jinso.co.jp> To: geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org, yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org, ryusuke.sakato.bx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org, linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: [PATCH 1/1] spi: Re-do correctly function name and 'ret' return value Date: Fri, 24 Apr 2015 06:40:56 +0000 [thread overview] Message-ID: <1429857656-8348-2-git-send-email-cm-hiep@jinso.co.jp> (raw) In-Reply-To: <1429857656-8348-1-git-send-email-cm-hiep-HEF513clHfp3+QwDJ9on6Q@public.gmane.org> From: Hiep Cao Minh <cm-hiep@jinso.co.jp> qspi_trigger_transfer_out_int function should be qspi_trigger_transfer_out_in without "t". "ret" value in rspi_dma_check_then_transfer should be returned insteeds of returning zero. It just returns qspi_trigger_transfer_out_in() value in qspi_transfer_out_in(). Signed-off-by: Hiep Cao Minh <cm-hiep@jinso.co.jp> --- drivers/spi/spi-rspi.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-rspi.c b/drivers/spi/spi-rspi.c index 186924a..9304a6d 100644 --- a/drivers/spi/spi-rspi.c +++ b/drivers/spi/spi-rspi.c @@ -670,7 +670,7 @@ static int rspi_dma_check_then_transfer(struct rspi_data *rspi, int ret = rspi_dma_transfer(rspi, &xfer->tx_sg, xfer->rx_buf ? &xfer->rx_sg : NULL); if (ret != -EAGAIN) - return 0; + return ret; } return -EAGAIN; @@ -724,7 +724,7 @@ static int rspi_rz_transfer_one(struct spi_master *master, return rspi_common_transfer(rspi, xfer); } -static int qspi_trigger_transfer_out_int(struct rspi_data *rspi, const u8 *tx, +static int qspi_trigger_transfer_out_in(struct rspi_data *rspi, const u8 *tx, u8 *rx, unsigned int len) { int i, n, ret; @@ -771,12 +771,8 @@ static int qspi_transfer_out_in(struct rspi_data *rspi, if (ret != -EAGAIN) return ret; - ret = qspi_trigger_transfer_out_int(rspi, xfer->tx_buf, + return qspi_trigger_transfer_out_in(rspi, xfer->tx_buf, xfer->rx_buf, xfer->len); - if (ret < 0) - return ret; - - return 0; } static int qspi_transfer_out(struct rspi_data *rspi, struct spi_transfer *xfer) -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Cao Minh Hiep <cm-hiep-HEF513clHfp3+QwDJ9on6Q@public.gmane.org> To: geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org, yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org, ryusuke.sakato.bx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org, linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: [PATCH 1/1] spi: Re-do correctly function name and 'ret' return value Date: Fri, 24 Apr 2015 15:40:56 +0900 [thread overview] Message-ID: <1429857656-8348-2-git-send-email-cm-hiep@jinso.co.jp> (raw) In-Reply-To: <1429857656-8348-1-git-send-email-cm-hiep-HEF513clHfp3+QwDJ9on6Q@public.gmane.org> From: Hiep Cao Minh <cm-hiep-HEF513clHfp3+QwDJ9on6Q@public.gmane.org> qspi_trigger_transfer_out_int function should be qspi_trigger_transfer_out_in without "t". "ret" value in rspi_dma_check_then_transfer should be returned insteeds of returning zero. It just returns qspi_trigger_transfer_out_in() value in qspi_transfer_out_in(). Signed-off-by: Hiep Cao Minh <cm-hiep-HEF513clHfp3+QwDJ9on6Q@public.gmane.org> --- drivers/spi/spi-rspi.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-rspi.c b/drivers/spi/spi-rspi.c index 186924a..9304a6d 100644 --- a/drivers/spi/spi-rspi.c +++ b/drivers/spi/spi-rspi.c @@ -670,7 +670,7 @@ static int rspi_dma_check_then_transfer(struct rspi_data *rspi, int ret = rspi_dma_transfer(rspi, &xfer->tx_sg, xfer->rx_buf ? &xfer->rx_sg : NULL); if (ret != -EAGAIN) - return 0; + return ret; } return -EAGAIN; @@ -724,7 +724,7 @@ static int rspi_rz_transfer_one(struct spi_master *master, return rspi_common_transfer(rspi, xfer); } -static int qspi_trigger_transfer_out_int(struct rspi_data *rspi, const u8 *tx, +static int qspi_trigger_transfer_out_in(struct rspi_data *rspi, const u8 *tx, u8 *rx, unsigned int len) { int i, n, ret; @@ -771,12 +771,8 @@ static int qspi_transfer_out_in(struct rspi_data *rspi, if (ret != -EAGAIN) return ret; - ret = qspi_trigger_transfer_out_int(rspi, xfer->tx_buf, + return qspi_trigger_transfer_out_in(rspi, xfer->tx_buf, xfer->rx_buf, xfer->len); - if (ret < 0) - return ret; - - return 0; } static int qspi_transfer_out(struct rspi_data *rspi, struct spi_transfer *xfer) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-04-24 6:40 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-24 6:40 [PATCH 0/1] spi: Re-do correctly function name and 'ret' return value Cao Minh Hiep 2015-04-24 6:40 ` Cao Minh Hiep [not found] ` <1429857656-8348-1-git-send-email-cm-hiep-HEF513clHfp3+QwDJ9on6Q@public.gmane.org> 2015-04-24 6:40 ` Cao Minh Hiep [this message] 2015-04-24 6:40 ` [PATCH 1/1] " Cao Minh Hiep [not found] ` <1429857656-8348-2-git-send-email-cm-hiep-HEF513clHfp3+QwDJ9on6Q@public.gmane.org> 2015-04-24 7:25 ` Geert Uytterhoeven 2015-04-24 7:25 ` Geert Uytterhoeven [not found] ` <CAMuHMdWm2i-48mOUFCcFuXEAyFimkW+Yw7wdzgOa8rOgpfbMWw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-04-24 7:34 ` Cao Minh Hiep 2015-04-24 7:34 ` Cao Minh Hiep
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1429857656-8348-2-git-send-email-cm-hiep@jinso.co.jp \ --to=cm-hiep@jinso.co.jp \ --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org \ --cc=kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \ --cc=linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=ryusuke.sakato.bx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \ --cc=yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.