All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: linux-media@vger.kernel.org
Cc: g.liakhovetski@gmx.de, Hans Verkuil <hans.verkuil@cisco.com>
Subject: [PATCHv2 5/8] ov5642: avoid calling ov5642_find_datafmt() twice
Date: Mon,  4 May 2015 12:25:52 +0200	[thread overview]
Message-ID: <1430735155-24110-6-git-send-email-hverkuil@xs4all.nl> (raw)
In-Reply-To: <1430735155-24110-1-git-send-email-hverkuil@xs4all.nl>

From: Hans Verkuil <hans.verkuil@cisco.com>

Simplify ov5642_set_fmt().

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---
 drivers/media/i2c/soc_camera/ov5642.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/soc_camera/ov5642.c b/drivers/media/i2c/soc_camera/ov5642.c
index bab9ac0..a3c328c 100644
--- a/drivers/media/i2c/soc_camera/ov5642.c
+++ b/drivers/media/i2c/soc_camera/ov5642.c
@@ -811,7 +811,7 @@ static int ov5642_set_fmt(struct v4l2_subdev *sd,
 	mf->field	= V4L2_FIELD_NONE;
 
 	if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE)
-		priv->fmt = ov5642_find_datafmt(mf->code);
+		priv->fmt = fmt;
 	else
 		cfg->try_fmt = *mf;
 	return 0;
-- 
2.1.4


  parent reply	other threads:[~2015-05-04 10:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-04 10:25 [PATCHv2 0/8] soc-camera sensor improvements Hans Verkuil
2015-05-04 10:25 ` [PATCHv2 1/8] imx074: don't call imx074_find_datafmt() twice Hans Verkuil
2015-05-04 10:25 ` [PATCHv2 2/8] mt9m001: avoid calling mt9m001_find_datafmt() twice Hans Verkuil
2015-05-04 10:25 ` [PATCHv2 3/8] mt9v022: avoid calling mt9v022_find_datafmt() twice Hans Verkuil
2015-05-04 10:25 ` [PATCHv2 4/8] ov2640: avoid calling ov2640_select_win() twice Hans Verkuil
2015-05-04 10:25 ` Hans Verkuil [this message]
2015-05-04 10:25 ` [PATCHv2 6/8] ov772x: avoid calling ov772x_select_params() twice Hans Verkuil
2015-05-04 10:25 ` [PATCHv2 7/8] ov9640: avoid calling ov9640_res_roundup() twice Hans Verkuil
2015-05-04 10:25 ` [PATCHv2 8/8] ov9740: avoid calling ov9740_res_roundup() twice Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430735155-24110-6-git-send-email-hverkuil@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=g.liakhovetski@gmx.de \
    --cc=hans.verkuil@cisco.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.