All of lore.kernel.org
 help / color / mirror / Atom feed
From: Barry Song <21cnbao@gmail.com>
To: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org
Cc: Qipan Li <Qipan.Li@csr.com>,
	workgroup.linux@csr.com, linux-arm-kernel@lists.infradead.org,
	Barry Song <Baohua.Song@csr.com>
Subject: [PATCH 6/6] serial: sirf: assign console default index if users not set a valid one
Date: Thu, 14 May 2015 06:45:26 +0000	[thread overview]
Message-ID: <1431585926-10746-6-git-send-email-21cnbao@gmail.com> (raw)
In-Reply-To: <1431585926-10746-1-git-send-email-21cnbao@gmail.com>

From: Qipan Li <Qipan.Li@csr.com>

it seems this is a more typical behaviour from reviewing other console
drivers.

Signed-off-by: Qipan Li <Qipan.Li@csr.com>
Signed-off-by: Barry Song <Baohua.Song@csr.com>
---
 drivers/tty/serial/sirfsoc_uart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/sirfsoc_uart.c b/drivers/tty/serial/sirfsoc_uart.c
index 0e43799..8d75962 100644
--- a/drivers/tty/serial/sirfsoc_uart.c
+++ b/drivers/tty/serial/sirfsoc_uart.c
@@ -1236,7 +1236,7 @@ sirfsoc_uart_console_setup(struct console *co, char *options)
 	struct sirfsoc_uart_port *sirfport;
 	struct sirfsoc_register *ureg;
 	if (co->index < 0 || co->index >= SIRFSOC_UART_NR)
-		return -EINVAL;
+		co->index = 1;
 	sirfport = sirf_ports[co->index];
 	if (!sirfport)
 		return -ENODEV;
-- 
2.3.5

WARNING: multiple messages have this Message-ID (diff)
From: 21cnbao@gmail.com (Barry Song)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] serial: sirf: assign console default index if users not set a valid one
Date: Thu, 14 May 2015 06:45:26 +0000	[thread overview]
Message-ID: <1431585926-10746-6-git-send-email-21cnbao@gmail.com> (raw)
In-Reply-To: <1431585926-10746-1-git-send-email-21cnbao@gmail.com>

From: Qipan Li <Qipan.Li@csr.com>

it seems this is a more typical behaviour from reviewing other console
drivers.

Signed-off-by: Qipan Li <Qipan.Li@csr.com>
Signed-off-by: Barry Song <Baohua.Song@csr.com>
---
 drivers/tty/serial/sirfsoc_uart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/sirfsoc_uart.c b/drivers/tty/serial/sirfsoc_uart.c
index 0e43799..8d75962 100644
--- a/drivers/tty/serial/sirfsoc_uart.c
+++ b/drivers/tty/serial/sirfsoc_uart.c
@@ -1236,7 +1236,7 @@ sirfsoc_uart_console_setup(struct console *co, char *options)
 	struct sirfsoc_uart_port *sirfport;
 	struct sirfsoc_register *ureg;
 	if (co->index < 0 || co->index >= SIRFSOC_UART_NR)
-		return -EINVAL;
+		co->index = 1;
 	sirfport = sirf_ports[co->index];
 	if (!sirfport)
 		return -ENODEV;
-- 
2.3.5

  parent reply	other threads:[~2015-05-14  6:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14  6:45 [PATCH 1/6] serial: sirf: enable ATLAS7 USP serial support Barry Song
2015-05-14  6:45 ` Barry Song
2015-05-14  6:45 ` [PATCH 2/6] serial: sirf: fix the issue that HW flow control doesn't work for BT Barry Song
2015-05-14  6:45   ` Barry Song
2015-05-14  6:45 ` [PATCH 3/6] serial: sirf: fix endless loop bug in uart receive tasklet Barry Song
2015-05-14  6:45   ` Barry Song
2015-05-14  6:45 ` [PATCH 4/6] serial: sirf: add uart receive's some error counter and mark Barry Song
2015-05-14  6:45   ` Barry Song
2015-05-14  6:45 ` [PATCH 5/6] serial: sirf: add serial loopback function support Barry Song
2015-05-14  6:45   ` Barry Song
2015-05-14  6:45 ` Barry Song [this message]
2015-05-14  6:45   ` [PATCH 6/6] serial: sirf: assign console default index if users not set a valid one Barry Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431585926-10746-6-git-send-email-21cnbao@gmail.com \
    --to=21cnbao@gmail.com \
    --cc=Baohua.Song@csr.com \
    --cc=Qipan.Li@csr.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=workgroup.linux@csr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.