From: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> To: Russell King <linux@arm.linux.org.uk>, Daniel Mack <daniel@zonque.org>, Robert Jarzmik <robert.jarzmik@free.fr>, Linus Walleij <linus.walleij@linaro.org>, Alexandre Courbot <gnurou@gmail.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Samuel Ortiz <sameo@linux.intel.com>, Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>, Jingoo Han <jg1.han@samsung.com>, Liam Girdwood <lgirdwood@gmail.com>, Andrea Adami <andrea.adami@gmail.com> Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-input@vger.kernel.org, linux-spi@vger.kernel.org, alsa-devel@alsa-project.org Subject: [PATCH v4 05/18] input: make LoCoMo keyboard driver support both poodle and collie Date: Mon, 25 May 2015 14:41:40 +0300 [thread overview] Message-ID: <1432554113-26280-6-git-send-email-dbaryshkov@gmail.com> (raw) In-Reply-To: <1432554113-26280-1-git-send-email-dbaryshkov@gmail.com> Keyboards on collie and poodle differ only in wiring of 'Home' key. Instead of complicating the driver with platform data, just check for the machine for the time being. This will be converted to DTS property sometime in the future. Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/input/keyboard/locomokbd.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/input/keyboard/locomokbd.c b/drivers/input/keyboard/locomokbd.c index 7645053..73d6e58 100644 --- a/drivers/input/keyboard/locomokbd.c +++ b/drivers/input/keyboard/locomokbd.c @@ -33,6 +33,9 @@ #include <linux/slab.h> #include <linux/mfd/locomo.h> +/* There is one minor difference between mappings on poodle and collie */ +#include <asm/mach-types.h> + #define KEY_ACTIVITY KEY_F16 #define KEY_CONTACT KEY_F18 #define KEY_CENTER KEY_F15 @@ -45,7 +48,7 @@ static const unsigned char locomokbd_keycode[LOCOMOKBD_NUMKEYS] = { 0, KEY_ESC, KEY_ACTIVITY, 0, 0, 0, 0, 0, 0, 0, /* 0 - 9 */ - 0, 0, 0, 0, 0, 0, 0, KEY_MENU, KEY_HOME, KEY_CONTACT, /* 10 - 19 */ + 0, 0, 0, 0, 0, 0, 0, KEY_MENU, 0, KEY_CONTACT, /* 10 - 19 */ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* 20 - 29 */ 0, 0, 0, KEY_CENTER, 0, KEY_MAIL, 0, 0, 0, 0, /* 30 - 39 */ 0, 0, 0, 0, 0, 0, 0, 0, 0, KEY_RIGHT, /* 40 - 49 */ @@ -278,6 +281,11 @@ static int locomokbd_probe(struct platform_device *dev) locomokbd_keycode, sizeof(locomokbd->keycode)); + if (machine_is_collie()) + locomokbd->keycode[18] = KEY_HOME; + else + locomokbd->keycode[3] = KEY_HOME; + for (i = 0; i < LOCOMOKBD_NUMKEYS; i++) input_set_capability(input_dev, EV_KEY, locomokbd->keycode[i]); input_set_capability(input_dev, EV_PWR, KEY_SUSPEND); -- 2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: dbaryshkov@gmail.com (Dmitry Eremin-Solenikov) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 05/18] input: make LoCoMo keyboard driver support both poodle and collie Date: Mon, 25 May 2015 14:41:40 +0300 [thread overview] Message-ID: <1432554113-26280-6-git-send-email-dbaryshkov@gmail.com> (raw) In-Reply-To: <1432554113-26280-1-git-send-email-dbaryshkov@gmail.com> Keyboards on collie and poodle differ only in wiring of 'Home' key. Instead of complicating the driver with platform data, just check for the machine for the time being. This will be converted to DTS property sometime in the future. Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/input/keyboard/locomokbd.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/input/keyboard/locomokbd.c b/drivers/input/keyboard/locomokbd.c index 7645053..73d6e58 100644 --- a/drivers/input/keyboard/locomokbd.c +++ b/drivers/input/keyboard/locomokbd.c @@ -33,6 +33,9 @@ #include <linux/slab.h> #include <linux/mfd/locomo.h> +/* There is one minor difference between mappings on poodle and collie */ +#include <asm/mach-types.h> + #define KEY_ACTIVITY KEY_F16 #define KEY_CONTACT KEY_F18 #define KEY_CENTER KEY_F15 @@ -45,7 +48,7 @@ static const unsigned char locomokbd_keycode[LOCOMOKBD_NUMKEYS] = { 0, KEY_ESC, KEY_ACTIVITY, 0, 0, 0, 0, 0, 0, 0, /* 0 - 9 */ - 0, 0, 0, 0, 0, 0, 0, KEY_MENU, KEY_HOME, KEY_CONTACT, /* 10 - 19 */ + 0, 0, 0, 0, 0, 0, 0, KEY_MENU, 0, KEY_CONTACT, /* 10 - 19 */ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, /* 20 - 29 */ 0, 0, 0, KEY_CENTER, 0, KEY_MAIL, 0, 0, 0, 0, /* 30 - 39 */ 0, 0, 0, 0, 0, 0, 0, 0, 0, KEY_RIGHT, /* 40 - 49 */ @@ -278,6 +281,11 @@ static int locomokbd_probe(struct platform_device *dev) locomokbd_keycode, sizeof(locomokbd->keycode)); + if (machine_is_collie()) + locomokbd->keycode[18] = KEY_HOME; + else + locomokbd->keycode[3] = KEY_HOME; + for (i = 0; i < LOCOMOKBD_NUMKEYS; i++) input_set_capability(input_dev, EV_KEY, locomokbd->keycode[i]); input_set_capability(input_dev, EV_PWR, KEY_SUSPEND); -- 2.1.4
next prev parent reply other threads:[~2015-05-25 11:42 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-25 11:41 [PATCH v4 00/18] new MFD LoCoMo driver set Dmitry Eremin-Solenikov 2015-05-25 11:41 ` Dmitry Eremin-Solenikov 2015-05-25 11:41 ` [PATCH v4 01/18] mfd: add new driver for Sharp LoCoMo Dmitry Eremin-Solenikov 2015-05-25 11:41 ` Dmitry Eremin-Solenikov 2015-05-27 10:27 ` Lee Jones 2015-05-27 10:27 ` Lee Jones 2015-05-27 14:55 ` Dmitry Eremin-Solenikov 2015-05-27 14:55 ` Dmitry Eremin-Solenikov 2015-05-28 11:58 ` Lee Jones 2015-05-28 11:58 ` Lee Jones 2015-05-28 19:07 ` Dmitry Eremin-Solenikov 2015-05-28 19:07 ` Dmitry Eremin-Solenikov 2015-06-02 11:33 ` Linus Walleij 2015-06-02 11:33 ` Linus Walleij 2015-05-25 11:41 ` [PATCH v4 02/18] leds: port locomo leds driver to new locomo core Dmitry Eremin-Solenikov 2015-05-25 11:41 ` Dmitry Eremin-Solenikov 2015-05-25 11:41 ` [PATCH v4 03/18] input: convert LoCoMo keyboard driver to use " Dmitry Eremin-Solenikov 2015-05-25 11:41 ` Dmitry Eremin-Solenikov [not found] ` <1432554113-26280-4-git-send-email-dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2015-05-26 17:44 ` Dmitry Torokhov 2015-05-26 17:44 ` Dmitry Torokhov 2015-05-25 11:41 ` Dmitry Eremin-Solenikov [this message] 2015-05-25 11:41 ` [PATCH v4 05/18] input: make LoCoMo keyboard driver support both poodle and collie Dmitry Eremin-Solenikov 2015-05-25 11:41 ` [PATCH v4 12/18] ARM: sa1100: make collie use new locomo drivers Dmitry Eremin-Solenikov 2015-05-25 11:41 ` Dmitry Eremin-Solenikov [not found] ` <1432554113-26280-1-git-send-email-dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2015-05-25 11:41 ` [PATCH v4 04/18] input: locomokbd: differentiate between two Enter keys Dmitry Eremin-Solenikov 2015-05-25 11:41 ` Dmitry Eremin-Solenikov [not found] ` <1432554113-26280-5-git-send-email-dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2015-05-26 17:45 ` Dmitry Torokhov 2015-05-26 17:45 ` Dmitry Torokhov 2015-05-25 11:41 ` [PATCH v4 06/18] video: backlight: add new locomo backlight driver Dmitry Eremin-Solenikov 2015-05-25 11:41 ` Dmitry Eremin-Solenikov 2015-05-25 11:41 ` [PATCH v4 07/18] video: lcd: add LoCoMo LCD driver Dmitry Eremin-Solenikov 2015-05-25 11:41 ` Dmitry Eremin-Solenikov 2015-05-25 11:41 ` [PATCH v4 08/18] gpio: port LoCoMo gpio support from old driver Dmitry Eremin-Solenikov 2015-05-25 11:41 ` Dmitry Eremin-Solenikov 2015-05-25 11:41 ` [PATCH v4 09/18] gpio: locomo: implement per-pin irq handling Dmitry Eremin-Solenikov 2015-05-25 11:41 ` Dmitry Eremin-Solenikov 2015-05-25 11:41 ` [PATCH v4 10/18] spi: add locomo SPI driver Dmitry Eremin-Solenikov 2015-05-25 11:41 ` Dmitry Eremin-Solenikov 2015-05-25 11:41 ` [PATCH v4 11/18] i2c: add locomo i2c driver Dmitry Eremin-Solenikov 2015-05-25 11:41 ` Dmitry Eremin-Solenikov 2015-05-25 11:41 ` [PATCH v4 13/18] ARM: sa1100: don't preallocate IRQ space for locomo Dmitry Eremin-Solenikov 2015-05-25 11:41 ` Dmitry Eremin-Solenikov 2015-05-25 11:41 ` [PATCH v4 16/18] ARM: pxa: poodle: " Dmitry Eremin-Solenikov 2015-05-25 11:41 ` Dmitry Eremin-Solenikov 2015-05-25 11:41 ` [PATCH v4 14/18] ASoC: pxa: poodle: make use of new locomo GPIO interface Dmitry Eremin-Solenikov 2015-05-25 11:41 ` Dmitry Eremin-Solenikov 2015-05-25 11:41 ` [PATCH v4 15/18] ARM: pxa: poodle: use new LoCoMo driver Dmitry Eremin-Solenikov 2015-05-25 11:41 ` Dmitry Eremin-Solenikov 2015-05-26 21:18 ` Robert Jarzmik 2015-05-26 21:18 ` Robert Jarzmik 2015-05-25 11:41 ` [PATCH v4 17/18] video: backlight: drop old locomo bl/lcd driver Dmitry Eremin-Solenikov 2015-05-25 11:41 ` Dmitry Eremin-Solenikov 2015-05-25 11:41 ` [PATCH v4 18/18] ARM: drop old LoCoMo driver Dmitry Eremin-Solenikov 2015-05-25 11:41 ` Dmitry Eremin-Solenikov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1432554113-26280-6-git-send-email-dbaryshkov@gmail.com \ --to=dbaryshkov@gmail.com \ --cc=alsa-devel@alsa-project.org \ --cc=andrea.adami@gmail.com \ --cc=broonie@kernel.org \ --cc=daniel@zonque.org \ --cc=dmitry.torokhov@gmail.com \ --cc=gnurou@gmail.com \ --cc=jg1.han@samsung.com \ --cc=lee.jones@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=robert.jarzmik@free.fr \ --cc=sameo@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.