All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 13/14] clk: shmobile: mstp: Consider "zb_clk" suitable for power management
Date: Thu, 28 May 2015 18:53:38 +0000	[thread overview]
Message-ID: <1432839219-475-14-git-send-email-geert+renesas@glider.be> (raw)
In-Reply-To: <1432839219-475-1-git-send-email-geert+renesas@glider.be>

Currently the CPG Clock Domain code looks for MSTP clocks to power
manage a device.

Unfortunately, on R-Mobile APE6 (r8a73a4) and SH-Mobile AG5 (sh73a0),
the Bus State Controller (BSC) is not power-managed by an MSTP clock,
but by a plain CPG clock (zb_clk).  Add a special case to handle this,
so the clock is properly managed, and devices connected to the BSC work
as expected.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - New.
---
 drivers/clk/shmobile/clk-mstp.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/clk/shmobile/clk-mstp.c b/drivers/clk/shmobile/clk-mstp.c
index 619f3eccefd4884f..19e2b11953383587 100644
--- a/drivers/clk/shmobile/clk-mstp.c
+++ b/drivers/clk/shmobile/clk-mstp.c
@@ -258,6 +258,10 @@ int cpg_mstp_attach_dev(struct generic_pm_domain *domain, struct device *dev)
 					    "renesas,cpg-mstp-clocks"))
 			goto found;
 
+		/* BSC on r8a73a4/sh73a0 uses zb_clk instead of an mstp clock*/
+		if (!strcmp(clkspec.np->name, "zb_clk"))
+			goto found;
+
 		of_node_put(clkspec.np);
 		i++;
 	}
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Mike Turquette <mturquette@linaro.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Kevin Hilman <khilman@kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-clk@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH v2 13/14] clk: shmobile: mstp: Consider "zb_clk" suitable for power management
Date: Thu, 28 May 2015 20:53:38 +0200	[thread overview]
Message-ID: <1432839219-475-14-git-send-email-geert+renesas@glider.be> (raw)
In-Reply-To: <1432839219-475-1-git-send-email-geert+renesas@glider.be>

Currently the CPG Clock Domain code looks for MSTP clocks to power
manage a device.

Unfortunately, on R-Mobile APE6 (r8a73a4) and SH-Mobile AG5 (sh73a0),
the Bus State Controller (BSC) is not power-managed by an MSTP clock,
but by a plain CPG clock (zb_clk).  Add a special case to handle this,
so the clock is properly managed, and devices connected to the BSC work
as expected.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - New.
---
 drivers/clk/shmobile/clk-mstp.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/clk/shmobile/clk-mstp.c b/drivers/clk/shmobile/clk-mstp.c
index 619f3eccefd4884f..19e2b11953383587 100644
--- a/drivers/clk/shmobile/clk-mstp.c
+++ b/drivers/clk/shmobile/clk-mstp.c
@@ -258,6 +258,10 @@ int cpg_mstp_attach_dev(struct generic_pm_domain *domain, struct device *dev)
 					    "renesas,cpg-mstp-clocks"))
 			goto found;
 
+		/* BSC on r8a73a4/sh73a0 uses zb_clk instead of an mstp clock*/
+		if (!strcmp(clkspec.np->name, "zb_clk"))
+			goto found;
+
 		of_node_put(clkspec.np);
 		i++;
 	}
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: geert+renesas@glider.be (Geert Uytterhoeven)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 13/14] clk: shmobile: mstp: Consider "zb_clk" suitable for power management
Date: Thu, 28 May 2015 20:53:38 +0200	[thread overview]
Message-ID: <1432839219-475-14-git-send-email-geert+renesas@glider.be> (raw)
In-Reply-To: <1432839219-475-1-git-send-email-geert+renesas@glider.be>

Currently the CPG Clock Domain code looks for MSTP clocks to power
manage a device.

Unfortunately, on R-Mobile APE6 (r8a73a4) and SH-Mobile AG5 (sh73a0),
the Bus State Controller (BSC) is not power-managed by an MSTP clock,
but by a plain CPG clock (zb_clk).  Add a special case to handle this,
so the clock is properly managed, and devices connected to the BSC work
as expected.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - New.
---
 drivers/clk/shmobile/clk-mstp.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/clk/shmobile/clk-mstp.c b/drivers/clk/shmobile/clk-mstp.c
index 619f3eccefd4884f..19e2b11953383587 100644
--- a/drivers/clk/shmobile/clk-mstp.c
+++ b/drivers/clk/shmobile/clk-mstp.c
@@ -258,6 +258,10 @@ int cpg_mstp_attach_dev(struct generic_pm_domain *domain, struct device *dev)
 					    "renesas,cpg-mstp-clocks"))
 			goto found;
 
+		/* BSC on r8a73a4/sh73a0 uses zb_clk instead of an mstp clock*/
+		if (!strcmp(clkspec.np->name, "zb_clk"))
+			goto found;
+
 		of_node_put(clkspec.np);
 		i++;
 	}
-- 
1.9.1

  parent reply	other threads:[~2015-05-28 18:53 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-28 18:53 [PATCH v2 00/14] ARM: shmobile: Add CPG Clock Domains Geert Uytterhoeven
2015-05-28 18:53 ` Geert Uytterhoeven
2015-05-28 18:53 ` Geert Uytterhoeven
2015-05-28 18:53 ` Geert Uytterhoeven
2015-05-28 18:53 ` [PATCH v2 01/14] clk: shmobile: Add CPG Clock Domain support Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-06-22 15:07   ` Geert Uytterhoeven
2015-06-22 15:07     ` Geert Uytterhoeven
2015-06-22 15:07     ` Geert Uytterhoeven
2015-06-22 15:07     ` Geert Uytterhoeven
2015-06-22 15:07     ` Geert Uytterhoeven
2015-05-28 18:53 ` [PATCH v2 02/14] clk: shmobile: r8a7778: " Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53 ` [PATCH v2 03/14] clk: shmobile: r8a7779: " Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53 ` [PATCH v2 04/14] clk: shmobile: rcar-gen2: " Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53 ` [PATCH v2 05/14] clk: shmobile: rz: " Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53 ` [PATCH v2 06/14] ARM: shmobile: r7s72100 dtsi: Add CPG Clock Domain Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53 ` [PATCH v2 07/14] ARM: shmobile: r8a7778 " Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53 ` [PATCH v2 08/14] ARM: shmobile: r8a7779 " Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53 ` [PATCH v2 09/14] ARM: shmobile: r8a7790 " Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53 ` [PATCH v2 10/14] ARM: shmobile: r8a7791 " Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53 ` [PATCH v2 11/14] ARM: shmobile: r8a7794 " Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53 ` [PATCH v2 12/14] drivers: sh: Stop using pm_runtime.c for multi-platform shmobile with genpd Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-06-15 19:44   ` Geert Uytterhoeven
2015-06-15 19:44     ` Geert Uytterhoeven
2015-06-15 19:44     ` Geert Uytterhoeven
2015-06-15 19:44     ` Geert Uytterhoeven
2015-05-28 18:53 ` Geert Uytterhoeven [this message]
2015-05-28 18:53   ` [PATCH v2 13/14] clk: shmobile: mstp: Consider "zb_clk" suitable for power management Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-06-22 20:05   ` Michael Turquette
2015-06-22 20:05     ` Michael Turquette
2015-06-22 20:05     ` Michael Turquette
2015-06-22 20:05     ` Michael Turquette
2015-06-22 20:05     ` Michael Turquette
2015-06-22 20:17     ` Geert Uytterhoeven
2015-06-22 20:17       ` Geert Uytterhoeven
2015-06-22 20:17       ` Geert Uytterhoeven
2015-06-22 20:17       ` Geert Uytterhoeven
2015-06-22 20:17       ` Geert Uytterhoeven
2015-05-28 18:53 ` [PATCH v2 14/14] ARM: shmobile: R-Mobile: Use CPG Clock Domain attach/detach helpers Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-05-28 18:53   ` Geert Uytterhoeven
2015-06-08 21:42 ` [PATCH v2 00/14] ARM: shmobile: Add CPG Clock Domains Stephen Boyd
2015-06-08 21:42   ` Stephen Boyd
2015-06-08 21:42   ` Stephen Boyd
2015-06-15 16:15 ` Geert Uytterhoeven
2015-06-15 16:15   ` Geert Uytterhoeven
2015-06-15 16:15   ` Geert Uytterhoeven
2015-06-15 16:15   ` Geert Uytterhoeven
2015-06-15 16:15   ` Geert Uytterhoeven
2015-06-15 18:39   ` Kevin Hilman
2015-06-15 18:39     ` Kevin Hilman
2015-06-15 18:39     ` Kevin Hilman
2015-06-15 18:39     ` Kevin Hilman
2015-06-15 18:39     ` Kevin Hilman
2015-06-22 20:46   ` Michael Turquette
2015-06-22 20:46     ` Michael Turquette
2015-06-22 20:46     ` Michael Turquette
2015-06-22 20:46     ` Michael Turquette
2015-06-23  8:59     ` Geert Uytterhoeven
2015-06-23  8:59       ` Geert Uytterhoeven
2015-06-23  8:59       ` Geert Uytterhoeven
2015-06-23  8:59       ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432839219-475-14-git-send-email-geert+renesas@glider.be \
    --to=geert+renesas@glider.be \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.