All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: tglx@linutronix.de, mingo@kernel.org
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Kukjin Kim <kgene@kernel.org>,
	linux-kernel@vger.kernel.org (open list:CLOCKSOURCE, CLOC...),
	linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG
	EXYNO...),
	linux-samsung-soc@vger.kernel.org (moderated list:ARM/SAMSUNG
	EXYNO...)
Subject: [PATCH 02/11] clocksource/drivers/exynos_mct: Change exynos4_mct_tick_clear return type to void
Date: Tue,  2 Jun 2015 14:31:47 +0200	[thread overview]
Message-ID: <1433248316-26320-2-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1433248316-26320-1-git-send-email-daniel.lezcano@linaro.org>

From: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Return value of exynos4_mct_tick_clear() was never checked so it can
be safely changed to void.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/exynos_mct.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
index 83564c9..87c2e55 100644
--- a/drivers/clocksource/exynos_mct.c
+++ b/drivers/clocksource/exynos_mct.c
@@ -413,7 +413,7 @@ static inline void exynos4_tick_set_mode(enum clock_event_mode mode,
 	}
 }
 
-static int exynos4_mct_tick_clear(struct mct_clock_event_device *mevt)
+static void exynos4_mct_tick_clear(struct mct_clock_event_device *mevt)
 {
 	struct clock_event_device *evt = &mevt->evt;
 
@@ -426,12 +426,8 @@ static int exynos4_mct_tick_clear(struct mct_clock_event_device *mevt)
 		exynos4_mct_tick_stop(mevt);
 
 	/* Clear the MCT tick interrupt */
-	if (readl_relaxed(reg_base + mevt->base + MCT_L_INT_CSTAT_OFFSET) & 1) {
+	if (readl_relaxed(reg_base + mevt->base + MCT_L_INT_CSTAT_OFFSET) & 1)
 		exynos4_mct_write(0x1, mevt->base + MCT_L_INT_CSTAT_OFFSET);
-		return 1;
-	} else {
-		return 0;
-	}
 }
 
 static irqreturn_t exynos4_mct_tick_isr(int irq, void *dev_id)
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: tglx@linutronix.de, mingo@kernel.org
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Kukjin Kim <kgene@kernel.org>,
	"open list:CLOCKSOURCE, CLOC..." <linux-kernel@vger.kernel.org>,
	"moderated list:ARM/SAMSUNG EXYNO..."
	<linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/SAMSUNG EXYNO..."
	<linux-samsung-soc@vger.kernel.org>
Subject: [PATCH 02/11] clocksource/drivers/exynos_mct: Change exynos4_mct_tick_clear return type to void
Date: Tue,  2 Jun 2015 14:31:47 +0200	[thread overview]
Message-ID: <1433248316-26320-2-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1433248316-26320-1-git-send-email-daniel.lezcano@linaro.org>

From: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Return value of exynos4_mct_tick_clear() was never checked so it can
be safely changed to void.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/exynos_mct.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
index 83564c9..87c2e55 100644
--- a/drivers/clocksource/exynos_mct.c
+++ b/drivers/clocksource/exynos_mct.c
@@ -413,7 +413,7 @@ static inline void exynos4_tick_set_mode(enum clock_event_mode mode,
 	}
 }
 
-static int exynos4_mct_tick_clear(struct mct_clock_event_device *mevt)
+static void exynos4_mct_tick_clear(struct mct_clock_event_device *mevt)
 {
 	struct clock_event_device *evt = &mevt->evt;
 
@@ -426,12 +426,8 @@ static int exynos4_mct_tick_clear(struct mct_clock_event_device *mevt)
 		exynos4_mct_tick_stop(mevt);
 
 	/* Clear the MCT tick interrupt */
-	if (readl_relaxed(reg_base + mevt->base + MCT_L_INT_CSTAT_OFFSET) & 1) {
+	if (readl_relaxed(reg_base + mevt->base + MCT_L_INT_CSTAT_OFFSET) & 1)
 		exynos4_mct_write(0x1, mevt->base + MCT_L_INT_CSTAT_OFFSET);
-		return 1;
-	} else {
-		return 0;
-	}
 }
 
 static irqreturn_t exynos4_mct_tick_isr(int irq, void *dev_id)
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/11] clocksource/drivers/exynos_mct: Change exynos4_mct_tick_clear return type to void
Date: Tue,  2 Jun 2015 14:31:47 +0200	[thread overview]
Message-ID: <1433248316-26320-2-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1433248316-26320-1-git-send-email-daniel.lezcano@linaro.org>

From: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Return value of exynos4_mct_tick_clear() was never checked so it can
be safely changed to void.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/exynos_mct.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
index 83564c9..87c2e55 100644
--- a/drivers/clocksource/exynos_mct.c
+++ b/drivers/clocksource/exynos_mct.c
@@ -413,7 +413,7 @@ static inline void exynos4_tick_set_mode(enum clock_event_mode mode,
 	}
 }
 
-static int exynos4_mct_tick_clear(struct mct_clock_event_device *mevt)
+static void exynos4_mct_tick_clear(struct mct_clock_event_device *mevt)
 {
 	struct clock_event_device *evt = &mevt->evt;
 
@@ -426,12 +426,8 @@ static int exynos4_mct_tick_clear(struct mct_clock_event_device *mevt)
 		exynos4_mct_tick_stop(mevt);
 
 	/* Clear the MCT tick interrupt */
-	if (readl_relaxed(reg_base + mevt->base + MCT_L_INT_CSTAT_OFFSET) & 1) {
+	if (readl_relaxed(reg_base + mevt->base + MCT_L_INT_CSTAT_OFFSET) & 1)
 		exynos4_mct_write(0x1, mevt->base + MCT_L_INT_CSTAT_OFFSET);
-		return 1;
-	} else {
-		return 0;
-	}
 }
 
 static irqreturn_t exynos4_mct_tick_isr(int irq, void *dev_id)
-- 
1.9.1

  reply	other threads:[~2015-06-02 12:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <556DA1E5.1030601@linaro.org>
2015-06-02 12:31 ` [PATCH 01/11] clocksource/drivers/qcom: Remove dead code Daniel Lezcano
2015-06-02 12:31   ` Daniel Lezcano [this message]
2015-06-02 12:31     ` [PATCH 02/11] clocksource/drivers/exynos_mct: Change exynos4_mct_tick_clear return type to void Daniel Lezcano
2015-06-02 12:31     ` Daniel Lezcano
2015-06-02 12:31   ` [PATCH 03/11] clocksource/drivers/exynos_mct: Staticize struct clocksource Daniel Lezcano
2015-06-02 12:31     ` Daniel Lezcano
2015-06-02 12:31     ` Daniel Lezcano
2015-06-02 12:31   ` [PATCH 04/11] clocksource/drivers/exynos_mct: Remove old platform mct_init() Daniel Lezcano
2015-06-02 12:31     ` Daniel Lezcano
2015-06-02 12:31     ` Daniel Lezcano
2015-06-02 12:31   ` [PATCH 05/11] clocksource/drivers/lpc32xx: Add the lpc32xx timer driver Daniel Lezcano
2015-06-02 12:31   ` [PATCH 06/11] doc: dt: Add documentation for lpc3220-timer Daniel Lezcano
2015-06-02 12:31     ` Daniel Lezcano
2015-06-02 12:31   ` [PATCH 07/11] dt-bindings: Document the ARM System timer bindings Daniel Lezcano
2015-06-02 12:31     ` Daniel Lezcano
2015-06-02 12:31   ` [PATCH 08/11] clocksource/drivers/armv7m_systick: Add ARM System timer driver Daniel Lezcano
2015-06-02 12:31   ` [PATCH 09/11] dt-bindings: Document the STM32 timer bindings Daniel Lezcano
2015-06-02 12:31     ` Daniel Lezcano
2015-06-02 12:31   ` [PATCH 10/11] clockevents/drivers: Add STM32 Timer driver Daniel Lezcano
2015-06-02 12:31   ` [PATCH 11/11] clockevents/drivers/timer-stm32: Fix build warning spotted by kbuild test robot Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433248316-26320-2-git-send-email-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.