All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@primarydata.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH 1/6] SUNRPC: Fix a memory leak in the backchannel code
Date: Thu,  4 Jun 2015 17:26:48 -0400	[thread overview]
Message-ID: <1433453213-13466-1-git-send-email-trond.myklebust@primarydata.com> (raw)

req->rq_private_buf isn't initialised when xprt_setup_backchannel calls
xprt_free_allocation.

Fixes: fb7a0b9addbdb ("nfs41: New backchannel helper routines")
Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
---
 net/sunrpc/backchannel_rqst.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sunrpc/backchannel_rqst.c b/net/sunrpc/backchannel_rqst.c
index 9dd0ea8db463..28504dfd3dad 100644
--- a/net/sunrpc/backchannel_rqst.c
+++ b/net/sunrpc/backchannel_rqst.c
@@ -60,7 +60,7 @@ static void xprt_free_allocation(struct rpc_rqst *req)
 
 	dprintk("RPC:        free allocations for req= %p\n", req);
 	WARN_ON_ONCE(test_bit(RPC_BC_PA_IN_USE, &req->rq_bc_pa_state));
-	xbufp = &req->rq_private_buf;
+	xbufp = &req->rq_rcv_buf;
 	free_page((unsigned long)xbufp->head[0].iov_base);
 	xbufp = &req->rq_snd_buf;
 	free_page((unsigned long)xbufp->head[0].iov_base);
-- 
2.4.2


             reply	other threads:[~2015-06-04 21:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-04 21:26 Trond Myklebust [this message]
2015-06-04 21:26 ` [PATCH 2/6] SUNRPC: Backchannel handle socket nospace Trond Myklebust
2015-06-04 21:26   ` [PATCH 3/6] SUNRPC: Clean up bc_send() Trond Myklebust
2015-06-04 21:26     ` [PATCH 4/6] SUNRPC: Remove unused argument 'tk_ops' in rpc_run_bc_task Trond Myklebust
2015-06-04 21:26       ` [PATCH 5/6] SUNRPC: Clean up allocation and freeing of back channel requests Trond Myklebust
2015-06-04 21:26         ` [PATCH 6/6] SUNRPC: Fix a backchannel race Trond Myklebust
2015-07-21 16:21           ` Chuck Lever
2015-06-05  0:27       ` [PATCH 4/6] SUNRPC: Remove unused argument 'tk_ops' in rpc_run_bc_task Chuck Lever
2015-06-05 15:50     ` [PATCH 3/6] SUNRPC: Clean up bc_send() Andy Adamson
2015-06-05 16:02       ` Chuck Lever
2015-06-08 20:47         ` J. Bruce Fields
2015-06-08 20:52           ` Chuck Lever
2015-06-08 21:03           ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433453213-13466-1-git-send-email-trond.myklebust@primarydata.com \
    --to=trond.myklebust@primarydata.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.