All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Darren Hart <dvhart@infradead.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "Ben Skeggs" <bskeggs@redhat.com>,
	"Azael Avalos" <coproscefalo@gmail.com>,
	"Corentin Chary" <corentin.chary@gmail.com>,
	"Lee Chun-Yi" <jlee@suse.com>,
	"Cezary Jackiewicz" <cezary.jackiewicz@gmail.com>,
	"Matthew Garrett" <mjg59@srcf.ucam.org>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Ike Panhc" <ike.pan@canonical.com>,
	"Anisse Astier" <anisse@astier.eu>,
	"Mattia Dongili" <malattia@linux.it>,
	"Henrique de Moraes Holschuh" <ibm-acpi@hmh.eng.br>,
	platform-driver-x86@vger.kernel.org,
	ibm-acpi-devel@lists.sourceforge.net,
	acpi4asus-user@lists.sourceforge.net,
	dri-devel@lists.freedesktop.org, "Aaron Lu" <aaron.lu@intel.com>,
	linux-acpi@vger.kernel.org, "Hans de Goede" <hdegoede@redhat.com>
Subject: [PATCH 12/32] acpi-video: Move dmi_check_system from module_init to acpi_video_register
Date: Wed, 10 Jun 2015 15:01:12 +0200	[thread overview]
Message-ID: <1433941292-21530-13-git-send-email-hdegoede@redhat.com> (raw)
In-Reply-To: <1433941292-21530-1-git-send-email-hdegoede@redhat.com>

When builtin there is no guarantee in which order module_init functions
are run, so acpi_video_register() may get called from the i915 driver
(if it is also builtin) before acpi_video_init() gets called, resulting
in the dmi quirks not yet being parsed.

This commit moves the dmi_check_system() call to acpi_video_register(),
so that we can be sure the dmi quirks have always been applied before
probing.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/acpi/video.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index f5ffac9..b8053a8 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -380,13 +380,13 @@ acpi_video_device_lcd_set_level(struct acpi_video_device *device, int level)
  */
 
 static int bqc_offset_aml_bug_workaround;
-static int __init video_set_bqc_offset(const struct dmi_system_id *d)
+static int video_set_bqc_offset(const struct dmi_system_id *d)
 {
 	bqc_offset_aml_bug_workaround = 9;
 	return 0;
 }
 
-static struct dmi_system_id video_dmi_table[] __initdata = {
+static struct dmi_system_id video_dmi_table[] = {
 	/*
 	 * Broken _BQC workaround http://bugzilla.kernel.org/show_bug.cgi?id=13121
 	 */
@@ -1944,6 +1944,8 @@ int acpi_video_register(void)
 	mutex_init(&video_list_lock);
 	INIT_LIST_HEAD(&video_bus_head);
 
+	dmi_check_system(video_dmi_table);
+
 	ret = acpi_bus_register_driver(&acpi_video_bus);
 	if (ret)
 		return ret;
@@ -2009,8 +2011,6 @@ static int __init acpi_video_init(void)
 	if (acpi_disabled)
 		return 0;
 
-	dmi_check_system(video_dmi_table);
-
 	if (intel_opregion_present())
 		return 0;
 
-- 
2.4.2

  parent reply	other threads:[~2015-06-10 13:01 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-10 13:01 [PATCH 00/32] acpi-video: Rewrite backlight interface selection logic Hans de Goede
2015-06-10 13:01 ` [PATCH 01/32] apple-gmux: Stop using acpi_video_dmi_demote_vendor() Hans de Goede
2015-06-10 13:01 ` [PATCH 02/32] acpi-video-detect: Remove the unused acpi_video_dmi_demote_vendor() function Hans de Goede
2015-06-10 13:01 ` [PATCH 03/32] acpi-video-detect: Make acpi_video_get_capabilities a private function Hans de Goede
2015-06-10 13:01 ` [PATCH 04/32] acpi-video-detect: Move acpi_is_video_device() to acpi/scan.c Hans de Goede
2015-06-10 13:01 ` [PATCH 05/32] acpi-video-detect: Move acpi_osi_is_win8 to osl.c Hans de Goede
2015-06-10 13:01 ` [PATCH 06/32] acpi-video-detect: video: Make video_detect code part of the video module Hans de Goede
2015-06-10 13:01 ` [PATCH 07/32] acpi-video-detect: Rewrite backlight interface selection logic Hans de Goede
2015-06-11  9:00   ` Aaron Lu
2015-06-11  9:19     ` Hans de Goede
2015-06-11  9:29       ` Aaron Lu
2015-06-11  9:19   ` Pali Rohár
2015-06-11  9:29     ` Hans de Goede
2015-06-11 12:01       ` Pali Rohár
2015-06-11 12:28       ` Jani Nikula
     [not found]         ` <87bngm5szf.fsf-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-06-11 12:32           ` Hans de Goede
2015-06-10 13:01 ` [PATCH 08/32] acpi-video-detect: Unregister acpi_video backlight when dmi quirks are added Hans de Goede
2015-06-10 13:01 ` [PATCH 09/32] drm: i915: Port to new backlight interface selection API Hans de Goede
2015-06-10 13:01 ` [PATCH 10/32] acpi-video: " Hans de Goede
2015-06-10 13:01 ` [PATCH 11/32] acpi-video: Move backlight notifier to video_detect.c Hans de Goede
2015-06-10 13:01 ` Hans de Goede [this message]
2015-06-10 13:01 ` [PATCH 13/32] acpi-video: Fix acpi_video _register vs _unregister_backlight race Hans de Goede
2015-06-10 13:01 ` [PATCH 14/32] acer-wmi: Port to new backlight interface selection API Hans de Goede
2015-06-11  3:01   ` joeyli
2015-06-10 13:01 ` [PATCH 15/32] apple-gmux: " Hans de Goede
2015-06-10 13:01 ` [PATCH 16/32] asus-laptop: " Hans de Goede
2015-06-10 13:01 ` [PATCH 17/32] asus-wmi: " Hans de Goede
2015-06-10 13:01 ` [PATCH 18/32] compal-laptop: " Hans de Goede
2015-06-10 13:01 ` [PATCH 19/32] dell-laptop: " Hans de Goede
2015-06-11 11:47   ` Pali Rohár
2015-06-11 12:29     ` Hans de Goede
2015-06-11 13:06       ` Pali Rohár
2015-06-10 13:01 ` [PATCH 20/32] dell-wmi: " Hans de Goede
2015-06-11 11:43   ` Pali Rohár
2015-06-11 12:19     ` Hans de Goede
2015-06-11 12:59       ` Pali Rohár
2015-06-10 13:01 ` [PATCH 21/32] eeepc-laptop: " Hans de Goede
2015-06-10 13:01 ` [PATCH 22/32] fujitsu-laptop: " Hans de Goede
2015-06-10 23:04   ` Jonathan Woithe
2015-06-10 13:01 ` [PATCH 23/32] ideapad-laptop: " Hans de Goede
2015-06-10 13:01 ` [PATCH 24/32] intel-oaktrail: " Hans de Goede
2015-06-10 13:01 ` [PATCH 25/32] msi-laptop: " Hans de Goede
2015-06-10 13:01 ` [PATCH 26/32] msi-wmi: " Hans de Goede
2015-06-10 13:01 ` [PATCH 27/32] samsung-laptop: " Hans de Goede
2015-06-10 13:01 ` [PATCH 28/32] sony-laptop: " Hans de Goede
2015-06-10 21:30   ` Mattia Dongili
2015-06-12  8:18     ` Hans de Goede
2015-06-10 13:01 ` [PATCH 29/32] thinkpad-acpi: " Hans de Goede
2015-06-10 13:59   ` Henrique de Moraes Holschuh
2015-06-10 13:01 ` [PATCH 30/32] toshiba-acpi: " Hans de Goede
2015-06-10 13:01 ` [PATCH 31/32] acpi-video-detect: Remove old API Hans de Goede
2015-06-10 13:01 ` [PATCH 32/32] acpi-video: Make acpi_video_unregister_backlight() private Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433941292-21530-13-git-send-email-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=aaron.lu@intel.com \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=anisse@astier.eu \
    --cc=bskeggs@redhat.com \
    --cc=cezary.jackiewicz@gmail.com \
    --cc=coproscefalo@gmail.com \
    --cc=corentin.chary@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dvhart@infradead.org \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=ibm-acpi@hmh.eng.br \
    --cc=ike.pan@canonical.com \
    --cc=jlee@suse.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=malattia@linux.it \
    --cc=mjg59@srcf.ucam.org \
    --cc=pali.rohar@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.