All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Russell King <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH] ARM: debug: Remove unsupported operand from Kconfig.debug
Date: Sun, 14 Jun 2015 11:23:21 -0700	[thread overview]
Message-ID: <1434306201-21840-1-git-send-email-linux@roeck-us.net> (raw)

arm builds show the following warning.

arch/arm/Kconfig.debug:1576:warning: ignoring unsupported character '>'

This is due to

config DEBUG_UART_8250_WORD
	bool "Use 32-bit accesses for 8250 UART"
	depends on DEBUG_LL_UART_8250 || DEBUG_UART_8250
	depends on DEBUG_UART_8250_SHIFT >= 2

This may create the false expectation that DEBUG_UART_8250_WORD
is enabled if DEBUG_UART_8250_SHIFT is larger than 2, so drop the '>'.

Fixes: 0b4cccbec606 ("ARM: debug: add support for word accesses to
	debug/8250.S")
Cc: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 arch/arm/Kconfig.debug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index f1b157971366..f0655c9350bf 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -1573,7 +1573,7 @@ config DEBUG_UART_8250_SHIFT
 config DEBUG_UART_8250_WORD
 	bool "Use 32-bit accesses for 8250 UART"
 	depends on DEBUG_LL_UART_8250 || DEBUG_UART_8250
-	depends on DEBUG_UART_8250_SHIFT >= 2
+	depends on DEBUG_UART_8250_SHIFT = 2
 	default y if DEBUG_PICOXCELL_UART || DEBUG_SOCFPGA_UART0 || \
 		DEBUG_SOCFPGA_UART1 || ARCH_KEYSTONE || \
 		DEBUG_ALPINE_UART0 || \
-- 
2.1.0


WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: debug: Remove unsupported operand from Kconfig.debug
Date: Sun, 14 Jun 2015 11:23:21 -0700	[thread overview]
Message-ID: <1434306201-21840-1-git-send-email-linux@roeck-us.net> (raw)

arm builds show the following warning.

arch/arm/Kconfig.debug:1576:warning: ignoring unsupported character '>'

This is due to

config DEBUG_UART_8250_WORD
	bool "Use 32-bit accesses for 8250 UART"
	depends on DEBUG_LL_UART_8250 || DEBUG_UART_8250
	depends on DEBUG_UART_8250_SHIFT >= 2

This may create the false expectation that DEBUG_UART_8250_WORD
is enabled if DEBUG_UART_8250_SHIFT is larger than 2, so drop the '>'.

Fixes: 0b4cccbec606 ("ARM: debug: add support for word accesses to
	debug/8250.S")
Cc: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 arch/arm/Kconfig.debug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index f1b157971366..f0655c9350bf 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -1573,7 +1573,7 @@ config DEBUG_UART_8250_SHIFT
 config DEBUG_UART_8250_WORD
 	bool "Use 32-bit accesses for 8250 UART"
 	depends on DEBUG_LL_UART_8250 || DEBUG_UART_8250
-	depends on DEBUG_UART_8250_SHIFT >= 2
+	depends on DEBUG_UART_8250_SHIFT = 2
 	default y if DEBUG_PICOXCELL_UART || DEBUG_SOCFPGA_UART0 || \
 		DEBUG_SOCFPGA_UART1 || ARCH_KEYSTONE || \
 		DEBUG_ALPINE_UART0 || \
-- 
2.1.0

             reply	other threads:[~2015-06-14 18:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-14 18:23 Guenter Roeck [this message]
2015-06-14 18:23 ` [PATCH] ARM: debug: Remove unsupported operand from Kconfig.debug Guenter Roeck
2015-06-14 19:13 ` Russell King - ARM Linux
2015-06-14 19:13   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434306201-21840-1-git-send-email-linux@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.