From: Daniel Vetter <daniel.vetter@ffwll.ch> To: Intel Graphics Development <intel-gfx@lists.freedesktop.org> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Mark Janes <mark.a.janes@intel.com>, stable@vger.kernel.org, Daniel Vetter <daniel.vetter@intel.com> Subject: [PATCH] drm/i915: Officially give up on seqno coherency Date: Fri, 19 Jun 2015 18:43:04 +0200 [thread overview] Message-ID: <1434732184-27338-1-git-send-email-daniel.vetter@ffwll.ch> (raw) We've never figured out the magic trick to make irq vs. seqno updates coherent, only tricks to make it work. And since commit 094f9a54e35500739da185cdb78f2e92fc379458 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Wed Sep 25 17:34:55 2013 +0100 drm/i915: Fix __wait_seqno to use true infinite timeouts we automatically fall back to an irq augmented with polling scheme after the first missed interrupt. There's really nothing else we can do, hence tune down the message to informational level. It's still useful for users in case it reliable preceedes a hard system hang. Cc: Mark Janes <mark.a.janes@intel.com> Cc: stable@vger.kernel.org Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/i915/i915_irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index e6bb72dca3ff..9350f2e5cd04 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -2946,8 +2946,8 @@ static void i915_hangcheck_elapsed(struct work_struct *work) /* Issue a wake-up to catch stuck h/w. */ if (!test_and_set_bit(ring->id, &dev_priv->gpu_error.missed_irq_rings)) { if (!(dev_priv->gpu_error.test_irq_rings & intel_ring_flag(ring))) - DRM_ERROR("Hangcheck timer elapsed... %s idle\n", - ring->name); + DRM_INFO("Hangcheck timer elapsed... %s idle\n", + ring->name); else DRM_INFO("Fake missed irq on %s\n", ring->name); -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe stable" in
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel.vetter@ffwll.ch> To: Intel Graphics Development <intel-gfx@lists.freedesktop.org> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Mark Janes <mark.a.janes@intel.com>, stable@vger.kernel.org, Daniel Vetter <daniel.vetter@intel.com> Subject: [PATCH] drm/i915: Officially give up on seqno coherency Date: Fri, 19 Jun 2015 18:43:04 +0200 [thread overview] Message-ID: <1434732184-27338-1-git-send-email-daniel.vetter@ffwll.ch> (raw) We've never figured out the magic trick to make irq vs. seqno updates coherent, only tricks to make it work. And since commit 094f9a54e35500739da185cdb78f2e92fc379458 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Wed Sep 25 17:34:55 2013 +0100 drm/i915: Fix __wait_seqno to use true infinite timeouts we automatically fall back to an irq augmented with polling scheme after the first missed interrupt. There's really nothing else we can do, hence tune down the message to informational level. It's still useful for users in case it reliable preceedes a hard system hang. Cc: Mark Janes <mark.a.janes@intel.com> Cc: stable@vger.kernel.org Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/i915/i915_irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index e6bb72dca3ff..9350f2e5cd04 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -2946,8 +2946,8 @@ static void i915_hangcheck_elapsed(struct work_struct *work) /* Issue a wake-up to catch stuck h/w. */ if (!test_and_set_bit(ring->id, &dev_priv->gpu_error.missed_irq_rings)) { if (!(dev_priv->gpu_error.test_irq_rings & intel_ring_flag(ring))) - DRM_ERROR("Hangcheck timer elapsed... %s idle\n", - ring->name); + DRM_INFO("Hangcheck timer elapsed... %s idle\n", + ring->name); else DRM_INFO("Fake missed irq on %s\n", ring->name); -- 2.1.4
next reply other threads:[~2015-06-19 16:40 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-19 16:43 Daniel Vetter [this message] 2015-06-19 16:43 ` [PATCH] drm/i915: Officially give up on seqno coherency Daniel Vetter 2015-06-19 16:58 ` [Intel-gfx] " Chris Wilson 2015-06-19 16:58 ` Chris Wilson 2015-06-19 19:16 ` Daniel Vetter 2015-06-19 19:16 ` Daniel Vetter 2015-06-19 19:26 ` Chris Wilson 2015-06-19 19:26 ` Chris Wilson 2015-06-23 10:05 ` [Intel-gfx] " Jani Nikula 2015-06-23 10:05 ` Jani Nikula 2015-06-23 11:52 ` Daniel Vetter 2015-06-24 9:59 ` Chris Wilson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1434732184-27338-1-git-send-email-daniel.vetter@ffwll.ch \ --to=daniel.vetter@ffwll.ch \ --cc=daniel.vetter@intel.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=mark.a.janes@intel.com \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.