All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 3/4] drm/i915: don't disable FBC for pipe A when flipping pipe B
Date: Tue, 14 Jul 2015 16:29:13 -0300	[thread overview]
Message-ID: <1436902154-6979-5-git-send-email-przanoni@gmail.com> (raw)
In-Reply-To: <1436902154-6979-1-git-send-email-przanoni@gmail.com>

From: Paulo Zanoni <paulo.r.zanoni@intel.com>

Use the appropriate call.

I know there's a discussion about whether we need this call here at
all, but removing the call means we'll only update FBC after we get
the page flip IRQ. So the user may only see the new frame a little
after it should. Let's wait just a little bit more before removing
this call since we can rely in the HW tracking for accurate flips.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 37b2528..6e3ba5f 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -11544,7 +11544,7 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc,
 			  to_intel_plane(primary)->frontbuffer_bit);
 	mutex_unlock(&dev->struct_mutex);
 
-	intel_fbc_disable(dev_priv);
+	intel_fbc_disable_crtc(intel_crtc);
 	intel_frontbuffer_flip_prepare(dev,
 				       to_intel_plane(primary)->frontbuffer_bit);
 
-- 
2.1.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-07-14 19:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-14 19:29 [PATCH 0/4] FBC frontbuffer tracking + MMAP_WC fixes Paulo Zanoni
2015-07-14 19:29 ` [PATCH 1/4] drm/i915: fix FBC frontbuffer tracking flushing code Paulo Zanoni
2015-07-30 23:37   ` Rodrigo Vivi
2015-07-31 15:26     ` Paulo Zanoni
2015-07-14 19:29 ` [PATCH 2/4] drm/i915: don't call intel_fbc_update() at intel_unpin_work_fn() Paulo Zanoni
2015-07-30 23:40   ` Rodrigo Vivi
2015-07-14 19:29 ` [PATCH igt] kms_frontbuffer_tracking: use the dirty ioctl after MMAP_WC calls Paulo Zanoni
2015-07-14 19:29 ` Paulo Zanoni [this message]
2015-07-15 12:33   ` [PATCH 3/4] drm/i915: don't disable FBC for pipe A when flipping pipe B Daniel Vetter
2015-07-30 23:46     ` Rodrigo Vivi
2015-07-14 19:29 ` [PATCH 4/4] drm/i915: special-case dirtyfb for frontbuffer tracking Paulo Zanoni
2015-07-30 23:48   ` Rodrigo Vivi
2015-08-05  8:01     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436902154-6979-5-git-send-email-przanoni@gmail.com \
    --to=przanoni@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.