All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
To: tprevite@gmail.com, intel-gfx@lists.freedesktop.org
Subject: [PATCH] drm/i915: fix checksum write for automated test reply
Date: Wed, 22 Jul 2015 15:36:48 +0530	[thread overview]
Message-ID: <1437559608-4742-1-git-send-email-sivakumar.thulasimani@intel.com> (raw)

From: "Thulasimani,Sivakumar" <sivakumar.thulasimani@intel.com>

DP spec requires the checksum of the last block read to be written
when replying to TEST_EDID_READ. This patch fixes the current code
to do the same.

Signed-off-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c |   11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index f1b9f93..9617d04 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -4090,9 +4090,18 @@ static uint8_t intel_dp_autotest_edid(struct intel_dp *intel_dp)
 				      intel_dp->aux.i2c_defer_count);
 		intel_dp->compliance_test_data = INTEL_DP_RESOLUTION_FAILSAFE;
 	} else {
+		struct edid *block = intel_connector->detect_edid;
+		uint8_t temp = intel_connector->detect_edid->extensions;
+
+		/* We have to write the checksum
+		 * of the last block read
+		 */
+		while (temp--)
+			block++;
+
 		if (!drm_dp_dpcd_write(&intel_dp->aux,
 					DP_TEST_EDID_CHECKSUM,
-					&intel_connector->detect_edid->checksum,
+					&block->checksum,
 					1))
 			DRM_DEBUG_KMS("Failed to write EDID checksum\n");
 
-- 
1.7.9.5

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2015-07-22 10:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-22 10:06 Sivakumar Thulasimani [this message]
2015-07-22 12:00 ` [PATCH] drm/i915: fix checksum write for automated test reply Daniel Vetter
2015-07-22 12:59   ` Sivakumar Thulasimani
2015-07-22 13:01 Sivakumar Thulasimani
2015-07-23 21:47 ` shuang.he
2015-07-27  4:41 ` Sivakumar Thulasimani
2015-08-07  9:44 Sivakumar Thulasimani
2015-08-12  6:06 ` Sivakumar Thulasimani
2015-08-12 12:43   ` Daniel Vetter
2015-08-14  8:27 ` Jindal, Sonika
2015-08-14  9:12   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437559608-4742-1-git-send-email-sivakumar.thulasimani@intel.com \
    --to=sivakumar.thulasimani@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tprevite@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.