All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Yao <mark.yao@rock-chips.com>
To: dri-devel@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>, Heiko Stuebner <heiko@sntech.de>,
	Daniel Kurtz <djkurtz@chromium.org>,
	Mark Yao <mark.yao@rock-chips.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Daniel Vetter <daniel@ffwll.ch>, Rob Clark <robdclark@gmail.com>,
	tfiga@chromium.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	sandy.huang@rock-chips.com, dkm@rock-chips.com,
	zwl@rock-chips.com
Subject: [PATCH v4 1/6] drm/rockchip: vop: Fix virtual stride calculation
Date: Mon, 27 Jul 2015 10:05:57 +0800	[thread overview]
Message-ID: <1437962762-19157-2-git-send-email-mark.yao@rock-chips.com> (raw)
In-Reply-To: <1437962762-19157-1-git-send-email-mark.yao@rock-chips.com>

vir_stride need number words of the virtual width, and fb->pitches
save bytes_per_pixel, so just div 4 switch to stride.

Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
---
Changes in v4: None

Changes in v3:
Adviced by Tomasz Figa
- use more suitable tile for this patch. 

Changes in v2: None

 drivers/gpu/drm/rockchip/rockchip_drm_vop.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index 34b78e7..6b44731 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -667,7 +667,7 @@ static int vop_update_plane_event(struct drm_plane *plane,
 	offset += (src.y1 >> 16) * fb->pitches[0];
 	yrgb_mst = rk_obj->dma_addr + offset;
 
-	y_vir_stride = fb->pitches[0] / (fb->bits_per_pixel >> 3);
+	y_vir_stride = fb->pitches[0] >> 2;
 
 	/*
 	 * If this plane update changes the plane's framebuffer, (or more
-- 
1.7.9.5



WARNING: multiple messages have this Message-ID (diff)
From: Mark Yao <mark.yao@rock-chips.com>
To: dri-devel@lists.freedesktop.org
Cc: zwl@rock-chips.com, linux-kernel@vger.kernel.org,
	tfiga@chromium.org, linux-rockchip@lists.infradead.org,
	dkm@rock-chips.com, sandy.huang@rock-chips.com,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/6] drm/rockchip: vop: Fix virtual stride calculation
Date: Mon, 27 Jul 2015 10:05:57 +0800	[thread overview]
Message-ID: <1437962762-19157-2-git-send-email-mark.yao@rock-chips.com> (raw)
In-Reply-To: <1437962762-19157-1-git-send-email-mark.yao@rock-chips.com>

vir_stride need number words of the virtual width, and fb->pitches
save bytes_per_pixel, so just div 4 switch to stride.

Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
---
Changes in v4: None

Changes in v3:
Adviced by Tomasz Figa
- use more suitable tile for this patch. 

Changes in v2: None

 drivers/gpu/drm/rockchip/rockchip_drm_vop.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index 34b78e7..6b44731 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -667,7 +667,7 @@ static int vop_update_plane_event(struct drm_plane *plane,
 	offset += (src.y1 >> 16) * fb->pitches[0];
 	yrgb_mst = rk_obj->dma_addr + offset;
 
-	y_vir_stride = fb->pitches[0] / (fb->bits_per_pixel >> 3);
+	y_vir_stride = fb->pitches[0] >> 2;
 
 	/*
 	 * If this plane update changes the plane's framebuffer, (or more
-- 
1.7.9.5


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-07-27  2:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27  2:05 [PATCH v4 0/6] drm/rockchip: fixes and new features Mark Yao
2015-07-27  2:05 ` Mark Yao
2015-07-27  2:05 ` Mark Yao [this message]
2015-07-27  2:05   ` [PATCH v4 1/6] drm/rockchip: vop: Fix virtual stride calculation Mark Yao
2015-07-27  2:05 ` [PATCH v4 2/6] drm/rockchip: vop: Fix window dest start point Mark Yao
2015-07-27  2:05   ` Mark Yao
2015-07-27  2:05 ` [PATCH v4 3/6] drm/rockchip: vop: Add yuv plane support Mark Yao
2015-07-27  2:05   ` Mark Yao
2015-07-27  2:05   ` Mark Yao
2015-07-27  2:06 ` [PATCH v4 4/6] drm/rockchip: vop: Default enable win2/3 area0 bit Mark Yao
2015-07-27  2:06   ` Mark Yao
2015-07-27  2:06   ` Mark Yao
2015-07-27  2:08 ` [PATCH v4 5/6] drm/rockchip: vop: restore vop registers when resume Mark Yao
2015-07-27  2:08   ` Mark Yao
2015-07-27  2:08   ` Mark Yao
2015-07-27  2:09 ` [PATCH v4 6/6] drm/rockchip: vop: support plane scale Mark Yao
2015-07-27  2:09   ` Mark Yao
2015-07-27  2:09   ` Mark Yao
2015-08-26  6:34 ` [GIT PULL] drm/rockchip: fixes and new features Mark yao
2015-08-26  6:34   ` Mark yao
2015-08-26  6:34   ` Mark yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437962762-19157-2-git-send-email-mark.yao@rock-chips.com \
    --to=mark.yao@rock-chips.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=djkurtz@chromium.org \
    --cc=dkm@rock-chips.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robdclark@gmail.com \
    --cc=sandy.huang@rock-chips.com \
    --cc=tfiga@chromium.org \
    --cc=zwl@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.