All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonyoung Shim <jy0922.shim@samsung.com>
To: dri-devel@lists.freedesktop.org
Cc: sw0312.kim@samsung.com
Subject: [PATCH 08/14] drm/exynos: create a fake mmap offset with gem creation
Date: Tue, 28 Jul 2015 17:53:23 +0900	[thread overview]
Message-ID: <1438073609-32664-8-git-send-email-jy0922.shim@samsung.com> (raw)
In-Reply-To: <1438073609-32664-1-git-send-email-jy0922.shim@samsung.com>

Don't create a fake mmap offset in exynos_drm_gem_dumb_map_offset. If
not, it will call drm_gem_create_mmap_offset whenever user requests
DRM_IOCTL_MODE_MAP_DUMB ioctl.

Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_gem.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c
index 550d267..c76aa8a 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_gem.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c
@@ -151,6 +151,13 @@ struct exynos_drm_gem_obj *exynos_drm_gem_init(struct drm_device *dev,
 		return ERR_PTR(ret);
 	}
 
+	ret = drm_gem_create_mmap_offset(obj);
+	if (ret < 0) {
+		drm_gem_object_release(obj);
+		kfree(exynos_gem_obj);
+		return ERR_PTR(ret);
+	}
+
 	DRM_DEBUG_KMS("created file object = 0x%x\n", (unsigned int)obj->filp);
 
 	return exynos_gem_obj;
@@ -521,14 +528,9 @@ int exynos_drm_gem_dumb_map_offset(struct drm_file *file_priv,
 		goto unlock;
 	}
 
-	ret = drm_gem_create_mmap_offset(obj);
-	if (ret)
-		goto out;
-
 	*offset = drm_vma_node_offset_addr(&obj->vma_node);
 	DRM_DEBUG_KMS("offset = 0x%lx\n", (unsigned long)*offset);
 
-out:
 	drm_gem_object_unreference(obj);
 unlock:
 	mutex_unlock(&dev->struct_mutex);
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2015-07-28  8:53 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28  8:53 [PATCH 01/14] drm/exynos: stop using sgtable in page fault handler Joonyoung Shim
2015-07-28  8:53 ` [PATCH 02/14] drm/exynos: remove function convert_to_vm_err_msg Joonyoung Shim
2015-08-16  4:39   ` Inki Dae
2015-07-28  8:53 ` [PATCH 03/14] drm/exynos: remove mutex locking in pagefault handler Joonyoung Shim
2015-07-28  8:53 ` [PATCH 04/14] drm/exynos: remove function exynos_drm_gem_map_buf Joonyoung Shim
2015-07-28  8:53 ` [PATCH 05/14] drm/exynos: stop copying sg table Joonyoung Shim
2015-07-28  8:53 ` [PATCH 06/14] drm/exynos: remove unused fields of struct exynos_drm_gem_buf Joonyoung Shim
2015-07-28  8:53 ` [PATCH 07/14] drm/exynos: use ERR_PTR instead of NULL in exynos_drm_gem_init Joonyoung Shim
2015-07-28  8:53 ` Joonyoung Shim [this message]
2015-08-16  4:50   ` [PATCH 08/14] drm/exynos: create a fake mmap offset with gem creation Inki Dae
2015-08-17  5:29     ` Joonyoung Shim
2015-08-17  7:39       ` Inki Dae
2015-11-16 16:22   ` Daniel Vetter
2015-11-16 16:23     ` Daniel Vetter
2015-11-17  2:53       ` Inki Dae
2015-11-17  9:42         ` Daniel Vetter
2015-07-28  8:53 ` [PATCH 09/14] drm/exynos: remove call to drm_gem_free_mmap_offset() Joonyoung Shim
2015-08-16  5:07   ` Inki Dae
2015-08-17  5:29     ` Joonyoung Shim
2015-08-17  7:52       ` Inki Dae
2015-08-17  8:17         ` Joonyoung Shim
2015-08-17  9:03           ` Inki Dae
2015-09-24  1:01             ` Joonyoung Shim
2015-09-25  9:15               ` Inki Dae
2015-09-30  5:45                 ` Joonyoung Shim
2015-07-28  8:53 ` [PATCH 10/14] drm/exynos: remove function check_gem_flags Joonyoung Shim
2015-08-06 10:00   ` Daniel Stone
2015-08-11  0:23     ` Joonyoung Shim
2015-08-16  5:14   ` Inki Dae
2015-07-28  8:53 ` [PATCH 11/14] drm/exynos: remove function update_vm_cache_attr Joonyoung Shim
2015-07-28  8:53 ` [PATCH 12/14] drm/exynos: remove function roundup_gem_size Joonyoung Shim
2015-07-28  8:53 ` [PATCH 13/14] drm/exynos: use prime helpers Joonyoung Shim
2015-08-16  5:26   ` Inki Dae
2015-08-16  5:43     ` Inki Dae
2015-07-28  8:53 ` [PATCH 14/14] drm/exynos: merge exynos_drm_buf.c to exynos_drm_gem.c Joonyoung Shim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438073609-32664-8-git-send-email-jy0922.shim@samsung.com \
    --to=jy0922.shim@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sw0312.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.