All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Alexander Graf <agraf@suse.de>, KVM <kvm@vger.kernel.org>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Jens Freimann <jfrei@linux.vnet.ibm.com>,
	linux-s390 <linux-s390@vger.kernel.org>,
	Christian Borntraeger <borntraeger@de.ibm.com>
Subject: [GIT PULL 09/16] KVM: s390: add more debug data for the pfault diagnoses
Date: Wed, 29 Jul 2015 11:05:59 +0200	[thread overview]
Message-ID: <1438160766-108179-10-git-send-email-borntraeger@de.ibm.com> (raw)
In-Reply-To: <1438160766-108179-1-git-send-email-borntraeger@de.ibm.com>

We're not only interested in the address of the control block, but
also in the requested subcommand and for the token subcommand, in the
specified token address and masks.

Suggested-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
---
 arch/s390/kvm/diag.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/s390/kvm/diag.c b/arch/s390/kvm/diag.c
index 1871754..5fbfb88 100644
--- a/arch/s390/kvm/diag.c
+++ b/arch/s390/kvm/diag.c
@@ -88,6 +88,9 @@ static int __diag_page_ref_service(struct kvm_vcpu *vcpu)
 
 	switch (parm.subcode) {
 	case 0: /* TOKEN */
+		VCPU_EVENT(vcpu, 3, "pageref token addr 0x%llx "
+			   "select mask 0x%llx compare mask 0x%llx",
+			   parm.token_addr, parm.select_mask, parm.compare_mask);
 		if (vcpu->arch.pfault_token != KVM_S390_PFAULT_TOKEN_INVALID) {
 			/*
 			 * If the pagefault handshake is already activated,
@@ -117,6 +120,7 @@ static int __diag_page_ref_service(struct kvm_vcpu *vcpu)
 		 * the cancel, therefore to reduce code complexity, we assume
 		 * all outstanding tokens are already pending.
 		 */
+		VCPU_EVENT(vcpu, 3, "pageref cancel addr 0x%llx", parm.token_addr);
 		if (parm.token_addr || parm.select_mask ||
 		    parm.compare_mask || parm.zarch)
 			return kvm_s390_inject_program_int(vcpu, PGM_SPECIFICATION);
-- 
2.3.0

  parent reply	other threads:[~2015-07-29  9:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-29  9:05 [GIT PULL 00/16] KVM: s390: Fixes and features for kvm/next (4.3) Christian Borntraeger
2015-07-29  9:05 ` [GIT PULL 01/16] KVM: s390: propagate error from enable storage key Christian Borntraeger
2015-07-29  9:05 ` [GIT PULL 02/16] KVM: s390: filter space-switch events when PER is enforced Christian Borntraeger
2015-07-29  9:05 ` [GIT PULL 03/16] KVM: s390: clean up cmma_enable check Christian Borntraeger
2015-07-29  9:05 ` [GIT PULL 04/16] KVM: s390: only reset CMMA state if it was enabled before Christian Borntraeger
2015-07-29  9:05 ` [GIT PULL 05/16] KVM: s390: add kvm stat counter for all diagnoses Christian Borntraeger
2015-07-29  9:05 ` [GIT PULL 06/16] KVM: s390: Improve vcpu event debugging for diagnoses Christian Borntraeger
2015-07-29  9:05 ` [GIT PULL 07/16] KVM: s390: VCPU_EVENT cleanup for prefix changes Christian Borntraeger
2015-07-29  9:05 ` [GIT PULL 08/16] KVM: s390: remove "from (user|kernel)" from irq injection messages Christian Borntraeger
2015-07-29  9:05 ` Christian Borntraeger [this message]
2015-07-29  9:06 ` [GIT PULL 10/16] KVM: s390: Fixup interrupt vcpu event messages and levels Christian Borntraeger
2015-07-29  9:06 ` [GIT PULL 11/16] KVM: s390: more irq names for trace events Christian Borntraeger
2015-07-29  9:06 ` [GIT PULL 12/16] KVM: s390: remove outdated documentation Christian Borntraeger
2015-07-29  9:06 ` [GIT PULL 13/16] KVM: s390: improve debug feature usage Christian Borntraeger
2015-07-29  9:06 ` [GIT PULL 14/16] KVM: s390: adapt debug entries for instruction handling Christian Borntraeger
2015-07-29  9:06 ` [GIT PULL 15/16] KVM: s390: Provide global debug log Christian Borntraeger
2015-07-29  9:06 ` [GIT PULL 16/16] KVM: s390: log capability enablement and vm attribute changes Christian Borntraeger
2015-07-29 10:56 ` [GIT PULL 00/16] KVM: s390: Fixes and features for kvm/next (4.3) Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438160766-108179-10-git-send-email-borntraeger@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=agraf@suse.de \
    --cc=cornelia.huck@de.ibm.com \
    --cc=jfrei@linux.vnet.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.