All of lore.kernel.org
 help / color / mirror / Atom feed
From: Animesh Manna <animesh.manna@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@intel.com>
Subject: [DMC-REDESIGN-PATCHES 02/12] drm/i915/gen9: csr_init after runtime pm enable
Date: Tue,  4 Aug 2015 20:49:56 +0530	[thread overview]
Message-ID: <1438701606-28752-3-git-send-email-animesh.manna@intel.com> (raw)
In-Reply-To: <1438701606-28752-1-git-send-email-animesh.manna@intel.com>

As skl is fully dependent on dmc to go to low power state (dc5/dc6)
which requires a trigger from rpm and to ensure the dmc firmware
is available for runtime pm support rpm-reference-count is used
by not releasing the rpm reference acquire when starting the
firmware loader work.

So moved the intel_csr_ucode_init call after runtime pm enable.

Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Damien Lespiau <damien.lespiau@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Sunil Kamath <sunil.kamath@intel.com>
Signed-off-by: Animesh Manna <animesh.manna@intel.com>
---
 drivers/gpu/drm/i915/i915_dma.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
index b1f9e55..a41246e 100644
--- a/drivers/gpu/drm/i915/i915_dma.c
+++ b/drivers/gpu/drm/i915/i915_dma.c
@@ -877,9 +877,6 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags)
 
 	intel_uncore_init(dev);
 
-	/* Load CSR Firmware for SKL */
-	intel_csr_ucode_init(dev);
-
 	ret = i915_gem_gtt_init(dev);
 	if (ret)
 		goto out_freecsr;
@@ -1027,6 +1024,9 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags)
 
 	i915_audio_component_init(dev_priv);
 
+	/* Load CSR Firmware for SKL */
+	intel_csr_ucode_init(dev);
+
 	return 0;
 
 out_power_well:
-- 
2.0.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-08-04 15:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-04 15:19 [DMC-REDESIGN-PATCHES 00/12] Redesign dmc firmware loading Animesh Manna
2015-08-04 15:19 ` [DMC-REDESIGN-PATCHES 01/12] drm/i915: use correct power domain for csr loading Animesh Manna
2015-08-04 15:19 ` Animesh Manna [this message]
2015-08-05  9:21   ` [DMC-REDESIGN-PATCHES 02/12] drm/i915/gen9: csr_init after runtime pm enable Daniel Vetter
2015-08-04 15:19 ` [DMC-REDESIGN-PATCHES 03/12] drm/i915/bxt: release rpm reference if csr firmware failed to load Animesh Manna
2015-08-04 15:19 ` [DMC-REDESIGN-PATCHES 04/12] drm/i915/gen9: move assert_csr_loaded into intel_rpm.c Animesh Manna
2015-08-04 15:19 ` [DMC-REDESIGN-PATCHES 05/12] drm/i915/gen9: Remove csr.state, csr_lock and related code Animesh Manna
2015-08-04 15:20 ` [DMC-REDESIGN-PATCHES 06/12] drm/i915/gen9: Align line continuations in intel_csr.c Animesh Manna
2015-08-04 15:20 ` [DMC-REDESIGN-PATCHES 07/12] drm/i915/gen9: Simplify csr loading failure printing Animesh Manna
2015-08-04 15:20 ` [DMC-REDESIGN-PATCHES 08/12] drm/i915/gen9: extract parse_csr_fw Animesh Manna
2015-08-04 15:20 ` [DMC-REDESIGN-PATCHES 09/12] drm/i915/gen9: Don't try to load garbage dmc firmware on resume Animesh Manna
2015-08-04 15:20 ` [DMC-REDESIGN-PATCHES 10/12] drm/i915/gen9: Use dev_priv in csr functions Animesh Manna
2015-08-04 15:20 ` [DMC-REDESIGN-PATCHES 11/12] drm/i915: Use request_firmware and our own async work Animesh Manna
2015-08-04 15:20 ` [DMC-REDESIGN-PATCHES 12/12] drm/i915/gen9: Use flush_work to synchronize with dmc loader Animesh Manna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438701606-28752-3-git-send-email-animesh.manna@intel.com \
    --to=animesh.manna@intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.