All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: Takashi Iwai <tiwai@suse.de>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Mark Brown <broonie@kernel.org>
Subject: [PATCH] topology: fix output file unlinking
Date: Tue, 11 Aug 2015 14:25:58 +0100	[thread overview]
Message-ID: <1439299559-5051-1-git-send-email-liam.r.girdwood@linux.intel.com> (raw)

Unlinking is unecessary as the old file will be overwritten with the new
as intended.

Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
---
 src/topology/parser.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/topology/parser.c b/src/topology/parser.c
index ed25bb8..5544517 100644
--- a/src/topology/parser.c
+++ b/src/topology/parser.c
@@ -266,9 +266,6 @@ int snd_tplg_build_file(snd_tplg_t *tplg, const char *infile,
 	snd_config_t *cfg = NULL;
 	int err = 0;
 
-	/* delete any old output files */
-	unlink(outfile);
-
 	tplg->out_fd =
 		open(outfile, O_RDWR | O_CREAT, S_IRWXU | S_IRWXG | S_IRWXO);
 	if (tplg->out_fd < 0) {
-- 
2.1.4

             reply	other threads:[~2015-08-11 13:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11 13:25 Liam Girdwood [this message]
2015-08-11 13:25 ` [PATCH] topology: fix file permissions for output file to 0600 Liam Girdwood
2015-08-11 13:36   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439299559-5051-1-git-send-email-liam.r.girdwood@linux.intel.com \
    --to=liam.r.girdwood@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.