All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: <tglx@linutronix.de>, <tony@atomide.com>, <marc.zyngier@arm.com>
Cc: <linux@arm.linux.org.uk>, <nsekhar@ti.com>,
	<jason@lakedaemon.net>, <balbi@ti.com>,
	<linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	Grygorii Strashko <grygorii.strashko@ti.com>
Subject: [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE
Date: Wed, 12 Aug 2015 20:45:58 +0300	[thread overview]
Message-ID: <1439401562-28874-3-git-send-email-grygorii.strashko@ti.com> (raw)
In-Reply-To: <1439401562-28874-1-git-send-email-grygorii.strashko@ti.com>

The irqchip_set_wake_parent should not fail if IRQ chip
specifies IRQCHIP_SKIP_SET_WAKE. Otherwise, IRQ wakeup
configuration can't be propagated properly through IRQ
domains hierarchy.

In case of TI OMAP DRA7 the issue reproduced with following
configuration:
ARM GIC<-OMAP wakeupgen<-TI CBAR<-GPIO<-GPIO pcf857x<-gpio_key

gpio_key is wakeup source

Failure is reproduced during suspend/resume to RAM:
suspend:
 - gpio_keys_suspend
   enable_irq_wake
     + pcf857x_irq_set_wake
       + omap_gpio_wake_enable
         + TI CBAR irq_chip_set_wake_parent
           + OMAP wakeupgen has no .irq_set_wake()
           and -ENOSYS will be returned

resume:
 - gpio_keys_resume
   + disable_irq_wake
     + irq_set_irq_wake
       + WARN(1, "Unbalanced IRQ %d wake disable\n", irq);

Fixes: 08b55e2a9208 ('genirq: Add irqchip_set_wake_parent')
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 kernel/irq/chip.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 6de638b..bdb1b9d 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -1024,6 +1024,10 @@ int irq_chip_set_vcpu_affinity_parent(struct irq_data *data, void *vcpu_info)
 int irq_chip_set_wake_parent(struct irq_data *data, unsigned int on)
 {
 	data = data->parent_data;
+
+	if (irq_data_get_irq_chip(data)->flags & IRQCHIP_SKIP_SET_WAKE)
+		return 0;
+
 	if (data->chip->irq_set_wake)
 		return data->chip->irq_set_wake(data, on);
 
-- 
2.5.0


WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: tglx@linutronix.de, tony@atomide.com, marc.zyngier@arm.com
Cc: linux@arm.linux.org.uk, nsekhar@ti.com, jason@lakedaemon.net,
	balbi@ti.com, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Grygorii Strashko <grygorii.strashko@ti.com>
Subject: [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE
Date: Wed, 12 Aug 2015 20:45:58 +0300	[thread overview]
Message-ID: <1439401562-28874-3-git-send-email-grygorii.strashko@ti.com> (raw)
In-Reply-To: <1439401562-28874-1-git-send-email-grygorii.strashko@ti.com>

The irqchip_set_wake_parent should not fail if IRQ chip
specifies IRQCHIP_SKIP_SET_WAKE. Otherwise, IRQ wakeup
configuration can't be propagated properly through IRQ
domains hierarchy.

In case of TI OMAP DRA7 the issue reproduced with following
configuration:
ARM GIC<-OMAP wakeupgen<-TI CBAR<-GPIO<-GPIO pcf857x<-gpio_key

gpio_key is wakeup source

Failure is reproduced during suspend/resume to RAM:
suspend:
 - gpio_keys_suspend
   enable_irq_wake
     + pcf857x_irq_set_wake
       + omap_gpio_wake_enable
         + TI CBAR irq_chip_set_wake_parent
           + OMAP wakeupgen has no .irq_set_wake()
           and -ENOSYS will be returned

resume:
 - gpio_keys_resume
   + disable_irq_wake
     + irq_set_irq_wake
       + WARN(1, "Unbalanced IRQ %d wake disable\n", irq);

Fixes: 08b55e2a9208 ('genirq: Add irqchip_set_wake_parent')
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 kernel/irq/chip.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 6de638b..bdb1b9d 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -1024,6 +1024,10 @@ int irq_chip_set_vcpu_affinity_parent(struct irq_data *data, void *vcpu_info)
 int irq_chip_set_wake_parent(struct irq_data *data, unsigned int on)
 {
 	data = data->parent_data;
+
+	if (irq_data_get_irq_chip(data)->flags & IRQCHIP_SKIP_SET_WAKE)
+		return 0;
+
 	if (data->chip->irq_set_wake)
 		return data->chip->irq_set_wake(data, on);
 
-- 
2.5.0

WARNING: multiple messages have this Message-ID (diff)
From: grygorii.strashko@ti.com (Grygorii Strashko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE
Date: Wed, 12 Aug 2015 20:45:58 +0300	[thread overview]
Message-ID: <1439401562-28874-3-git-send-email-grygorii.strashko@ti.com> (raw)
In-Reply-To: <1439401562-28874-1-git-send-email-grygorii.strashko@ti.com>

The irqchip_set_wake_parent should not fail if IRQ chip
specifies IRQCHIP_SKIP_SET_WAKE. Otherwise, IRQ wakeup
configuration can't be propagated properly through IRQ
domains hierarchy.

In case of TI OMAP DRA7 the issue reproduced with following
configuration:
ARM GIC<-OMAP wakeupgen<-TI CBAR<-GPIO<-GPIO pcf857x<-gpio_key

gpio_key is wakeup source

Failure is reproduced during suspend/resume to RAM:
suspend:
 - gpio_keys_suspend
   enable_irq_wake
     + pcf857x_irq_set_wake
       + omap_gpio_wake_enable
         + TI CBAR irq_chip_set_wake_parent
           + OMAP wakeupgen has no .irq_set_wake()
           and -ENOSYS will be returned

resume:
 - gpio_keys_resume
   + disable_irq_wake
     + irq_set_irq_wake
       + WARN(1, "Unbalanced IRQ %d wake disable\n", irq);

Fixes: 08b55e2a9208 ('genirq: Add irqchip_set_wake_parent')
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 kernel/irq/chip.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 6de638b..bdb1b9d 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -1024,6 +1024,10 @@ int irq_chip_set_vcpu_affinity_parent(struct irq_data *data, void *vcpu_info)
 int irq_chip_set_wake_parent(struct irq_data *data, unsigned int on)
 {
 	data = data->parent_data;
+
+	if (irq_data_get_irq_chip(data)->flags & IRQCHIP_SKIP_SET_WAKE)
+		return 0;
+
 	if (data->chip->irq_set_wake)
 		return data->chip->irq_set_wake(data, on);
 
-- 
2.5.0

  parent reply	other threads:[~2015-08-12 17:47 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-12 17:45 [PATCH v2 0/6] genirq: irqdomain_hierarchy: fixes Grygorii Strashko
2015-08-12 17:45 ` Grygorii Strashko
2015-08-12 17:45 ` Grygorii Strashko
2015-08-12 17:45 ` [PATCH v2 1/6] genirq: fix irq_chip_retrigger_hierarchy Grygorii Strashko
2015-08-12 17:45   ` Grygorii Strashko
2015-08-12 17:45   ` Grygorii Strashko
2015-08-13  9:26   ` Marc Zyngier
2015-08-13  9:26     ` Marc Zyngier
2015-08-13  9:26     ` Marc Zyngier
2015-08-12 17:45 ` Grygorii Strashko [this message]
2015-08-12 17:45   ` [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE Grygorii Strashko
2015-08-12 17:45   ` Grygorii Strashko
2015-08-13  8:54   ` Sudeep Holla
2015-08-13  8:54     ` Sudeep Holla
2015-08-13  8:54     ` Sudeep Holla
2015-08-13  9:51     ` Grygorii Strashko
2015-08-13  9:51       ` Grygorii Strashko
2015-08-13  9:51       ` Grygorii Strashko
2015-08-13 10:33       ` Sudeep Holla
2015-08-13 10:33         ` Sudeep Holla
2015-08-13 10:33         ` Sudeep Holla
2015-08-13 10:01   ` Marc Zyngier
2015-08-13 10:01     ` Marc Zyngier
2015-08-13 10:01     ` Marc Zyngier
2015-08-13 10:31     ` Grygorii Strashko
2015-08-13 10:31       ` Grygorii Strashko
2015-08-13 10:31       ` Grygorii Strashko
2015-08-13 12:58       ` Grygorii Strashko
2015-08-13 12:58         ` Grygorii Strashko
2015-08-13 12:58         ` Grygorii Strashko
2015-08-14 10:18         ` Grygorii Strashko
2015-08-14 10:18           ` Grygorii Strashko
2015-08-14 10:18           ` Grygorii Strashko
2015-08-14 10:39           ` Marc Zyngier
2015-08-14 10:39             ` Marc Zyngier
2015-08-14 10:39             ` Marc Zyngier
2015-08-12 17:45 ` [PATCH v2 3/6] genirq: introduce irq_chip_set_type_parent() helper Grygorii Strashko
2015-08-12 17:45   ` Grygorii Strashko
2015-08-12 17:45   ` Grygorii Strashko
2015-08-13  8:58   ` Sudeep Holla
2015-08-13  8:58     ` Sudeep Holla
2015-08-13  8:58     ` Sudeep Holla
2015-08-13  9:54     ` Grygorii Strashko
2015-08-13  9:54       ` Grygorii Strashko
2015-08-13  9:54       ` Grygorii Strashko
2015-08-12 17:46 ` [PATCH v2 4/6] irqchip: crossbar: fix arm gic irq type configuration Grygorii Strashko
2015-08-12 17:46   ` Grygorii Strashko
2015-08-12 17:46   ` Grygorii Strashko
2015-08-12 17:46 ` [PATCH v2 5/6] ARM: OMAP: wakeupgen: " Grygorii Strashko
2015-08-12 17:46   ` Grygorii Strashko
2015-08-12 17:46   ` Grygorii Strashko
2015-08-13  9:50   ` Tony Lindgren
2015-08-13  9:50     ` Tony Lindgren
2015-08-12 17:46 ` [PATCH v2 6/6] irqchip: crossbar: fix irq masking at suspend Grygorii Strashko
2015-08-12 17:46   ` Grygorii Strashko
2015-08-12 17:46   ` Grygorii Strashko
2015-08-13  9:30   ` Sudeep Holla
2015-08-13  9:30     ` Sudeep Holla
2015-08-13  9:30     ` Sudeep Holla
2015-08-13 10:17     ` Grygorii Strashko
2015-08-13 10:17       ` Grygorii Strashko
2015-08-13 10:17       ` Grygorii Strashko
2015-08-13 11:04       ` Sudeep Holla
2015-08-13 11:04         ` Sudeep Holla
2015-08-13 11:04         ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439401562-28874-3-git-send-email-grygorii.strashko@ti.com \
    --to=grygorii.strashko@ti.com \
    --cc=balbi@ti.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=marc.zyngier@arm.com \
    --cc=nsekhar@ti.com \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.