All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org,
	Dan Williams <dan.j.williams@intel.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
	Jens Axboe <axboe@kernel.dk>
Subject: [PATCH v2 1/7] brd: make rd_size static
Date: Thu, 13 Aug 2015 10:51:05 -0600	[thread overview]
Message-ID: <1439484671-15718-2-git-send-email-ross.zwisler@linux.intel.com> (raw)
In-Reply-To: <1439484671-15718-1-git-send-email-ross.zwisler@linux.intel.com>

Make rd_size static because it is local to drivers/block/brd.c

This was reported by sparse:

drivers/block/brd.c:445:5: warning: symbol 'rd_size' was not declared.
Should it be static?

Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
---
 drivers/block/brd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/brd.c b/drivers/block/brd.c
index 64ab495..5750b39 100644
--- a/drivers/block/brd.c
+++ b/drivers/block/brd.c
@@ -442,7 +442,7 @@ static int rd_nr = CONFIG_BLK_DEV_RAM_COUNT;
 module_param(rd_nr, int, S_IRUGO);
 MODULE_PARM_DESC(rd_nr, "Maximum number of brd devices");
 
-int rd_size = CONFIG_BLK_DEV_RAM_SIZE;
+static int rd_size = CONFIG_BLK_DEV_RAM_SIZE;
 module_param(rd_size, int, S_IRUGO);
 MODULE_PARM_DESC(rd_size, "Size of each RAM disk in kbytes.");
 
-- 
2.1.0


WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: linux-kernel@vger.kernel.org, linux-nvdimm@ml01.01.org,
	Dan Williams <dan.j.williams@intel.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
	Jens Axboe <axboe@kernel.dk>
Subject: [PATCH v2 1/7] brd: make rd_size static
Date: Thu, 13 Aug 2015 10:51:05 -0600	[thread overview]
Message-ID: <1439484671-15718-2-git-send-email-ross.zwisler@linux.intel.com> (raw)
In-Reply-To: <1439484671-15718-1-git-send-email-ross.zwisler@linux.intel.com>

Make rd_size static because it is local to drivers/block/brd.c

This was reported by sparse:

drivers/block/brd.c:445:5: warning: symbol 'rd_size' was not declared.
Should it be static?

Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
---
 drivers/block/brd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/brd.c b/drivers/block/brd.c
index 64ab495..5750b39 100644
--- a/drivers/block/brd.c
+++ b/drivers/block/brd.c
@@ -442,7 +442,7 @@ static int rd_nr = CONFIG_BLK_DEV_RAM_COUNT;
 module_param(rd_nr, int, S_IRUGO);
 MODULE_PARM_DESC(rd_nr, "Maximum number of brd devices");
 
-int rd_size = CONFIG_BLK_DEV_RAM_SIZE;
+static int rd_size = CONFIG_BLK_DEV_RAM_SIZE;
 module_param(rd_size, int, S_IRUGO);
 MODULE_PARM_DESC(rd_size, "Size of each RAM disk in kbytes.");
 
-- 
2.1.0


  reply	other threads:[~2015-08-13 16:51 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-13 16:51 [PATCH v2 0/7] dax: I/O path enhancements Ross Zwisler
2015-08-13 16:51 ` Ross Zwisler
2015-08-13 16:51 ` Ross Zwisler
2015-08-13 16:51 ` Ross Zwisler [this message]
2015-08-13 16:51   ` [PATCH v2 1/7] brd: make rd_size static Ross Zwisler
2015-08-13 16:51 ` [PATCH v2 2/7] pmem, x86: move x86 PMEM API to new pmem.h header Ross Zwisler
2015-08-13 16:51   ` Ross Zwisler
2015-08-15  8:58   ` Christoph Hellwig
2015-08-15  8:58     ` Christoph Hellwig
2015-08-13 16:51 ` [PATCH v2 3/7] pmem: remove layer when calling arch_has_wmb_pmem() Ross Zwisler
2015-08-13 16:51   ` Ross Zwisler
2015-08-13 16:51 ` [PATCH v2 4/7] pmem, x86: clean up conditional pmem includes Ross Zwisler
2015-08-13 16:51   ` Ross Zwisler
2015-08-13 16:51 ` [PATCH v2 5/7] pmem: add wb_cache_pmem() and clear_pmem() Ross Zwisler
2015-08-13 16:51   ` Ross Zwisler
2015-08-13 16:51 ` [PATCH v2 6/7] dax: update I/O path to do proper PMEM flushing Ross Zwisler
2015-08-13 16:51   ` Ross Zwisler
2015-08-13 21:11   ` Dan Williams
2015-08-13 21:11     ` Dan Williams
2015-08-14 16:48     ` Ross Zwisler
2015-08-14 16:48       ` Ross Zwisler
2015-08-13 16:51 ` [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation Ross Zwisler
2015-08-13 16:51   ` Ross Zwisler
2015-08-13 16:51   ` Ross Zwisler
2015-08-13 21:20   ` Dan Williams
2015-08-13 21:20     ` Dan Williams
2015-08-13 21:20     ` Dan Williams
2015-08-14 16:55     ` Ross Zwisler
2015-08-14 16:55       ` Ross Zwisler
2015-08-14 16:55       ` Ross Zwisler
2015-08-14 16:58       ` Dan Williams
2015-08-14 16:58         ` Dan Williams
2015-08-14 16:58         ` Dan Williams
2015-08-15  9:11         ` Christoph Hellwig
2015-08-15  9:11           ` Christoph Hellwig
2015-08-15  9:11           ` Christoph Hellwig
2015-08-15 15:49           ` Dan Williams
2015-08-15 15:49             ` Dan Williams
2015-08-15 15:49             ` Dan Williams
2015-08-15  9:19   ` Christoph Hellwig
2015-08-15  9:19     ` Christoph Hellwig
2015-08-15  9:19     ` Christoph Hellwig
2015-08-15 15:44     ` Dan Williams
2015-08-15 15:44       ` Dan Williams
2015-08-15 15:44       ` Dan Williams
2015-08-15 16:00       ` Christoph Hellwig
2015-08-15 16:00         ` Christoph Hellwig
2015-08-15 16:00         ` Christoph Hellwig
2015-08-15 18:05         ` Dan Williams
2015-08-15 18:05           ` Dan Williams
2015-08-15 18:05           ` Dan Williams
2015-08-17 20:07       ` Ross Zwisler
2015-08-17 20:07         ` Ross Zwisler
2015-08-17 20:07         ` Ross Zwisler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439484671-15718-2-git-send-email-ross.zwisler@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=axboe@kernel.dk \
    --cc=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.