All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: <tglx@linutronix.de>, <tony@atomide.com>, <marc.zyngier@arm.com>
Cc: <linux@arm.linux.org.uk>, <nsekhar@ti.com>,
	<jason@lakedaemon.net>, <balbi@ti.com>,
	<linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Sudeep Holla <sudeep.holla@arm.com>
Subject: [PATCH v3 4/6] ARM: OMAP: wakeupgen: fix arm gic irq type configuration
Date: Fri, 14 Aug 2015 15:20:28 +0300	[thread overview]
Message-ID: <1439554830-19502-5-git-send-email-grygorii.strashko@ti.com> (raw)
In-Reply-To: <1439554830-19502-1-git-send-email-grygorii.strashko@ti.com>

It's observed that ARM GIC IRQ triggering type is not configured
properly when IRQ is routed through IRQ domain hierarchy and
system started using DT. As result, system will start using default
ARM GIC configuration, ignore DT IRQ triggering configuration,
and value of desc->irq_data.state_use_accessors = 0.

In case of TI OMAP DRA7 the following IRQ hierarchy is defined:
ARM GIC <- OMAP wakeupgen <- TI CBAR

Failed call chain:
     irq_create_of_mapping
     irq_set_irq_type
     __irq_set_trigger
     if (!chip || !chip->irq_set_type) {
        return 0; <- return here
     }
OMAP wakeupgen has no .irq_set_type() defined and, so, IRQ triggering
configuration will not be propagated to parent IRQ domain.

Hence, fix it by using irq_chip_set_type_parent() for
propagation IRQ triggering type to parent IRQ domains.

Cc: Sudeep Holla <sudeep.holla@arm.com>
Fixes: 7136d457f365 ('ARM: omap: convert wakeupgen to stacked domains')
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 arch/arm/mach-omap2/omap-wakeupgen.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-omap2/omap-wakeupgen.c b/arch/arm/mach-omap2/omap-wakeupgen.c
index 8e52621..e1d2e99 100644
--- a/arch/arm/mach-omap2/omap-wakeupgen.c
+++ b/arch/arm/mach-omap2/omap-wakeupgen.c
@@ -392,6 +392,7 @@ static struct irq_chip wakeupgen_chip = {
 	.irq_mask		= wakeupgen_mask,
 	.irq_unmask		= wakeupgen_unmask,
 	.irq_retrigger		= irq_chip_retrigger_hierarchy,
+	.irq_set_type		= irq_chip_set_type_parent,
 	.flags			= IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MASK_ON_SUSPEND,
 #ifdef CONFIG_SMP
 	.irq_set_affinity	= irq_chip_set_affinity_parent,
-- 
2.5.0


WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: tglx@linutronix.de, tony@atomide.com, marc.zyngier@arm.com
Cc: linux@arm.linux.org.uk, nsekhar@ti.com, jason@lakedaemon.net,
	balbi@ti.com, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Sudeep Holla <sudeep.holla@arm.com>
Subject: [PATCH v3 4/6] ARM: OMAP: wakeupgen: fix arm gic irq type configuration
Date: Fri, 14 Aug 2015 15:20:28 +0300	[thread overview]
Message-ID: <1439554830-19502-5-git-send-email-grygorii.strashko@ti.com> (raw)
In-Reply-To: <1439554830-19502-1-git-send-email-grygorii.strashko@ti.com>

It's observed that ARM GIC IRQ triggering type is not configured
properly when IRQ is routed through IRQ domain hierarchy and
system started using DT. As result, system will start using default
ARM GIC configuration, ignore DT IRQ triggering configuration,
and value of desc->irq_data.state_use_accessors = 0.

In case of TI OMAP DRA7 the following IRQ hierarchy is defined:
ARM GIC <- OMAP wakeupgen <- TI CBAR

Failed call chain:
     irq_create_of_mapping
     irq_set_irq_type
     __irq_set_trigger
     if (!chip || !chip->irq_set_type) {
        return 0; <- return here
     }
OMAP wakeupgen has no .irq_set_type() defined and, so, IRQ triggering
configuration will not be propagated to parent IRQ domain.

Hence, fix it by using irq_chip_set_type_parent() for
propagation IRQ triggering type to parent IRQ domains.

Cc: Sudeep Holla <sudeep.holla@arm.com>
Fixes: 7136d457f365 ('ARM: omap: convert wakeupgen to stacked domains')
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 arch/arm/mach-omap2/omap-wakeupgen.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-omap2/omap-wakeupgen.c b/arch/arm/mach-omap2/omap-wakeupgen.c
index 8e52621..e1d2e99 100644
--- a/arch/arm/mach-omap2/omap-wakeupgen.c
+++ b/arch/arm/mach-omap2/omap-wakeupgen.c
@@ -392,6 +392,7 @@ static struct irq_chip wakeupgen_chip = {
 	.irq_mask		= wakeupgen_mask,
 	.irq_unmask		= wakeupgen_unmask,
 	.irq_retrigger		= irq_chip_retrigger_hierarchy,
+	.irq_set_type		= irq_chip_set_type_parent,
 	.flags			= IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MASK_ON_SUSPEND,
 #ifdef CONFIG_SMP
 	.irq_set_affinity	= irq_chip_set_affinity_parent,
-- 
2.5.0

WARNING: multiple messages have this Message-ID (diff)
From: grygorii.strashko@ti.com (Grygorii Strashko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/6] ARM: OMAP: wakeupgen: fix arm gic irq type configuration
Date: Fri, 14 Aug 2015 15:20:28 +0300	[thread overview]
Message-ID: <1439554830-19502-5-git-send-email-grygorii.strashko@ti.com> (raw)
In-Reply-To: <1439554830-19502-1-git-send-email-grygorii.strashko@ti.com>

It's observed that ARM GIC IRQ triggering type is not configured
properly when IRQ is routed through IRQ domain hierarchy and
system started using DT. As result, system will start using default
ARM GIC configuration, ignore DT IRQ triggering configuration,
and value of desc->irq_data.state_use_accessors = 0.

In case of TI OMAP DRA7 the following IRQ hierarchy is defined:
ARM GIC <- OMAP wakeupgen <- TI CBAR

Failed call chain:
     irq_create_of_mapping
     irq_set_irq_type
     __irq_set_trigger
     if (!chip || !chip->irq_set_type) {
        return 0; <- return here
     }
OMAP wakeupgen has no .irq_set_type() defined and, so, IRQ triggering
configuration will not be propagated to parent IRQ domain.

Hence, fix it by using irq_chip_set_type_parent() for
propagation IRQ triggering type to parent IRQ domains.

Cc: Sudeep Holla <sudeep.holla@arm.com>
Fixes: 7136d457f365 ('ARM: omap: convert wakeupgen to stacked domains')
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 arch/arm/mach-omap2/omap-wakeupgen.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-omap2/omap-wakeupgen.c b/arch/arm/mach-omap2/omap-wakeupgen.c
index 8e52621..e1d2e99 100644
--- a/arch/arm/mach-omap2/omap-wakeupgen.c
+++ b/arch/arm/mach-omap2/omap-wakeupgen.c
@@ -392,6 +392,7 @@ static struct irq_chip wakeupgen_chip = {
 	.irq_mask		= wakeupgen_mask,
 	.irq_unmask		= wakeupgen_unmask,
 	.irq_retrigger		= irq_chip_retrigger_hierarchy,
+	.irq_set_type		= irq_chip_set_type_parent,
 	.flags			= IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MASK_ON_SUSPEND,
 #ifdef CONFIG_SMP
 	.irq_set_affinity	= irq_chip_set_affinity_parent,
-- 
2.5.0

  parent reply	other threads:[~2015-08-14 12:21 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-14 12:20 [PATCH v3 0/6] genirq: irqdomain_hierarchy: fixes Grygorii Strashko
2015-08-14 12:20 ` Grygorii Strashko
2015-08-14 12:20 ` Grygorii Strashko
2015-08-14 12:20 ` [PATCH v3 1/6] genirq: fix irq_chip_retrigger_hierarchy Grygorii Strashko
2015-08-14 12:20   ` Grygorii Strashko
2015-08-14 12:20   ` Grygorii Strashko
2015-08-17  3:28   ` Jiang Liu
2015-08-17  3:28     ` Jiang Liu
2015-08-19 23:21   ` [tip:irq/urgent] genirq: Don' t return ENOSYS in irq_chip_retrigger_hierarchy tip-bot for Grygorii Strashko
2015-08-14 12:20 ` [PATCH v3 2/6] genirq: introduce irq_chip_set_type_parent() helper Grygorii Strashko
2015-08-14 12:20   ` Grygorii Strashko
2015-08-14 12:20   ` Grygorii Strashko
2015-08-19 23:21   ` [tip:irq/urgent] genirq: Introduce " tip-bot for Grygorii Strashko
2015-08-14 12:20 ` [PATCH v3 3/6] irqchip: crossbar: fix arm gic irq type configuration Grygorii Strashko
2015-08-14 12:20   ` Grygorii Strashko
2015-08-14 12:20   ` Grygorii Strashko
2015-08-19 23:22   ` [tip:irq/urgent] irqchip/crossbar: Restore the irq_set_type() mechanism tip-bot for Grygorii Strashko
2015-08-14 12:20 ` Grygorii Strashko [this message]
2015-08-14 12:20   ` [PATCH v3 4/6] ARM: OMAP: wakeupgen: fix arm gic irq type configuration Grygorii Strashko
2015-08-14 12:20   ` Grygorii Strashko
2015-08-19 23:22   ` [tip:irq/urgent] ARM: OMAP: wakeupgen: Restore the irq_set_type() mechanism tip-bot for Grygorii Strashko
2015-08-14 12:20 ` [PATCH v3 5/6] irqchip: crossbar: fix irq masking at suspend Grygorii Strashko
2015-08-14 12:20   ` Grygorii Strashko
2015-08-14 12:20   ` Grygorii Strashko
2015-08-19 23:22   ` [tip:irq/urgent] irqchip/crossbar: Restore the mask on suspend behaviour tip-bot for Grygorii Strashko
2015-08-14 12:20 ` [PATCH v3 6/6] irqchip: crossbar: fix set_wake functionality Grygorii Strashko
2015-08-14 12:20   ` Grygorii Strashko
2015-08-14 12:20   ` Grygorii Strashko
2015-08-19 23:23   ` [tip:irq/urgent] irqchip/crossbar: Restore " tip-bot for Grygorii Strashko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439554830-19502-5-git-send-email-grygorii.strashko@ti.com \
    --to=grygorii.strashko@ti.com \
    --cc=balbi@ti.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=marc.zyngier@arm.com \
    --cc=nsekhar@ti.com \
    --cc=sudeep.holla@arm.com \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.