From: Christoph Hellwig <hch@lst.de>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 3/5] pnfs/blocklayout: reject too long signatures
Date: Mon, 17 Aug 2015 18:40:59 +0200 [thread overview]
Message-ID: <1439829661-1505-4-git-send-email-hch@lst.de> (raw)
In-Reply-To: <1439829661-1505-1-git-send-email-hch@lst.de>
Instead of overwriting kernel memory reject too long signatures.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/nfs/blocklayout/dev.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/fs/nfs/blocklayout/dev.c b/fs/nfs/blocklayout/dev.c
index e535599..d76993a 100644
--- a/fs/nfs/blocklayout/dev.c
+++ b/fs/nfs/blocklayout/dev.c
@@ -65,6 +65,11 @@ nfs4_block_decode_volume(struct xdr_stream *xdr, struct pnfs_block_volume *b)
return -EIO;
p = xdr_decode_hyper(p, &b->simple.sigs[i].offset);
b->simple.sigs[i].sig_len = be32_to_cpup(p++);
+ if (b->simple.sigs[i].sig_len > PNFS_BLOCK_UUID_LEN) {
+ pr_info("signature too long: %d\n",
+ b->simple.sigs[i].sig_len);
+ return -EIO;
+ }
p = xdr_inline_decode(xdr, b->simple.sigs[i].sig_len);
if (!p)
--
1.9.1
next prev parent reply other threads:[~2015-08-17 16:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 16:40 misc blocklayout updates Christoph Hellwig
2015-08-17 16:40 ` [PATCH 1/5] pnfs/blocklayout: calculate layoutupdate size correctly Christoph Hellwig
2015-08-17 16:40 ` [PATCH 2/5] pnfs/blocklayout: set up layoutupdate_pages properly Christoph Hellwig
2015-08-17 16:40 ` Christoph Hellwig [this message]
2015-08-17 16:41 ` [PATCH 4/5] pnfs/blocklayout: pass proper file mode to blkdev_get/put Christoph Hellwig
2015-08-17 16:41 ` [PATCH 5/5] pnfs: move common blocklayout XDR defintions to nfs4.h Christoph Hellwig
2015-08-21 7:04 ` misc blocklayout updates Christoph Hellwig
2015-08-21 7:11 ` Trond Myklebust
2015-08-21 7:15 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439829661-1505-4-git-send-email-hch@lst.de \
--to=hch@lst.de \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.