All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Hugh Dickins <hughd@google.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
	Dave Hansen <dave.hansen@intel.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.cz>,
	David Rientjes <rientjes@google.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: [PATCHv3 0/5] Fix compound_head() race
Date: Wed, 19 Aug 2015 12:21:41 +0300	[thread overview]
Message-ID: <1439976106-137226-1-git-send-email-kirill.shutemov@linux.intel.com> (raw)

Here's my attempt on fixing recently discovered race in compound_head().
It should make compound_head() reliable in all contexts.

The patchset is against Linus' tree. Let me know if it need to be rebased
onto different baseline.

It's expected to have conflicts with my page-flags patchset and probably
should be applied before it.

v3:
   - Fix build without hugetlb;
   - Drop page->first_page;
   - Update comment for free_compound_page();
   - Use 'unsigned int' for page order;

v2: Per Hugh's suggestion page->compound_head is moved into third double
    word. This way we can avoid memory overhead which v1 had in some
    cases.

    This place in struct page is rather overloaded. More testing is
    required to make sure we don't collide with anyone.

Kirill A. Shutemov (5):
  mm: drop page->slab_page
  zsmalloc: use page->private instead of page->first_page
  mm: pack compound_dtor and compound_order into one word in struct page
  mm: make compound_head() robust
  mm: use 'unsigned int' for page order

 Documentation/vm/split_page_table_lock |  4 +-
 arch/xtensa/configs/iss_defconfig      |  1 -
 include/linux/mm.h                     | 82 +++++++++++-----------------------
 include/linux/mm_types.h               | 21 ++++++---
 include/linux/page-flags.h             | 80 ++++++++-------------------------
 mm/Kconfig                             | 12 -----
 mm/debug.c                             |  5 ---
 mm/huge_memory.c                       |  3 +-
 mm/hugetlb.c                           | 35 +++++++--------
 mm/internal.h                          |  8 ++--
 mm/memory-failure.c                    |  7 ---
 mm/page_alloc.c                        | 76 ++++++++++++++++++-------------
 mm/swap.c                              |  4 +-
 mm/zsmalloc.c                          | 11 +++--
 14 files changed, 133 insertions(+), 216 deletions(-)

-- 
2.5.0


WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Hugh Dickins <hughd@google.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
	Dave Hansen <dave.hansen@intel.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.cz>,
	David Rientjes <rientjes@google.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: [PATCHv3 0/5] Fix compound_head() race
Date: Wed, 19 Aug 2015 12:21:41 +0300	[thread overview]
Message-ID: <1439976106-137226-1-git-send-email-kirill.shutemov@linux.intel.com> (raw)

Here's my attempt on fixing recently discovered race in compound_head().
It should make compound_head() reliable in all contexts.

The patchset is against Linus' tree. Let me know if it need to be rebased
onto different baseline.

It's expected to have conflicts with my page-flags patchset and probably
should be applied before it.

v3:
   - Fix build without hugetlb;
   - Drop page->first_page;
   - Update comment for free_compound_page();
   - Use 'unsigned int' for page order;

v2: Per Hugh's suggestion page->compound_head is moved into third double
    word. This way we can avoid memory overhead which v1 had in some
    cases.

    This place in struct page is rather overloaded. More testing is
    required to make sure we don't collide with anyone.

Kirill A. Shutemov (5):
  mm: drop page->slab_page
  zsmalloc: use page->private instead of page->first_page
  mm: pack compound_dtor and compound_order into one word in struct page
  mm: make compound_head() robust
  mm: use 'unsigned int' for page order

 Documentation/vm/split_page_table_lock |  4 +-
 arch/xtensa/configs/iss_defconfig      |  1 -
 include/linux/mm.h                     | 82 +++++++++++-----------------------
 include/linux/mm_types.h               | 21 ++++++---
 include/linux/page-flags.h             | 80 ++++++++-------------------------
 mm/Kconfig                             | 12 -----
 mm/debug.c                             |  5 ---
 mm/huge_memory.c                       |  3 +-
 mm/hugetlb.c                           | 35 +++++++--------
 mm/internal.h                          |  8 ++--
 mm/memory-failure.c                    |  7 ---
 mm/page_alloc.c                        | 76 ++++++++++++++++++-------------
 mm/swap.c                              |  4 +-
 mm/zsmalloc.c                          | 11 +++--
 14 files changed, 133 insertions(+), 216 deletions(-)

-- 
2.5.0

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2015-08-19  9:22 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-19  9:21 Kirill A. Shutemov [this message]
2015-08-19  9:21 ` [PATCHv3 0/5] Fix compound_head() race Kirill A. Shutemov
2015-08-19  9:21 ` [PATCHv3 1/5] mm: drop page->slab_page Kirill A. Shutemov
2015-08-19  9:21   ` Kirill A. Shutemov
2015-08-24 14:59   ` Vlastimil Babka
2015-08-24 14:59     ` Vlastimil Babka
2015-08-24 15:02   ` Vlastimil Babka
2015-08-24 15:02     ` Vlastimil Babka
2015-08-25 17:24     ` Kirill A. Shutemov
2015-08-25 17:24       ` Kirill A. Shutemov
2015-08-19  9:21 ` [PATCHv3 2/5] zsmalloc: use page->private instead of page->first_page Kirill A. Shutemov
2015-08-19  9:21   ` Kirill A. Shutemov
2015-08-24 15:04   ` Vlastimil Babka
2015-08-24 15:04     ` Vlastimil Babka
2015-08-19  9:21 ` [PATCHv3 3/5] mm: pack compound_dtor and compound_order into one word in struct page Kirill A. Shutemov
2015-08-19  9:21   ` Kirill A. Shutemov
2015-08-20 23:26   ` Andrew Morton
2015-08-20 23:26     ` Andrew Morton
2015-08-21  7:13     ` Michal Hocko
2015-08-21  7:13       ` Michal Hocko
2015-08-21 10:40       ` Kirill A. Shutemov
2015-08-21 10:40         ` Kirill A. Shutemov
2015-08-21 10:51         ` Michal Hocko
2015-08-21 10:51           ` Michal Hocko
2015-08-19  9:21 ` [PATCHv3 4/5] mm: make compound_head() robust Kirill A. Shutemov
2015-08-19  9:21   ` Kirill A. Shutemov
2015-08-20 23:36   ` Andrew Morton
2015-08-20 23:36     ` Andrew Morton
2015-08-21 12:10     ` Kirill A. Shutemov
2015-08-21 12:10       ` Kirill A. Shutemov
2015-08-21 16:11       ` Christoph Lameter
2015-08-21 16:11         ` Christoph Lameter
2015-08-21 19:31         ` Kirill A. Shutemov
2015-08-21 19:31           ` Kirill A. Shutemov
2015-08-21 19:34           ` Andrew Morton
2015-08-21 19:34             ` Andrew Morton
2015-08-21 21:15             ` Christoph Lameter
2015-08-21 21:15               ` Christoph Lameter
2015-08-24 15:49             ` Vlastimil Babka
2015-08-24 15:49               ` Vlastimil Babka
2015-08-25 11:44       ` Vlastimil Babka
2015-08-25 11:44         ` Vlastimil Babka
2015-08-25 18:33         ` Kirill A. Shutemov
2015-08-25 18:33           ` Kirill A. Shutemov
2015-08-25 20:11           ` Paul E. McKenney
2015-08-25 20:11             ` Paul E. McKenney
2015-08-25 20:46             ` Vlastimil Babka
2015-08-25 20:46               ` Vlastimil Babka
2015-08-25 21:19               ` Paul E. McKenney
2015-08-25 21:19                 ` Paul E. McKenney
2015-08-26 15:04                 ` Kirill A. Shutemov
2015-08-26 15:04                   ` Kirill A. Shutemov
2015-08-26 15:39                   ` Vlastimil Babka
2015-08-26 15:39                     ` Vlastimil Babka
2015-08-26 16:38                   ` Paul E. McKenney
2015-08-26 16:38                     ` Paul E. McKenney
2015-08-26 18:18                 ` Hugh Dickins
2015-08-26 18:18                   ` Hugh Dickins
2015-08-26 21:29                   ` Paul E. McKenney
2015-08-26 21:29                     ` Paul E. McKenney
2015-08-26 22:28                     ` Hugh Dickins
2015-08-26 22:28                       ` Hugh Dickins
2015-08-26 23:34                       ` Paul E. McKenney
2015-08-26 23:34                         ` Paul E. McKenney
2015-08-27 15:09                     ` Michal Hocko
2015-08-27 15:09                       ` Michal Hocko
2015-08-27 16:03                       ` Michal Hocko
2015-08-27 16:03                         ` Michal Hocko
2015-08-27 17:28                         ` Hugh Dickins
2015-08-27 17:28                           ` Hugh Dickins
2015-08-27 18:06                           ` Michal Hocko
2015-08-27 18:06                             ` Michal Hocko
2015-08-27 16:36                       ` Paul E. McKenney
2015-08-27 16:36                         ` Paul E. McKenney
2015-08-27 18:14                         ` Michal Hocko
2015-08-27 18:14                           ` Michal Hocko
2015-08-27 19:01                           ` Paul E. McKenney
2015-08-27 19:01                             ` Paul E. McKenney
2015-08-23 23:59   ` Jesper Dangaard Brouer
2015-08-23 23:59     ` Jesper Dangaard Brouer
2015-08-24  9:29     ` Kirill A. Shutemov
2015-08-24  9:29       ` Kirill A. Shutemov
2015-08-24 10:17   ` Kirill A. Shutemov
2015-08-24 10:17     ` Kirill A. Shutemov
2015-08-19  9:21 ` [PATCHv3 5/5] mm: use 'unsigned int' for page order Kirill A. Shutemov
2015-08-19  9:21   ` Kirill A. Shutemov
2015-08-20  8:32   ` Michal Hocko
2015-08-20  8:32     ` Michal Hocko
2015-08-20 12:31 ` [PATCHv3 0/5] Fix compound_head() race Kirill A. Shutemov
2015-08-20 12:31   ` Kirill A. Shutemov
2015-08-20 23:38   ` Andrew Morton
2015-08-20 23:38     ` Andrew Morton
2015-08-22 20:13     ` Hugh Dickins
2015-08-22 20:13       ` Hugh Dickins
2015-08-24  9:36       ` Kirill A. Shutemov
2015-08-24  9:36         ` Kirill A. Shutemov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439976106-137226-1-git-send-email-kirill.shutemov@linux.intel.com \
    --to=kirill.shutemov@linux.intel.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.