All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yaniv Gardi <ygardi@codeaurora.org>
To: robherring2@gmail.com, James.Bottomley@HansenPartnership.com,
	pebolle@tiscali.nl, hch@infradead.org
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, santoshsy@gmail.com,
	linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org,
	ygardi@codeaurora.org, gbroner@codeaurora.org,
	draviv@codeaurora.org, Vinayak Holikatti <vinholikatti@gmail.com>,
	"James E.J. Bottomley" <JBottomley@odin.com>
Subject: [PATCH v1 07/15] scsi: ufs: set REQUEST_SENSE command size to 18 bytes
Date: Sat, 22 Aug 2015 01:09:41 +0300	[thread overview]
Message-ID: <1440194989-28835-8-git-send-email-ygardi@codeaurora.org> (raw)
In-Reply-To: <1440194989-28835-1-git-send-email-ygardi@codeaurora.org>

According to UFS device specification REQUEST_SENSE command can
only report back up to 18 bytes of data.

Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>

---
 drivers/scsi/ufs/ufshcd.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index f248df2..d0269ad 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -42,6 +42,7 @@
 
 #include "ufshcd.h"
 #include "unipro.h"
+#define UFSHCD_REQ_SENSE_SIZE	18
 
 #define UFSHCD_ENABLE_INTRS	(UTP_TRANSFER_REQ_COMPL |\
 				 UTP_TASK_REQ_COMPL |\
@@ -836,7 +837,7 @@ static inline void ufshcd_copy_sense_data(struct ufshcd_lrb *lrbp)
 		len = be16_to_cpu(lrbp->ucd_rsp_ptr->sr.sense_data_len);
 		memcpy(lrbp->sense_buffer,
 			lrbp->ucd_rsp_ptr->sr.sense_data,
-			min_t(int, len, SCSI_SENSE_BUFFERSIZE));
+			min_t(int, len, UFSHCD_REQ_SENSE_SIZE));
 	}
 }
 
@@ -1381,7 +1382,7 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd)
 
 	WARN_ON(lrbp->cmd);
 	lrbp->cmd = cmd;
-	lrbp->sense_bufflen = SCSI_SENSE_BUFFERSIZE;
+	lrbp->sense_bufflen = UFSHCD_REQ_SENSE_SIZE;
 	lrbp->sense_buffer = cmd->sense_buffer;
 	lrbp->task_tag = tag;
 	lrbp->lun = ufshcd_scsi_to_upiu_lun(cmd->device->lun);
@@ -4817,19 +4818,19 @@ ufshcd_send_request_sense(struct ufs_hba *hba, struct scsi_device *sdp)
 				0,
 				0,
 				0,
-				SCSI_SENSE_BUFFERSIZE,
+				UFSHCD_REQ_SENSE_SIZE,
 				0};
 	char *buffer;
 	int ret;
 
-	buffer = kzalloc(SCSI_SENSE_BUFFERSIZE, GFP_KERNEL);
+	buffer = kzalloc(UFSHCD_REQ_SENSE_SIZE, GFP_KERNEL);
 	if (!buffer) {
 		ret = -ENOMEM;
 		goto out;
 	}
 
 	ret = scsi_execute_req_flags(sdp, cmd, DMA_FROM_DEVICE, buffer,
-				SCSI_SENSE_BUFFERSIZE, NULL,
+				UFSHCD_REQ_SENSE_SIZE, NULL,
 				msecs_to_jiffies(1000), 3, NULL, REQ_PM);
 	if (ret)
 		pr_err("%s: failed with err %d\n", __func__, ret);
-- 
1.8.5.2

-- 
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

  parent reply	other threads:[~2015-08-21 22:09 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-21 22:09 [PATCH v1 00/15] Big fixes, retries, handle a race condition Yaniv Gardi
2015-08-21 22:09 ` [PATCH v1 01/15] scsi: ufs: clear UTRD, UPIU req and rsp before new transfers Yaniv Gardi
2015-08-21 22:09 ` [PATCH v1 02/15] scsi: ufs: clear fields " Yaniv Gardi
2015-08-21 22:09 ` [PATCH v1 03/15] scsi: ufs: verify command tag validity Yaniv Gardi
2015-08-21 22:09 ` [PATCH v1 04/15] scsi: ufs: clear outstanding_request bit in case query timeout Yaniv Gardi
2015-08-21 22:09 ` [PATCH v1 05/15] scsi: ufs: increase fDeviceInit query response timeout Yaniv Gardi
2015-08-21 22:09 ` [PATCH v1 06/15] scsi: ufs: avoid exception event handler racing with PM callbacks Yaniv Gardi
2015-08-21 22:09 ` Yaniv Gardi [this message]
2015-08-21 22:09 ` [PATCH v1 08/15] scsi: ufs: add retries to dme_peer get and set attribute Yaniv Gardi
2015-08-21 22:09 ` [PATCH v1 09/15] scsi: ufs: add retries for hibern8 enter Yaniv Gardi
2015-08-21 22:09 ` [PATCH v1 10/15] scsi: ufs: fix error recovery after the hibern8 exit failure Yaniv Gardi
2015-08-21 22:09 ` [PATCH v1 11/15] scsi: ufs: retry failed query flag requests Yaniv Gardi
2015-08-21 22:09 ` [PATCH v1 12/15] scsi: ufs: reduce the interrupts for power mode change requests Yaniv Gardi
2015-08-21 22:09 ` [PATCH v1 13/15] scsi: ufs: add missing memory barriers Yaniv Gardi
2015-08-21 22:09 ` [PATCH v1 14/15] scsi: ufs: commit descriptors before setting the doorbell Yaniv Gardi
2015-08-23 21:10   ` Rob Herring
2015-08-25 12:36     ` ygardi
2015-08-25 18:25       ` Rob Herring
2015-08-27 12:11         ` ygardi
2015-08-27 17:19           ` Rob Herring
2015-08-30  9:50             ` ygardi
2015-08-27 12:28       ` ygardi
2015-08-27 12:28         ` ygardi
2015-08-27 17:02         ` Rob Herring
2015-08-21 22:09 ` [PATCH v1 15/15] scsi: ufs: add wrapper for retrying sending query attribute Yaniv Gardi
2015-08-23 21:07   ` Rob Herring
2015-08-25 12:45     ` ygardi
2015-08-25 13:22       ` ygardi
2015-08-25 13:22         ` ygardi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440194989-28835-8-git-send-email-ygardi@codeaurora.org \
    --to=ygardi@codeaurora.org \
    --cc=JBottomley@odin.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=draviv@codeaurora.org \
    --cc=gbroner@codeaurora.org \
    --cc=hch@infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi-owner@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    --cc=robherring2@gmail.com \
    --cc=santoshsy@gmail.com \
    --cc=subhashj@codeaurora.org \
    --cc=vinholikatti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.