All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: arm@kernel.org
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Russell King <linux@arm.linux.org.uk>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Wei Xu <xuwei5@hisilicon.com>
Subject: [PATCH 08/18] ARM: hisi: do not export smp_operations structures
Date: Mon, 24 Aug 2015 13:36:08 +0900	[thread overview]
Message-ID: <1440390978-22796-9-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1440390978-22796-1-git-send-email-yamada.masahiro@socionext.com>

These three structures are only defined and referenced in
mach-hisi/platsmp.c.

Drop the declarations from the header and add static qualifier
to the definitions.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/arm/mach-hisi/core.h    | 3 ---
 arch/arm/mach-hisi/platsmp.c | 6 +++---
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/arm/mach-hisi/core.h b/arch/arm/mach-hisi/core.h
index c7648ef..e883583 100644
--- a/arch/arm/mach-hisi/core.h
+++ b/arch/arm/mach-hisi/core.h
@@ -6,17 +6,14 @@
 extern void hi3xxx_set_cpu_jump(int cpu, void *jump_addr);
 extern int hi3xxx_get_cpu_jump(int cpu);
 extern void secondary_startup(void);
-extern struct smp_operations hi3xxx_smp_ops;
 
 extern void hi3xxx_cpu_die(unsigned int cpu);
 extern int hi3xxx_cpu_kill(unsigned int cpu);
 extern void hi3xxx_set_cpu(int cpu, bool enable);
 
-extern struct smp_operations hix5hd2_smp_ops;
 extern void hix5hd2_set_cpu(int cpu, bool enable);
 extern void hix5hd2_cpu_die(unsigned int cpu);
 
-extern struct smp_operations hip01_smp_ops;
 extern void hip01_set_cpu(int cpu, bool enable);
 extern void hip01_cpu_die(unsigned int cpu);
 #endif
diff --git a/arch/arm/mach-hisi/platsmp.c b/arch/arm/mach-hisi/platsmp.c
index 5174412..3c5237d 100644
--- a/arch/arm/mach-hisi/platsmp.c
+++ b/arch/arm/mach-hisi/platsmp.c
@@ -89,7 +89,7 @@ static int hi3xxx_boot_secondary(unsigned int cpu, struct task_struct *idle)
 	return 0;
 }
 
-struct smp_operations hi3xxx_smp_ops __initdata = {
+static struct smp_operations hi3xxx_smp_ops __initdata = {
 	.smp_prepare_cpus	= hi3xxx_smp_prepare_cpus,
 	.smp_boot_secondary	= hi3xxx_boot_secondary,
 #ifdef CONFIG_HOTPLUG_CPU
@@ -126,7 +126,7 @@ static int hix5hd2_boot_secondary(unsigned int cpu, struct task_struct *idle)
 }
 
 
-struct smp_operations hix5hd2_smp_ops __initdata = {
+static struct smp_operations hix5hd2_smp_ops __initdata = {
 	.smp_prepare_cpus	= hisi_common_smp_prepare_cpus,
 	.smp_boot_secondary	= hix5hd2_boot_secondary,
 #ifdef CONFIG_HOTPLUG_CPU
@@ -176,7 +176,7 @@ static int hip01_boot_secondary(unsigned int cpu, struct task_struct *idle)
 	return 0;
 }
 
-struct smp_operations hip01_smp_ops __initdata = {
+static struct smp_operations hip01_smp_ops __initdata = {
 	.smp_prepare_cpus       = hisi_common_smp_prepare_cpus,
 	.smp_boot_secondary     = hip01_boot_secondary,
 };
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: yamada.masahiro@socionext.com (Masahiro Yamada)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/18] ARM: hisi: do not export smp_operations structures
Date: Mon, 24 Aug 2015 13:36:08 +0900	[thread overview]
Message-ID: <1440390978-22796-9-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1440390978-22796-1-git-send-email-yamada.masahiro@socionext.com>

These three structures are only defined and referenced in
mach-hisi/platsmp.c.

Drop the declarations from the header and add static qualifier
to the definitions.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/arm/mach-hisi/core.h    | 3 ---
 arch/arm/mach-hisi/platsmp.c | 6 +++---
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/arm/mach-hisi/core.h b/arch/arm/mach-hisi/core.h
index c7648ef..e883583 100644
--- a/arch/arm/mach-hisi/core.h
+++ b/arch/arm/mach-hisi/core.h
@@ -6,17 +6,14 @@
 extern void hi3xxx_set_cpu_jump(int cpu, void *jump_addr);
 extern int hi3xxx_get_cpu_jump(int cpu);
 extern void secondary_startup(void);
-extern struct smp_operations hi3xxx_smp_ops;
 
 extern void hi3xxx_cpu_die(unsigned int cpu);
 extern int hi3xxx_cpu_kill(unsigned int cpu);
 extern void hi3xxx_set_cpu(int cpu, bool enable);
 
-extern struct smp_operations hix5hd2_smp_ops;
 extern void hix5hd2_set_cpu(int cpu, bool enable);
 extern void hix5hd2_cpu_die(unsigned int cpu);
 
-extern struct smp_operations hip01_smp_ops;
 extern void hip01_set_cpu(int cpu, bool enable);
 extern void hip01_cpu_die(unsigned int cpu);
 #endif
diff --git a/arch/arm/mach-hisi/platsmp.c b/arch/arm/mach-hisi/platsmp.c
index 5174412..3c5237d 100644
--- a/arch/arm/mach-hisi/platsmp.c
+++ b/arch/arm/mach-hisi/platsmp.c
@@ -89,7 +89,7 @@ static int hi3xxx_boot_secondary(unsigned int cpu, struct task_struct *idle)
 	return 0;
 }
 
-struct smp_operations hi3xxx_smp_ops __initdata = {
+static struct smp_operations hi3xxx_smp_ops __initdata = {
 	.smp_prepare_cpus	= hi3xxx_smp_prepare_cpus,
 	.smp_boot_secondary	= hi3xxx_boot_secondary,
 #ifdef CONFIG_HOTPLUG_CPU
@@ -126,7 +126,7 @@ static int hix5hd2_boot_secondary(unsigned int cpu, struct task_struct *idle)
 }
 
 
-struct smp_operations hix5hd2_smp_ops __initdata = {
+static struct smp_operations hix5hd2_smp_ops __initdata = {
 	.smp_prepare_cpus	= hisi_common_smp_prepare_cpus,
 	.smp_boot_secondary	= hix5hd2_boot_secondary,
 #ifdef CONFIG_HOTPLUG_CPU
@@ -176,7 +176,7 @@ static int hip01_boot_secondary(unsigned int cpu, struct task_struct *idle)
 	return 0;
 }
 
-struct smp_operations hip01_smp_ops __initdata = {
+static struct smp_operations hip01_smp_ops __initdata = {
 	.smp_prepare_cpus       = hisi_common_smp_prepare_cpus,
 	.smp_boot_secondary     = hip01_boot_secondary,
 };
-- 
1.9.1

  parent reply	other threads:[~2015-08-24  4:40 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-24  4:36 [PATCH 00/18] ARM: use const and __initconst for smp_operations Masahiro Yamada
2015-08-24  4:36 ` Masahiro Yamada
2015-08-24  4:36 ` Masahiro Yamada
2015-08-24  4:36 ` [PATCH 01/18] ARM: add const qualifier to the argument of smp_set_ops() Masahiro Yamada
2015-08-24  4:36   ` Masahiro Yamada
2015-08-24 20:33   ` Stephen Boyd
2015-08-24 20:33     ` Stephen Boyd
2015-08-24  4:36 ` [PATCH 02/18] ARM: add const qualifier to smp_operations member in structures Masahiro Yamada
2015-08-24  4:36   ` Masahiro Yamada
2015-08-24  4:36 ` [PATCH 03/18] ARM: alpine: use const and __initconst for smp_operations Masahiro Yamada
2015-08-24  4:36   ` Masahiro Yamada
2015-08-24  4:36 ` [PATCH 04/18] ARM: axxia: " Masahiro Yamada
2015-08-24  4:36   ` Masahiro Yamada
2015-08-24  4:36 ` [PATCH 05/18] ARM: BCM: " Masahiro Yamada
2015-08-24  4:36   ` Masahiro Yamada
2015-08-24 18:33   ` Florian Fainelli
2015-08-24 18:33     ` Florian Fainelli
2015-08-24 20:24     ` Ray Jui
2015-08-24 20:24       ` Ray Jui
2015-08-24  4:36 ` [PATCH 06/18] ARM: berlin: " Masahiro Yamada
2015-08-24  4:36   ` Masahiro Yamada
2015-08-24  4:36 ` [PATCH 07/18] ARM: EXYNOS: " Masahiro Yamada
2015-08-24  4:36   ` Masahiro Yamada
2015-08-24  4:36   ` Masahiro Yamada
2015-08-24  7:17   ` Krzysztof Kozlowski
2015-08-24  7:17     ` Krzysztof Kozlowski
2015-08-24  4:36 ` Masahiro Yamada [this message]
2015-08-24  4:36   ` [PATCH 08/18] ARM: hisi: do not export smp_operations structures Masahiro Yamada
2015-08-24  4:36 ` [PATCH 09/18] ARM: hisi: use const and __initconst for smp_operations Masahiro Yamada
2015-08-24  4:36   ` Masahiro Yamada
2015-08-24  4:36 ` [PATCH 10/18] ARM: mvebu: " Masahiro Yamada
2015-08-24  4:36   ` Masahiro Yamada
2015-08-24  4:36 ` [PATCH 11/18] ARM: qcom: " Masahiro Yamada
2015-08-24  4:36   ` Masahiro Yamada
2015-08-24 19:36   ` Andy Gross
2015-08-24 19:36     ` Andy Gross
2015-08-24  4:36 ` [PATCH 12/18] ARM: rockchip: " Masahiro Yamada
2015-08-24  4:36   ` Masahiro Yamada
2015-08-24  4:36   ` Masahiro Yamada
2015-08-24  4:36 ` [PATCH 13/18] ARM: socfpga: " Masahiro Yamada
2015-08-24  4:36   ` Masahiro Yamada
2015-08-24  4:36 ` [PATCH 14/18] ARM: sunxi: " Masahiro Yamada
2015-08-24  4:36   ` Masahiro Yamada
2015-08-24  6:22   ` Maxime Ripard
2015-08-24  6:22     ` Maxime Ripard
2015-08-24  4:36 ` [PATCH 15/18] ARM: uniphier: " Masahiro Yamada
2015-08-24  4:36   ` Masahiro Yamada
2015-08-24  4:36 ` [PATCH 16/18] ARM: zx: " Masahiro Yamada
2015-08-24  4:36   ` Masahiro Yamada
2015-08-24  4:36 ` [PATCH 17/18] ARM: zynq: " Masahiro Yamada
2015-08-24  4:36   ` Masahiro Yamada
2015-08-24 19:58   ` Moritz Fischer
2015-08-24 19:58     ` Moritz Fischer
2015-08-24  4:36 ` [PATCH 18/18] ARM: mcpm: " Masahiro Yamada
2015-08-24  4:36   ` Masahiro Yamada
2015-08-24 21:12 ` [PATCH 00/18] ARM: " Olof Johansson
2015-08-24 21:12   ` Olof Johansson
2015-08-24 21:12   ` Olof Johansson
2015-08-24 21:21   ` Russell King - ARM Linux
2015-08-24 21:21     ` Russell King - ARM Linux
2015-08-24 21:21     ` Russell King - ARM Linux
2015-08-24 21:44     ` Olof Johansson
2015-08-24 21:44       ` Olof Johansson
2015-08-24 21:44       ` Olof Johansson
2015-08-25  1:37       ` Masahiro Yamada
2015-08-25  1:37         ` Masahiro Yamada
2015-08-25  1:37         ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440390978-22796-9-git-send-email-yamada.masahiro@socionext.com \
    --to=yamada.masahiro@socionext.com \
    --cc=arm@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.