From: Shawn Lin <shawn.lin@rock-chips.com> To: Vinod Koul <vinod.koul@intel.com>, Heiko Stuebner <heiko@sntech.de> Cc: Doug Anderson <dianders@chromium.org>, Olof Johansson <olofj@google.com>, Sonny Rao <sonnyrao@chromium.org>, Addy Ke <addy.ke@rock-chips.com>, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Shawn Lin <shawn.lin@rock-chips.com>, Boojin Kim <boojin.kim@samsung.com> Subject: [PATCH 1/5] DMA: pl330: support burst mode for dev-to-mem and mem-to-dev transmit Date: Thu, 27 Aug 2015 16:48:33 +0800 [thread overview] Message-ID: <1440665313-31603-1-git-send-email-shawn.lin@rock-chips.com> (raw) In-Reply-To: <1440665280-31557-1-git-send-email-shawn.lin@rock-chips.com> This patch adds to support burst mode for dev-to-mem and mem-to-dev transmit. Signed-off-by: Boojin Kim <boojin.kim@samsung.com> Signed-off-by: Addy Ke <addy.ke@rock-chips.com> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> cc: Heiko Stuebner <heiko@sntech.de> cc: Doug Anderson <dianders@chromium.org> cc: Olof Johansson <olofj@google.com> Reviewed-and-tested-by: Sonny Rao <sonnyrao@chromium.org> --- drivers/dma/pl330.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index ecab4ea0..0d544d2 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -1141,10 +1141,13 @@ static inline int _ldst_devtomem(unsigned dry_run, u8 buf[], const struct _xfer_spec *pxs, int cyc) { int off = 0; + enum pl330_cond cond; + + cond = (pxs->desc->rqcfg.brst_len == 1) ? SINGLE : BURST; while (cyc--) { - off += _emit_WFP(dry_run, &buf[off], SINGLE, pxs->desc->peri); - off += _emit_LDP(dry_run, &buf[off], SINGLE, pxs->desc->peri); + off += _emit_WFP(dry_run, &buf[off], cond, pxs->desc->peri); + off += _emit_LDP(dry_run, &buf[off], cond, pxs->desc->peri); off += _emit_ST(dry_run, &buf[off], ALWAYS); off += _emit_FLUSHP(dry_run, &buf[off], pxs->desc->peri); } @@ -1156,11 +1159,14 @@ static inline int _ldst_memtodev(unsigned dry_run, u8 buf[], const struct _xfer_spec *pxs, int cyc) { int off = 0; + enum pl330_cond cond; + + cond = (pxs->desc->rqcfg.brst_len == 1) ? SINGLE : BURST; while (cyc--) { - off += _emit_WFP(dry_run, &buf[off], SINGLE, pxs->desc->peri); + off += _emit_WFP(dry_run, &buf[off], cond, pxs->desc->peri); off += _emit_LD(dry_run, &buf[off], ALWAYS); - off += _emit_STP(dry_run, &buf[off], SINGLE, pxs->desc->peri); + off += _emit_STP(dry_run, &buf[off], cond, pxs->desc->peri); off += _emit_FLUSHP(dry_run, &buf[off], pxs->desc->peri); } @@ -2557,7 +2563,7 @@ static struct dma_async_tx_descriptor *pl330_prep_dma_cyclic( desc->rqtype = direction; desc->rqcfg.brst_size = pch->burst_sz; - desc->rqcfg.brst_len = 1; + desc->rqcfg.brst_len = pch->burst_len; desc->bytes_requested = period_len; fill_px(&desc->px, dst, src, period_len); @@ -2702,7 +2708,7 @@ pl330_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl, } desc->rqcfg.brst_size = pch->burst_sz; - desc->rqcfg.brst_len = 1; + desc->rqcfg.brst_len = pch->burst_len; desc->rqtype = direction; desc->bytes_requested = sg_dma_len(sg); } -- 2.3.7
WARNING: multiple messages have this Message-ID (diff)
From: shawn.lin@rock-chips.com (Shawn Lin) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/5] DMA: pl330: support burst mode for dev-to-mem and mem-to-dev transmit Date: Thu, 27 Aug 2015 16:48:33 +0800 [thread overview] Message-ID: <1440665313-31603-1-git-send-email-shawn.lin@rock-chips.com> (raw) In-Reply-To: <1440665280-31557-1-git-send-email-shawn.lin@rock-chips.com> This patch adds to support burst mode for dev-to-mem and mem-to-dev transmit. Signed-off-by: Boojin Kim <boojin.kim@samsung.com> Signed-off-by: Addy Ke <addy.ke@rock-chips.com> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> cc: Heiko Stuebner <heiko@sntech.de> cc: Doug Anderson <dianders@chromium.org> cc: Olof Johansson <olofj@google.com> Reviewed-and-tested-by: Sonny Rao <sonnyrao@chromium.org> --- drivers/dma/pl330.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index ecab4ea0..0d544d2 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -1141,10 +1141,13 @@ static inline int _ldst_devtomem(unsigned dry_run, u8 buf[], const struct _xfer_spec *pxs, int cyc) { int off = 0; + enum pl330_cond cond; + + cond = (pxs->desc->rqcfg.brst_len == 1) ? SINGLE : BURST; while (cyc--) { - off += _emit_WFP(dry_run, &buf[off], SINGLE, pxs->desc->peri); - off += _emit_LDP(dry_run, &buf[off], SINGLE, pxs->desc->peri); + off += _emit_WFP(dry_run, &buf[off], cond, pxs->desc->peri); + off += _emit_LDP(dry_run, &buf[off], cond, pxs->desc->peri); off += _emit_ST(dry_run, &buf[off], ALWAYS); off += _emit_FLUSHP(dry_run, &buf[off], pxs->desc->peri); } @@ -1156,11 +1159,14 @@ static inline int _ldst_memtodev(unsigned dry_run, u8 buf[], const struct _xfer_spec *pxs, int cyc) { int off = 0; + enum pl330_cond cond; + + cond = (pxs->desc->rqcfg.brst_len == 1) ? SINGLE : BURST; while (cyc--) { - off += _emit_WFP(dry_run, &buf[off], SINGLE, pxs->desc->peri); + off += _emit_WFP(dry_run, &buf[off], cond, pxs->desc->peri); off += _emit_LD(dry_run, &buf[off], ALWAYS); - off += _emit_STP(dry_run, &buf[off], SINGLE, pxs->desc->peri); + off += _emit_STP(dry_run, &buf[off], cond, pxs->desc->peri); off += _emit_FLUSHP(dry_run, &buf[off], pxs->desc->peri); } @@ -2557,7 +2563,7 @@ static struct dma_async_tx_descriptor *pl330_prep_dma_cyclic( desc->rqtype = direction; desc->rqcfg.brst_size = pch->burst_sz; - desc->rqcfg.brst_len = 1; + desc->rqcfg.brst_len = pch->burst_len; desc->bytes_requested = period_len; fill_px(&desc->px, dst, src, period_len); @@ -2702,7 +2708,7 @@ pl330_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl, } desc->rqcfg.brst_size = pch->burst_sz; - desc->rqcfg.brst_len = 1; + desc->rqcfg.brst_len = pch->burst_len; desc->rqtype = direction; desc->bytes_requested = sg_dma_len(sg); } -- 2.3.7
next prev parent reply other threads:[~2015-08-27 8:49 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-08-27 8:48 [PATCH 0/5] Fix broken DMAFLUSHP on Rockchips platform Shawn Lin 2015-08-27 8:48 ` Shawn Lin 2015-08-27 8:48 ` Shawn Lin [this message] 2015-08-27 8:48 ` [PATCH 1/5] DMA: pl330: support burst mode for dev-to-mem and mem-to-dev transmit Shawn Lin 2015-08-27 8:57 ` Heiko Stuebner 2015-08-27 8:57 ` Heiko Stuebner 2015-08-27 11:05 ` Shawn Lin 2015-08-27 11:05 ` Shawn Lin 2015-08-27 11:05 ` Shawn Lin 2015-08-27 12:57 ` Krzysztof Kozlowski 2015-08-27 12:57 ` Krzysztof Kozlowski 2015-08-27 12:57 ` Krzysztof Kozlowski 2015-08-27 13:28 ` Shawn Lin 2015-08-27 13:28 ` Shawn Lin 2015-08-28 18:19 ` Sonny Rao 2015-08-28 18:19 ` Sonny Rao 2015-08-28 18:19 ` Sonny Rao 2015-08-28 23:40 ` Shawn Lin 2015-08-28 23:40 ` Shawn Lin 2015-08-28 23:40 ` Shawn Lin 2015-08-27 8:48 ` [PATCH 2/5] DMA: pl330: add quirk for broken no flushp Shawn Lin 2015-08-27 8:48 ` Shawn Lin 2015-08-27 8:48 ` [PATCH 3/5] ARM: dts: Add broken-no-flushp quirk for rk3288 platform Shawn Lin 2015-08-27 8:48 ` Shawn Lin 2015-08-27 8:49 ` [PATCH 4/5] ARM: dts: Add broken-no-flushp quirk for rk3xxx platform Shawn Lin 2015-08-27 8:49 ` Shawn Lin 2015-08-27 8:49 ` Shawn Lin 2015-08-27 8:49 ` [PATCH 5/5] Documentation: arm-pl330: add description of broken-no-flushp Shawn Lin 2015-08-27 8:49 ` Shawn Lin 2015-08-27 12:59 ` Krzysztof Kozlowski 2015-08-27 12:59 ` Krzysztof Kozlowski 2015-08-27 13:17 ` Shawn Lin 2015-08-27 13:17 ` Shawn Lin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1440665313-31603-1-git-send-email-shawn.lin@rock-chips.com \ --to=shawn.lin@rock-chips.com \ --cc=addy.ke@rock-chips.com \ --cc=boojin.kim@samsung.com \ --cc=dianders@chromium.org \ --cc=dmaengine@vger.kernel.org \ --cc=heiko@sntech.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=olofj@google.com \ --cc=sonnyrao@chromium.org \ --cc=vinod.koul@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.