All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruenba@redhat.com>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-nfs@vger.kernel.org, linux-api@vger.kernel.org,
	linux-cifs@vger.kernel.org,
	linux-security-module@vger.kernel.org
Subject: [RFC v7 34/41] ext4: Don't allow unmapped identifiers in richacls
Date: Sat,  5 Sep 2015 12:27:29 +0200	[thread overview]
Message-ID: <1441448856-13478-35-git-send-email-agruenba@redhat.com> (raw)
In-Reply-To: <1441448856-13478-1-git-send-email-agruenba@redhat.com>

Don't allow acls which contain unmapped identifiers: they are meaningful
for remote file systems only.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
 fs/ext4/richacl.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/fs/ext4/richacl.c b/fs/ext4/richacl.c
index 6758def..ca6e0cb 100644
--- a/fs/ext4/richacl.c
+++ b/fs/ext4/richacl.c
@@ -68,8 +68,13 @@ ext4_set_richacl(handle_t *handle, struct inode *inode, struct richacl *acl)
 	int retval;
 
 	if (acl) {
-		mode_t mode = inode->i_mode;
+		mode_t mode;
 
+		/* Don't allow acls with unmapped identifiers. */
+		if (richacl_has_unmapped_identifiers(acl))
+			return -EINVAL;
+
+		mode = inode->i_mode;
 		if (richacl_equiv_mode(acl, &mode) == 0) {
 			inode->i_mode = mode;
 			ext4_mark_inode_dirty(handle, inode);
-- 
2.4.3

  parent reply	other threads:[~2015-09-05 10:27 UTC|newest]

Thread overview: 188+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-05 10:26 [RFC v7 00/41] Richacls Andreas Gruenbacher
2015-09-05 10:26 ` Andreas Gruenbacher
2015-09-05 10:26 ` [RFC v7 04/41] vfs: Make the inode passed to inode_change_ok non-const Andreas Gruenbacher
2015-09-05 10:27 ` [RFC v7 05/41] vfs: Add permission flags for setting file attributes Andreas Gruenbacher
2015-09-05 10:27 ` [RFC v7 06/41] richacl: In-memory representation and helper functions Andreas Gruenbacher
2015-09-05 10:27 ` [RFC v7 07/41] richacl: Permission mapping functions Andreas Gruenbacher
     [not found] ` <1441448856-13478-1-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-05 10:26   ` [RFC v7 01/41] vfs: Add IS_ACL() and IS_RICHACL() tests Andreas Gruenbacher
2015-09-05 10:26     ` Andreas Gruenbacher
2015-09-05 10:26   ` [RFC v7 02/41] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags Andreas Gruenbacher
2015-09-05 10:26     ` Andreas Gruenbacher
2015-09-05 10:26   ` [RFC v7 03/41] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD " Andreas Gruenbacher
2015-09-05 10:26     ` Andreas Gruenbacher
2015-09-06  8:14     ` [PATCH] " Andreas Gruenbacher
     [not found]       ` <1441527246-18189-1-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-11 20:30         ` J. Bruce Fields
2015-09-11 20:30           ` J. Bruce Fields
2015-09-05 10:27   ` [RFC v7 08/41] richacl: Compute maximum file masks from an acl Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
2015-09-05 10:27   ` [RFC v7 09/41] richacl: Update the file masks in chmod() Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
     [not found]     ` <1441448856-13478-10-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-11 20:35       ` J. Bruce Fields
2015-09-11 20:35         ` J. Bruce Fields
2015-09-05 10:27   ` [RFC v7 10/41] richacl: Permission check algorithm Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
     [not found]     ` <1441448856-13478-11-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-11 21:16       ` J. Bruce Fields
2015-09-11 21:16         ` J. Bruce Fields
     [not found]         ` <20150911211617.GF11677-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-11 22:12           ` Andreas Grünbacher
2015-09-11 22:12             ` Andreas Grünbacher
2015-09-17 17:30             ` J. Bruce Fields
2015-09-05 10:27   ` [RFC v7 11/41] vfs: Cache base_acl objects in inodes Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
2015-09-05 10:27   ` [RFC v7 13/41] richacl: Check if an acl is equivalent to a file mode Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
2015-09-17 18:22     ` J. Bruce Fields
     [not found]       ` <20150917182219.GB13825-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-18  0:56         ` J. Bruce Fields
2015-09-18  0:56           ` J. Bruce Fields
     [not found]           ` <20150918005607.GB16699-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-21 13:59             ` Austin S Hemmelgarn
2015-09-21 13:59               ` Austin S Hemmelgarn
     [not found]               ` <56000D2B.6000705-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-21 14:38                 ` J. Bruce Fields
2015-09-21 14:38                   ` J. Bruce Fields
     [not found]                   ` <20150921143817.GA11256-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-21 17:00                     ` Austin S Hemmelgarn
2015-09-21 17:00                       ` Austin S Hemmelgarn
2015-09-21 17:48                       ` J. Bruce Fields
2015-09-21 15:31                 ` J. Bruce Fields
2015-09-21 15:31                   ` J. Bruce Fields
2015-09-21 23:26             ` Andreas Gruenbacher
2015-09-21 23:26               ` Andreas Gruenbacher
2015-09-21 23:20       ` Andreas Gruenbacher
2015-09-17 18:37     ` J. Bruce Fields
2015-09-05 10:27   ` [RFC v7 14/41] richacl: Create-time inheritance Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
     [not found]     ` <1441448856-13478-15-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-18 17:58       ` J. Bruce Fields
2015-09-18 17:58         ` J. Bruce Fields
     [not found]         ` <20150918175840.GA21506-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-21 20:37           ` Andreas Gruenbacher
2015-09-21 20:37             ` Andreas Gruenbacher
2015-09-05 10:27   ` [RFC v7 17/41] vfs: Add richacl permission checking Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
2015-09-05 10:27   ` [RFC v7 19/41] ext4: Add richacl feature flag Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
2015-09-23  2:31     ` Aneesh Kumar K.V
2015-09-05 10:27   ` [RFC v7 20/41] richacl: acl editing helper functions Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
     [not found]     ` <1441448856-13478-21-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-18 18:54       ` J. Bruce Fields
2015-09-18 18:54         ` J. Bruce Fields
2015-09-05 10:27   ` [RFC v7 22/41] richacl: Propagate everyone@ permissions to other aces Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
     [not found]     ` <1441448856-13478-23-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-18 21:36       ` J. Bruce Fields
2015-09-18 21:36         ` J. Bruce Fields
     [not found]         ` <20150918213611.GC22671-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-21 23:44           ` Andreas Gruenbacher
2015-09-21 23:44             ` Andreas Gruenbacher
2015-09-18 21:56       ` J. Bruce Fields
2015-09-18 21:56         ` J. Bruce Fields
     [not found]         ` <20150918215611.GD22671-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-21 19:24           ` J. Bruce Fields
2015-09-21 19:24             ` J. Bruce Fields
     [not found]             ` <20150921192441.GA12968-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-23  1:24               ` Andreas Gruenbacher
2015-09-23  1:24                 ` Andreas Gruenbacher
     [not found]             ` <CAHc6FU5Ug3rN2-znFeABpdn+LCHgvzOnSRB4BCepNS6mToJVZg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-23  1:39               ` Andreas Gruenbacher
2015-09-23  1:39                 ` Andreas Gruenbacher
     [not found]                 ` <1442972384-22757-1-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-23  1:46                   ` J. Bruce Fields
2015-09-23  1:46                     ` J. Bruce Fields
2015-09-05 10:27   ` [RFC v7 24/41] richacl: Set the other permissions to the other mask Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
2015-09-23 14:03     ` J. Bruce Fields
     [not found]       ` <20150923140307.GB27083-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-23 14:12         ` Andreas Grünbacher
2015-09-23 14:12           ` Andreas Grünbacher
2015-09-05 10:27   ` [RFC v7 25/41] richacl: Isolate the owner and group classes Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
     [not found]     ` <1441448856-13478-26-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-22 16:06       ` J. Bruce Fields
2015-09-22 16:06         ` J. Bruce Fields
     [not found]         ` <20150922160637.GC15838-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-23 13:11           ` Andreas Gruenbacher
2015-09-23 13:11             ` Andreas Gruenbacher
     [not found]             ` <CAHc6FU6gnPK5vdJynv0ze=mNju6V_1WuR99oXWC4Fdh2GFMVgA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-23 13:15               ` J. Bruce Fields
2015-09-23 13:15                 ` J. Bruce Fields
2015-09-22 19:02     ` J. Bruce Fields
     [not found]       ` <20150922190224.GA19127-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-23 13:33         ` Andreas Gruenbacher
2015-09-23 13:33           ` Andreas Gruenbacher
     [not found]           ` <CAHc6FU7_+fbyG0mEu3pUkfaV72AM0DzJnBES=b--koXJgo0a2g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-25 11:25             ` Andreas Gruenbacher
2015-09-25 11:25               ` Andreas Gruenbacher
     [not found]               ` <1443180341-22911-1-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-25 20:17                 ` J. Bruce Fields
2015-09-25 20:17                   ` J. Bruce Fields
2015-09-22 19:02     ` J. Bruce Fields
2015-09-05 10:27   ` [RFC v7 26/41] richacl: Apply the file masks to a richacl Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
2015-09-22 19:11     ` J. Bruce Fields
     [not found]       ` <20150922191108.GC19127-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-23 19:18         ` J. Bruce Fields
2015-09-23 19:18           ` J. Bruce Fields
     [not found]           ` <20150923191832.GA29577-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-23 20:29             ` Andreas Gruenbacher
2015-09-23 20:29               ` Andreas Gruenbacher
     [not found]               ` <CAHc6FU4YkLJUAQEfH7CG8sAzXYbGzg_ibyT7m26Fc1p26v1=VQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-23 20:33                 ` J. Bruce Fields
2015-09-23 20:33                   ` J. Bruce Fields
     [not found]                   ` <20150923203357.GC30521-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-23 20:40                     ` Andreas Gruenbacher
2015-09-23 20:40                       ` Andreas Gruenbacher
2015-09-23 21:05                       ` J. Bruce Fields
     [not found]                         ` <20150923210531.GC29349-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-23 22:14                           ` Andreas Gruenbacher
2015-09-23 22:14                             ` Andreas Gruenbacher
2015-09-24 15:28                             ` J. Bruce Fields
     [not found]                               ` <20150924152851.GC3823-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-24 15:48                                 ` Andreas Gruenbacher
2015-09-24 15:48                                   ` Andreas Gruenbacher
     [not found]     ` <1441448856-13478-27-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-22 20:50       ` J. Bruce Fields
2015-09-22 20:50         ` J. Bruce Fields
2015-09-24 18:33       ` J. Bruce Fields
2015-09-24 18:33         ` J. Bruce Fields
     [not found]         ` <20150924183310.GE3823-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-25 16:21           ` [PATCH] richacl: Possible other write-through fix Andreas Gruenbacher
2015-09-25 16:21             ` Andreas Gruenbacher
2015-09-25 16:21             ` Andreas Gruenbacher
2015-09-25 16:45           ` Andreas Gruenbacher
2015-09-25 16:45             ` Andreas Gruenbacher
2015-09-25 16:45             ` Andreas Gruenbacher
     [not found]             ` <1443199559-4870-1-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-25 18:36               ` J. Bruce Fields
2015-09-25 18:36                 ` J. Bruce Fields
2015-09-05 10:27   ` [RFC v7 27/41] richacl: Create richacl from mode values Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
     [not found]     ` <1441448856-13478-28-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-23 20:11       ` J. Bruce Fields
2015-09-23 20:11         ` J. Bruce Fields
2015-09-05 10:27   ` [RFC v7 28/41] nfsd: Keep list of acls to dispose of in compoundargs Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
     [not found]     ` <1441448856-13478-29-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-23 20:28       ` J. Bruce Fields
2015-09-23 20:28         ` J. Bruce Fields
2015-09-05 10:27   ` [RFC v7 29/41] nfsd: Use richacls as internal acl representation Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
     [not found]     ` <1441448856-13478-30-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-24 19:29       ` J. Bruce Fields
2015-09-24 19:29         ` J. Bruce Fields
2015-09-05 10:27   ` [RFC v7 30/41] nfsd: Add richacl support Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
2015-09-24 19:38     ` J. Bruce Fields
2015-09-05 10:27   ` [RFC v7 31/41] nfsd: Add support for the v4.1 dacl attribute Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
     [not found]     ` <1441448856-13478-32-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-24 19:59       ` J. Bruce Fields
2015-09-24 19:59         ` J. Bruce Fields
2015-09-25 16:37         ` Andreas Gruenbacher
2015-09-05 10:27   ` [RFC v7 32/41] nfsd: Add support for the MAY_CREATE_{FILE,DIR} permissions Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
     [not found]     ` <1441448856-13478-33-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-24 20:01       ` J. Bruce Fields
2015-09-24 20:01         ` J. Bruce Fields
2015-09-05 10:27   ` [RFC v7 33/41] richacl: Add support for unmapped identifiers Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
2015-09-05 10:27   ` [RFC v7 35/41] sunrpc: Allow to demand-allocate pages to encode into Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
2015-09-05 10:27   ` [RFC v7 36/41] sunrpc: Add xdr_init_encode_pages Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
2015-09-05 10:27   ` [RFC v7 38/41] nfs: Remove unused xdr page offsets in getacl/setacl arguments Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
2015-09-05 10:27   ` [RFC v7 39/41] nfs: Add richacl support Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
2015-09-05 10:27   ` [RFC v7 40/41] nfs: Add support for the v4.1 dacl attribute Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
2015-09-05 10:27   ` [RFC v7 41/41] richacl: uapi header split Andreas Gruenbacher
2015-09-05 10:27     ` Andreas Gruenbacher
2015-09-05 10:27 ` [RFC v7 12/41] vfs: Cache richacl in struct inode Andreas Gruenbacher
2015-09-05 10:27 ` [RFC v7 15/41] richacl: Automatic Inheritance Andreas Gruenbacher
2015-09-18 18:40   ` J. Bruce Fields
2015-09-21 21:19     ` Andreas Gruenbacher
2015-09-22  1:51       ` J. Bruce Fields
     [not found]         ` <20150922015146.GA15960-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-23 13:55           ` J. Bruce Fields
2015-09-23 13:55             ` J. Bruce Fields
2015-09-05 10:27 ` [RFC v7 16/41] richacl: xattr mapping functions Andreas Gruenbacher
2015-09-05 10:27 ` [RFC v7 18/41] ext4: Add richacl support Andreas Gruenbacher
     [not found]   ` <1441448856-13478-19-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-23  2:30     ` Aneesh Kumar K.V
2015-09-23  2:30       ` Aneesh Kumar K.V
2015-09-05 10:27 ` [RFC v7 21/41] richacl: Move everyone@ aces down the acl Andreas Gruenbacher
2015-09-18 19:35   ` J. Bruce Fields
     [not found]     ` <20150918193524.GA22671-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-09-21 21:43       ` Andreas Gruenbacher
2015-09-21 21:43         ` Andreas Gruenbacher
     [not found]         ` <CAHc6FU5m8KKSsEg18UhRSnVdsAzoFSD9pdLRv1DdDA==ZCQmdw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-22  1:52           ` J. Bruce Fields
2015-09-22  1:52             ` J. Bruce Fields
2015-09-05 10:27 ` [RFC v7 23/41] richacl: Set the owner permissions to the owner mask Andreas Gruenbacher
2015-09-21 21:00   ` J. Bruce Fields
2015-09-05 10:27 ` Andreas Gruenbacher [this message]
2015-09-05 10:27 ` [RFC v7 37/41] nfs: Fix GETATTR bitmap verification Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441448856-13478-35-git-send-email-agruenba@redhat.com \
    --to=agruenba@redhat.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.