All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
To: linux-mmc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	robh+dt@kernel.org, ulf.hansson@linaro.org,
	Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
Subject: [PATCH-v2 2/3] mmc: sdhci-pxav3: Use BIT macro for bit field definitions
Date: Mon,  7 Sep 2015 17:01:10 +0530	[thread overview]
Message-ID: <1441625471-16315-3-git-send-email-vaibhav.hiremath@linaro.org> (raw)
In-Reply-To: <1441625471-16315-1-git-send-email-vaibhav.hiremath@linaro.org>

Instead of using shift operation use BIT macro for bit field
definitions.

Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
---
 drivers/mmc/host/sdhci-pxav3.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
index 7a07177..a8a8c94 100644
--- a/drivers/mmc/host/sdhci-pxav3.c
+++ b/drivers/mmc/host/sdhci-pxav3.c
@@ -47,7 +47,7 @@
 #define  SDCLK_DELAY_MASK		0x1f
 
 #define SD_CFG_FIFO_PARAM		0x100
-#define  SDCFG_GEN_PAD_CLK_ON		(1<<6)
+#define  SDCFG_GEN_PAD_CLK_ON		BIT(6)
 #define  SDCFG_GEN_PAD_CLK_CNT_MASK	0xFF
 #define  SDCFG_GEN_PAD_CLK_CNT_SHIFT	24
 
@@ -55,8 +55,8 @@
 #define SD_CE_ATA_1			0x10C
 
 #define SD_CE_ATA_2			0x10E
-#define  SDCE_MISC_INT			(1<<2)
-#define  SDCE_MISC_INT_EN		(1<<1)
+#define  SDCE_MISC_INT			BIT(2)
+#define  SDCE_MISC_INT_EN		BIT(1)
 
 struct sdhci_pxa {
 	struct clk *clk_core;
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: vaibhav.hiremath@linaro.org (Vaibhav Hiremath)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH-v2 2/3] mmc: sdhci-pxav3: Use BIT macro for bit field definitions
Date: Mon,  7 Sep 2015 17:01:10 +0530	[thread overview]
Message-ID: <1441625471-16315-3-git-send-email-vaibhav.hiremath@linaro.org> (raw)
In-Reply-To: <1441625471-16315-1-git-send-email-vaibhav.hiremath@linaro.org>

Instead of using shift operation use BIT macro for bit field
definitions.

Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
---
 drivers/mmc/host/sdhci-pxav3.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
index 7a07177..a8a8c94 100644
--- a/drivers/mmc/host/sdhci-pxav3.c
+++ b/drivers/mmc/host/sdhci-pxav3.c
@@ -47,7 +47,7 @@
 #define  SDCLK_DELAY_MASK		0x1f
 
 #define SD_CFG_FIFO_PARAM		0x100
-#define  SDCFG_GEN_PAD_CLK_ON		(1<<6)
+#define  SDCFG_GEN_PAD_CLK_ON		BIT(6)
 #define  SDCFG_GEN_PAD_CLK_CNT_MASK	0xFF
 #define  SDCFG_GEN_PAD_CLK_CNT_SHIFT	24
 
@@ -55,8 +55,8 @@
 #define SD_CE_ATA_1			0x10C
 
 #define SD_CE_ATA_2			0x10E
-#define  SDCE_MISC_INT			(1<<2)
-#define  SDCE_MISC_INT_EN		(1<<1)
+#define  SDCE_MISC_INT			BIT(2)
+#define  SDCE_MISC_INT_EN		BIT(1)
 
 struct sdhci_pxa {
 	struct clk *clk_core;
-- 
1.9.1

  parent reply	other threads:[~2015-09-07 11:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-07 11:31 [PATCH-v2 0/3] mmc: sdhci-pxav3: Fix tabbing issue Vaibhav Hiremath
2015-09-07 11:31 ` Vaibhav Hiremath
2015-09-07 11:31 ` [PATCH-v2 1/3] " Vaibhav Hiremath
2015-09-07 11:31   ` Vaibhav Hiremath
2015-09-07 11:31   ` Vaibhav Hiremath
2015-09-07 11:56   ` Jisheng Zhang
2015-09-07 11:56     ` Jisheng Zhang
2015-09-07 11:56     ` Jisheng Zhang
2015-09-07 12:52     ` Vaibhav Hiremath
2015-09-07 12:52       ` Vaibhav Hiremath
2015-09-07 12:52       ` Vaibhav Hiremath
2015-09-07 11:31 ` Vaibhav Hiremath [this message]
2015-09-07 11:31   ` [PATCH-v2 2/3] mmc: sdhci-pxav3: Use BIT macro for bit field definitions Vaibhav Hiremath
2015-09-07 11:31 ` [PATCH-v2 3/3] mmc: sdhci: print notice on -EPROBE_DEFER in sdhci_add_host() fn Vaibhav Hiremath
2015-09-07 11:31   ` Vaibhav Hiremath
2015-09-07 11:31   ` Vaibhav Hiremath
2015-09-15 12:28 ` [PATCH-v2 0/3] mmc: sdhci-pxav3: Fix tabbing issue Ulf Hansson
2015-09-15 12:28   ` Ulf Hansson
2015-09-15 12:28   ` Ulf Hansson
2015-09-15 14:06   ` Vaibhav Hiremath
2015-09-15 14:06     ` Vaibhav Hiremath
2015-09-15 14:06     ` Vaibhav Hiremath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441625471-16315-3-git-send-email-vaibhav.hiremath@linaro.org \
    --to=vaibhav.hiremath@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.