From: Anna Schumaker <Anna.Schumaker@netapp.com> To: <linux-nfs@vger.kernel.org>, <linux-btrfs@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>, <linux-api@vger.kernel.org>, <zab@zabbo.net>, <viro@zeniv.linux.org.uk>, <clm@fb.com>, <darrick.wong@oracle.com>, <mtk.manpages@gmail.com>, <andros@netapp.com>, <hch@infradead.org> Subject: [PATCH v2 4/9] vfs: Copy should check len after file open mode Date: Fri, 11 Sep 2015 16:30:17 -0400 [thread overview] Message-ID: <1442003423-6884-5-git-send-email-Anna.Schumaker@Netapp.com> (raw) In-Reply-To: <1442003423-6884-1-git-send-email-Anna.Schumaker@Netapp.com> I don't think it makes sense to report that a copy succeeded if the files aren't open properly. Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com> --- fs/read_write.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/read_write.c b/fs/read_write.c index 82c4933..38cc251 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -1345,9 +1345,6 @@ ssize_t vfs_copy_file_range(struct file *file_in, loff_t pos_in, if (flags) return -EINVAL; - if (len == 0) - return 0; - /* copy_file_range allows full ssize_t len, ignoring MAX_RW_COUNT */ ret = rw_verify_area(READ, file_in, &pos_in, len); if (ret >= 0) @@ -1378,6 +1375,9 @@ ssize_t vfs_copy_file_range(struct file *file_in, loff_t pos_in, if (inode_in == inode_out) return -EINVAL; + if (len == 0) + return 0; + ret = mnt_want_write_file(file_out); if (ret) return ret; -- 2.5.1
WARNING: multiple messages have this Message-ID (diff)
From: Anna Schumaker <Anna.Schumaker@netapp.com> To: linux-nfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, zab@zabbo.net, viro@zeniv.linux.org.uk, clm@fb.com, darrick.wong@oracle.com, mtk.manpages@gmail.com, andros@netapp.com, hch@infradead.org Subject: [PATCH v2 4/9] vfs: Copy should check len after file open mode Date: Fri, 11 Sep 2015 16:30:17 -0400 [thread overview] Message-ID: <1442003423-6884-5-git-send-email-Anna.Schumaker@Netapp.com> (raw) In-Reply-To: <1442003423-6884-1-git-send-email-Anna.Schumaker@Netapp.com> I don't think it makes sense to report that a copy succeeded if the files aren't open properly. Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com> --- fs/read_write.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/read_write.c b/fs/read_write.c index 82c4933..38cc251 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -1345,9 +1345,6 @@ ssize_t vfs_copy_file_range(struct file *file_in, loff_t pos_in, if (flags) return -EINVAL; - if (len == 0) - return 0; - /* copy_file_range allows full ssize_t len, ignoring MAX_RW_COUNT */ ret = rw_verify_area(READ, file_in, &pos_in, len); if (ret >= 0) @@ -1378,6 +1375,9 @@ ssize_t vfs_copy_file_range(struct file *file_in, loff_t pos_in, if (inode_in == inode_out) return -EINVAL; + if (len == 0) + return 0; + ret = mnt_want_write_file(file_out); if (ret) return ret; -- 2.5.1
next prev parent reply other threads:[~2015-09-11 20:30 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-09-11 20:30 [PATCH v2 0/9] VFS: In-kernel copy system call Anna Schumaker 2015-09-11 20:30 ` Anna Schumaker 2015-09-11 20:30 ` [PATCH v2 1/9] vfs: add copy_file_range syscall and vfs helper Anna Schumaker 2015-09-11 20:30 ` Anna Schumaker 2015-09-22 11:44 ` David Sterba 2015-09-22 11:44 ` David Sterba 2015-09-22 18:27 ` Anna Schumaker 2015-09-22 18:27 ` Anna Schumaker 2015-09-22 18:27 ` Anna Schumaker 2015-09-11 20:30 ` [PATCH v2 2/9] x86: add sys_copy_file_range to syscall tables Anna Schumaker 2015-09-11 20:30 ` Anna Schumaker 2015-09-11 20:30 ` [PATCH v2 3/9] btrfs: add .copy_file_range file operation Anna Schumaker 2015-09-11 20:30 ` Anna Schumaker 2015-09-11 20:30 ` Anna Schumaker [this message] 2015-09-11 20:30 ` [PATCH v2 4/9] vfs: Copy should check len after file open mode Anna Schumaker 2015-09-22 11:47 ` David Sterba 2015-09-22 11:47 ` David Sterba 2015-09-11 20:30 ` [PATCH v2 5/9] vfs: Copy shouldn't forbid ranges inside the same file Anna Schumaker 2015-09-11 20:30 ` Anna Schumaker 2015-09-11 20:30 ` Anna Schumaker 2015-09-22 11:48 ` David Sterba 2015-09-11 20:30 ` [PATCH v2 6/9] vfs: Copy should use file_out rather than file_in Anna Schumaker 2015-09-11 20:30 ` Anna Schumaker 2015-09-11 20:30 ` [PATCH v2 7/9] vfs: Remove copy_file_range mountpoint checks Anna Schumaker 2015-09-11 20:30 ` Anna Schumaker 2015-09-22 11:52 ` David Sterba 2015-09-11 20:30 ` [PATCH v2 8/9] vfs: copy_file_range() can do a pagecache copy with splice Anna Schumaker 2015-09-11 20:30 ` Anna Schumaker 2015-09-11 20:30 ` Anna Schumaker 2015-09-15 3:32 ` Darrick J. Wong 2015-09-15 15:58 ` Anna Schumaker 2015-09-15 15:58 ` Anna Schumaker 2015-09-15 15:58 ` Anna Schumaker 2015-09-15 16:38 ` Darrick J. Wong 2015-09-15 16:38 ` Darrick J. Wong 2015-09-15 17:01 ` Austin S Hemmelgarn 2015-09-15 17:01 ` Austin S Hemmelgarn 2015-09-11 20:30 ` [PATCH v2 9/9] btrfs: btrfs_copy_file_range() only supports reflinks Anna Schumaker 2015-09-11 20:30 ` Anna Schumaker 2015-09-22 11:56 ` David Sterba 2015-09-11 20:30 ` [PATCH v2 10/9] copy_file_range.2: New page documenting copy_file_range() Anna Schumaker 2015-09-11 20:30 ` Anna Schumaker 2015-09-13 7:50 ` Michael Kerrisk (man-pages) 2015-09-14 18:32 ` Darrick J. Wong 2015-09-14 18:32 ` Darrick J. Wong 2015-09-22 20:10 ` Anna Schumaker 2015-09-22 20:10 ` Anna Schumaker 2015-09-22 20:10 ` Anna Schumaker 2015-09-22 20:30 ` Pádraig Brady 2015-09-22 20:30 ` Pádraig Brady 2015-09-28 17:23 ` Darrick J. Wong 2015-09-14 19:02 ` Austin S Hemmelgarn 2015-09-22 20:30 ` Anna Schumaker 2015-09-22 20:30 ` Anna Schumaker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1442003423-6884-5-git-send-email-Anna.Schumaker@Netapp.com \ --to=anna.schumaker@netapp.com \ --cc=andros@netapp.com \ --cc=clm@fb.com \ --cc=darrick.wong@oracle.com \ --cc=hch@infradead.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-btrfs@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-nfs@vger.kernel.org \ --cc=mtk.manpages@gmail.com \ --cc=viro@zeniv.linux.org.uk \ --cc=zab@zabbo.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.