All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jisheng Zhang <jszhang@marvell.com>
To: <linux@arm.linux.org.uk>, <rostedt@goodmis.org>,
	<mingo@redhat.com>, <trenn@suse.de>, <arjan@linux.intel.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	Jisheng Zhang <jszhang@marvell.com>
Subject: [PATCH v2] arm: add cpu_idle tracepoints to arch_cpu_idle
Date: Thu, 17 Sep 2015 01:32:40 +0800	[thread overview]
Message-ID: <1442424760-4104-1-git-send-email-jszhang@marvell.com> (raw)

Currently, if cpuidle is disabled or not supported, powertop reports
zero wakeups and zero events. This is due to the cpu_idle tracepoints
are missing.

This patch is to make cpu_idle tracepoints always available even if
cpuidle is disabled or not supported.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 Since v1:
   - ignore arm_pm_idle.
 arch/arm/kernel/process.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index 7a7c4ce..83d2dc5 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -28,6 +28,7 @@
 #include <linux/random.h>
 #include <linux/hw_breakpoint.h>
 #include <linux/leds.h>
+#include <trace/events/power.h>
 
 #include <asm/processor.h>
 #include <asm/thread_notify.h>
@@ -66,11 +67,15 @@ void (*arm_pm_idle)(void);
 
 void arch_cpu_idle(void)
 {
-	if (arm_pm_idle)
+	if (arm_pm_idle) {
 		arm_pm_idle();
-	else
+		local_irq_enable();
+	} else {
+		trace_cpu_idle_rcuidle(1, smp_processor_id());
 		cpu_do_idle();
-	local_irq_enable();
+		local_irq_enable();
+		trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, smp_processor_id());
+	}
 }
 
 void arch_cpu_idle_prepare(void)
-- 
2.5.1


WARNING: multiple messages have this Message-ID (diff)
From: jszhang@marvell.com (Jisheng Zhang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm: add cpu_idle tracepoints to arch_cpu_idle
Date: Thu, 17 Sep 2015 01:32:40 +0800	[thread overview]
Message-ID: <1442424760-4104-1-git-send-email-jszhang@marvell.com> (raw)

Currently, if cpuidle is disabled or not supported, powertop reports
zero wakeups and zero events. This is due to the cpu_idle tracepoints
are missing.

This patch is to make cpu_idle tracepoints always available even if
cpuidle is disabled or not supported.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 Since v1:
   - ignore arm_pm_idle.
 arch/arm/kernel/process.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index 7a7c4ce..83d2dc5 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -28,6 +28,7 @@
 #include <linux/random.h>
 #include <linux/hw_breakpoint.h>
 #include <linux/leds.h>
+#include <trace/events/power.h>
 
 #include <asm/processor.h>
 #include <asm/thread_notify.h>
@@ -66,11 +67,15 @@ void (*arm_pm_idle)(void);
 
 void arch_cpu_idle(void)
 {
-	if (arm_pm_idle)
+	if (arm_pm_idle) {
 		arm_pm_idle();
-	else
+		local_irq_enable();
+	} else {
+		trace_cpu_idle_rcuidle(1, smp_processor_id());
 		cpu_do_idle();
-	local_irq_enable();
+		local_irq_enable();
+		trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, smp_processor_id());
+	}
 }
 
 void arch_cpu_idle_prepare(void)
-- 
2.5.1

             reply	other threads:[~2015-09-16 17:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-16 17:32 Jisheng Zhang [this message]
2015-09-16 17:32 ` [PATCH v2] arm: add cpu_idle tracepoints to arch_cpu_idle Jisheng Zhang
2015-09-17  8:07 ` Jisheng Zhang
2015-09-17  8:07   ` Jisheng Zhang
2015-09-17  8:44   ` Jisheng Zhang
2015-09-17  8:44     ` Jisheng Zhang
2015-09-17 13:14     ` Steven Rostedt
2015-09-17 13:14       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442424760-4104-1-git-send-email-jszhang@marvell.com \
    --to=jszhang@marvell.com \
    --cc=arjan@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.