All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Srinivas Kandagatla <srinivas.kandagatla@gmail.com>,
	Maxime Coquelin <maxime.coquelin@st.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-arm-kernel@lists.infradead.org, kernel@stlinux.com,
	linux-serial@vger.kernel.org
Subject: [PATCH 10/17] tty/serial: st-asc: drop the use of IRQF_NO_SUSPEND
Date: Mon, 21 Sep 2015 16:47:06 +0100	[thread overview]
Message-ID: <1442850433-5903-11-git-send-email-sudeep.holla@arm.com> (raw)
In-Reply-To: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com>

These drivers doesn't claim the serial device to be wakeup source. Even
if it is, it needs to use enable_irq_wake or other related PM wakeup
APIs to enable it.

This patch removes yet another misuse of IRQF_NO_SUSPEND.

Cc: Srinivas Kandagatla <srinivas.kandagatla@gmail.com>
Cc: Maxime Coquelin <maxime.coquelin@st.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: kernel@stlinux.com
Cc: linux-serial@vger.kernel.org
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 drivers/tty/serial/st-asc.c      | 2 +-
 drivers/tty/serial/stm32-usart.c | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
index d625664ce1b5..2d78cb3627ae 100644
--- a/drivers/tty/serial/st-asc.c
+++ b/drivers/tty/serial/st-asc.c
@@ -430,7 +430,7 @@ static void asc_break_ctl(struct uart_port *port, int break_state)
  */
 static int asc_startup(struct uart_port *port)
 {
-	if (request_irq(port->irq, asc_interrupt, IRQF_NO_SUSPEND,
+	if (request_irq(port->irq, asc_interrupt, 0,
 			asc_port_name(port), port)) {
 		dev_err(port->dev, "cannot allocate irq.\n");
 		return -ENODEV;
diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c
index e3de9c6d2226..f89d1f79be18 100644
--- a/drivers/tty/serial/stm32-usart.c
+++ b/drivers/tty/serial/stm32-usart.c
@@ -322,8 +322,7 @@ static int stm32_startup(struct uart_port *port)
 	u32 val;
 	int ret;
 
-	ret = request_irq(port->irq, stm32_interrupt, IRQF_NO_SUSPEND,
-			  name, port);
+	ret = request_irq(port->irq, stm32_interrupt, 0, name, port);
 	if (ret)
 		return ret;
 
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: sudeep.holla@arm.com (Sudeep Holla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/17] tty/serial: st-asc: drop the use of IRQF_NO_SUSPEND
Date: Mon, 21 Sep 2015 16:47:06 +0100	[thread overview]
Message-ID: <1442850433-5903-11-git-send-email-sudeep.holla@arm.com> (raw)
In-Reply-To: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com>

These drivers doesn't claim the serial device to be wakeup source. Even
if it is, it needs to use enable_irq_wake or other related PM wakeup
APIs to enable it.

This patch removes yet another misuse of IRQF_NO_SUSPEND.

Cc: Srinivas Kandagatla <srinivas.kandagatla@gmail.com>
Cc: Maxime Coquelin <maxime.coquelin@st.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-arm-kernel at lists.infradead.org
Cc: kernel at stlinux.com
Cc: linux-serial at vger.kernel.org
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 drivers/tty/serial/st-asc.c      | 2 +-
 drivers/tty/serial/stm32-usart.c | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
index d625664ce1b5..2d78cb3627ae 100644
--- a/drivers/tty/serial/st-asc.c
+++ b/drivers/tty/serial/st-asc.c
@@ -430,7 +430,7 @@ static void asc_break_ctl(struct uart_port *port, int break_state)
  */
 static int asc_startup(struct uart_port *port)
 {
-	if (request_irq(port->irq, asc_interrupt, IRQF_NO_SUSPEND,
+	if (request_irq(port->irq, asc_interrupt, 0,
 			asc_port_name(port), port)) {
 		dev_err(port->dev, "cannot allocate irq.\n");
 		return -ENODEV;
diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c
index e3de9c6d2226..f89d1f79be18 100644
--- a/drivers/tty/serial/stm32-usart.c
+++ b/drivers/tty/serial/stm32-usart.c
@@ -322,8 +322,7 @@ static int stm32_startup(struct uart_port *port)
 	u32 val;
 	int ret;
 
-	ret = request_irq(port->irq, stm32_interrupt, IRQF_NO_SUSPEND,
-			  name, port);
+	ret = request_irq(port->irq, stm32_interrupt, 0, name, port);
 	if (ret)
 		return ret;
 
-- 
1.9.1

  parent reply	other threads:[~2015-09-21 15:48 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-21 15:46 [PATCH 00/17] PM / wakeup : remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla
2015-09-21 15:46 ` [PATCH 01/17] rtc: pl031: " Sudeep Holla
2015-09-21 15:46   ` [rtc-linux] " Sudeep Holla
2015-10-02 10:40   ` Linus Walleij
2015-10-02 10:40     ` [rtc-linux] " Linus Walleij
2015-10-02 10:45     ` Sudeep Holla
2015-10-02 10:45       ` [rtc-linux] " Sudeep Holla
2015-10-02 13:16       ` Alexandre Belloni
2015-10-02 13:16         ` [rtc-linux] " Alexandre Belloni
2015-10-05  8:49       ` Linus Walleij
2015-10-05  8:49         ` [rtc-linux] " Linus Walleij
2015-10-03 15:20   ` Alexandre Belloni
2015-10-03 15:20     ` [rtc-linux] " Alexandre Belloni
2015-09-21 15:46 ` [PATCH 02/17] rtc: ab8500: " Sudeep Holla
2015-09-21 15:46   ` [rtc-linux] " Sudeep Holla
2015-10-02 10:41   ` Linus Walleij
2015-10-02 10:41     ` [rtc-linux] " Linus Walleij
2015-10-03 15:20   ` Alexandre Belloni
2015-10-03 15:20     ` [rtc-linux] " Alexandre Belloni
2015-09-21 15:46 ` [PATCH 03/17] input: tegra-kbc: drop use " Sudeep Holla
2015-10-05  5:44   ` Thierry Reding
2015-10-05 10:24   ` Laxman Dewangan
2015-10-05 10:24     ` Laxman Dewangan
2015-10-19 17:34     ` Sudeep Holla
2015-10-26  8:37       ` Dmitry Torokhov
2015-09-21 15:47 ` [PATCH 04/17] powerpc: mpic: use IRQCHIP_SKIP_SET_WAKE instead of redundant mpic_irq_set_wake Sudeep Holla
2015-09-22 23:50   ` Scott Wood
2015-09-22 23:50     ` Scott Wood
2015-09-23  2:35     ` Wang Dongsheng
2015-09-23  2:35       ` Wang Dongsheng
2015-09-23  2:35       ` Wang Dongsheng
2015-09-23  3:49       ` Thomas Gleixner
2015-09-23  5:31         ` Wang Dongsheng
2015-09-23  5:31           ` Wang Dongsheng
2015-09-23  8:00           ` Thomas Gleixner
2015-09-23  4:06   ` Scott Wood
2015-09-23  4:06     ` Scott Wood
2015-10-19 17:35     ` Sudeep Holla
2015-10-19 17:46       ` Scott Wood
2015-09-21 15:47 ` [PATCH 05/17] platform: x86: remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla
2015-10-03 16:09   ` Darren Hart
2015-09-21 15:47 ` [PATCH 06/17] rtc: ds1343: " Sudeep Holla
2015-09-21 15:47   ` [rtc-linux] " Sudeep Holla
2015-10-03 15:20   ` Alexandre Belloni
2015-10-03 15:20     ` [rtc-linux] " Alexandre Belloni
2015-09-21 15:47 ` [PATCH 07/17] input: tegra-kbc: drop use " Sudeep Holla
2015-09-21 23:21   ` Lee Jones
2015-09-22  0:43     ` Dmitry Torokhov
2015-09-22 21:08       ` Lee Jones
2015-09-23  8:53         ` Sudeep Holla
2015-09-22 10:00     ` Sudeep Holla
2015-09-25 12:39   ` [PATCH 07/17][UPDATE] mfd: qcom_rpm: Drop " Sudeep Holla
2015-09-25 16:08     ` Lee Jones
2015-09-21 15:47 ` [PATCH 08/17] hwmon: abx500: drop the use of IRQF_NO_SUSPEND Sudeep Holla
2015-09-23 15:32   ` Guenter Roeck
2015-09-21 15:47 ` [PATCH 09/17] MIPS: ttyFDC: replace IRQF_NO_SUSPEND with IRQF_COND_SUSPEND Sudeep Holla
2015-09-21 15:47 ` Sudeep Holla [this message]
2015-09-21 15:47   ` [PATCH 10/17] tty/serial: st-asc: drop the use of IRQF_NO_SUSPEND Sudeep Holla
2015-09-21 15:47 ` [PATCH 11/17] pm: bf609: remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla
2015-10-19 17:38   ` Sudeep Holla
2015-10-19 17:38     ` Sudeep Holla
2015-09-21 15:47 ` [PATCH 12/17] ARM: OMAP2+: " Sudeep Holla
2015-09-21 15:47   ` Sudeep Holla
2015-10-12 20:20   ` Tony Lindgren
2015-10-12 20:20     ` Tony Lindgren
2015-10-12 20:28     ` Tony Lindgren
2015-10-12 20:28       ` Tony Lindgren
2015-10-13 10:42       ` Sudeep Holla
2015-10-13 10:42         ` Sudeep Holla
2015-10-13 14:53         ` Tony Lindgren
2015-10-13 14:53           ` Tony Lindgren
2015-10-13 15:20           ` Sudeep Holla
2015-10-13 15:20             ` Sudeep Holla
2015-10-13 15:20             ` Sudeep Holla
2015-09-21 15:47 ` [PATCH 13/17] net: gianfar: " Sudeep Holla
2015-09-21 16:24   ` Manoil Claudiu
2015-09-21 16:38     ` Sudeep Holla
2015-09-21 16:51     ` Thomas Gleixner
2015-09-22 14:04       ` Manoil Claudiu
2015-09-22 15:09         ` Sudeep Holla
2015-09-23 21:20       ` Li Yang
2015-09-23 22:03         ` Thomas Gleixner
2015-09-24 21:17           ` Li Yang
2015-09-24 21:23   ` David Miller
2015-09-21 15:47 ` [PATCH 14/17] media: st-rc: " Sudeep Holla
2015-09-21 15:47   ` Sudeep Holla
2015-09-21 15:47   ` Sudeep Holla
2015-10-19 17:40   ` Sudeep Holla
2015-10-19 17:40     ` Sudeep Holla
2015-10-19 17:40     ` Sudeep Holla
2015-09-21 15:47 ` [PATCH 15/17] ir-hix5hd2: drop the use of IRQF_NO_SUSPEND Sudeep Holla
2015-09-23 14:26   ` zhangfei
2015-09-23 14:37     ` Sudeep Holla
2015-09-23 14:50       ` zhangfei
2015-09-21 15:47 ` [PATCH 16/17] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla
2015-09-21 18:53   ` Thomas Gleixner
2015-09-22  9:42     ` Sudeep Holla
2015-09-21 15:47 ` [PATCH 17/17] mfd : ab8500/db8500: fix the abuse of IRQF_NO_SUSPEND Sudeep Holla
2015-09-21 15:47   ` Sudeep Holla
2015-09-21 23:20   ` Lee Jones
2015-09-21 23:20     ` Lee Jones
2015-09-22 10:04     ` Sudeep Holla
2015-09-22 10:04       ` Sudeep Holla
2015-09-22 10:04       ` Sudeep Holla
2015-09-22 21:03       ` Lee Jones
2015-09-22 21:03         ` Lee Jones
2015-09-22 21:03         ` Lee Jones
2015-09-23  9:44         ` Sudeep Holla
2015-09-23  9:44           ` Sudeep Holla
2015-09-23  9:44           ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442850433-5903-11-git-send-email-sudeep.holla@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@stlinux.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=maxime.coquelin@st.com \
    --cc=rjw@rjwysocki.net \
    --cc=srinivas.kandagatla@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.