From: Sudeep Holla <sudeep.holla@arm.com> To: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sudeep Holla <sudeep.holla@arm.com>, Thomas Gleixner <tglx@linutronix.de>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Tony Lindgren <tony@atomide.com>, Kevin Hilman <khilman@deeprootsystems.com>, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 12/17] ARM: OMAP2+: remove misuse of IRQF_NO_SUSPEND flag Date: Mon, 21 Sep 2015 16:47:08 +0100 [thread overview] Message-ID: <1442850433-5903-13-git-send-email-sudeep.holla@arm.com> (raw) In-Reply-To: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> The IRQF_NO_SUSPEND flag is used to identify the interrupts that should be left enabled so as to allow them to work as expected during the suspend-resume cycle, but doesn't guarantee that it will wake the system from a suspended state, enable_irq_wake is recommended to be used for the wakeup. This patch removes the use of IRQF_NO_SUSPEND flags replacing it with enable_irq_wake instead. Cc: Tony Lindgren <tony@atomide.com> Cc: Kevin Hilman <khilman@deeprootsystems.com> Cc: linux-omap@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- arch/arm/mach-omap2/mux.c | 4 ++-- arch/arm/mach-omap2/pm34xx.c | 9 ++++----- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c index 176eef6ef338..12012bef8e63 100644 --- a/arch/arm/mach-omap2/mux.c +++ b/arch/arm/mach-omap2/mux.c @@ -810,13 +810,13 @@ int __init omap_mux_late_init(void) return 0; ret = request_irq(omap_prcm_event_to_irq("io"), - omap_hwmod_mux_handle_irq, IRQF_SHARED | IRQF_NO_SUSPEND, + omap_hwmod_mux_handle_irq, IRQF_SHARED, "hwmod_io", omap_mux_late_init); if (ret) pr_warn("mux: Failed to setup hwmod io irq %d\n", ret); - return 0; + return enable_irq_wake(omap_prcm_event_to_irq("io")); } static void __init omap_mux_package_fixup(struct omap_mux *p, diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c index 87b98bf92366..4b7ac7cd633a 100644 --- a/arch/arm/mach-omap2/pm34xx.c +++ b/arch/arm/mach-omap2/pm34xx.c @@ -472,23 +472,22 @@ int __init omap3_pm_init(void) prcm_setup_regs(); ret = request_irq(omap_prcm_event_to_irq("wkup"), - _prcm_int_handle_wakeup, IRQF_NO_SUSPEND, "pm_wkup", NULL); + _prcm_int_handle_wakeup, 0, "pm_wkup", NULL); if (ret) { pr_err("pm: Failed to request pm_wkup irq\n"); goto err1; } + enable_irq_wake(omap_prcm_event_to_irq("wkup")); /* IO interrupt is shared with mux code */ ret = request_irq(omap_prcm_event_to_irq("io"), - _prcm_int_handle_io, IRQF_SHARED | IRQF_NO_SUSPEND, "pm_io", - omap3_pm_init); - enable_irq(omap_prcm_event_to_irq("io")); - + _prcm_int_handle_io, IRQF_SHARED, "pm_io", omap3_pm_init); if (ret) { pr_err("pm: Failed to request pm_io irq\n"); goto err2; } + enable_irq_wake(omap_prcm_event_to_irq("io")); ret = pwrdm_for_each(pwrdms_setup, NULL); if (ret) { -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: sudeep.holla@arm.com (Sudeep Holla) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 12/17] ARM: OMAP2+: remove misuse of IRQF_NO_SUSPEND flag Date: Mon, 21 Sep 2015 16:47:08 +0100 [thread overview] Message-ID: <1442850433-5903-13-git-send-email-sudeep.holla@arm.com> (raw) In-Reply-To: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> The IRQF_NO_SUSPEND flag is used to identify the interrupts that should be left enabled so as to allow them to work as expected during the suspend-resume cycle, but doesn't guarantee that it will wake the system from a suspended state, enable_irq_wake is recommended to be used for the wakeup. This patch removes the use of IRQF_NO_SUSPEND flags replacing it with enable_irq_wake instead. Cc: Tony Lindgren <tony@atomide.com> Cc: Kevin Hilman <khilman@deeprootsystems.com> Cc: linux-omap at vger.kernel.org Cc: linux-arm-kernel at lists.infradead.org Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- arch/arm/mach-omap2/mux.c | 4 ++-- arch/arm/mach-omap2/pm34xx.c | 9 ++++----- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c index 176eef6ef338..12012bef8e63 100644 --- a/arch/arm/mach-omap2/mux.c +++ b/arch/arm/mach-omap2/mux.c @@ -810,13 +810,13 @@ int __init omap_mux_late_init(void) return 0; ret = request_irq(omap_prcm_event_to_irq("io"), - omap_hwmod_mux_handle_irq, IRQF_SHARED | IRQF_NO_SUSPEND, + omap_hwmod_mux_handle_irq, IRQF_SHARED, "hwmod_io", omap_mux_late_init); if (ret) pr_warn("mux: Failed to setup hwmod io irq %d\n", ret); - return 0; + return enable_irq_wake(omap_prcm_event_to_irq("io")); } static void __init omap_mux_package_fixup(struct omap_mux *p, diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c index 87b98bf92366..4b7ac7cd633a 100644 --- a/arch/arm/mach-omap2/pm34xx.c +++ b/arch/arm/mach-omap2/pm34xx.c @@ -472,23 +472,22 @@ int __init omap3_pm_init(void) prcm_setup_regs(); ret = request_irq(omap_prcm_event_to_irq("wkup"), - _prcm_int_handle_wakeup, IRQF_NO_SUSPEND, "pm_wkup", NULL); + _prcm_int_handle_wakeup, 0, "pm_wkup", NULL); if (ret) { pr_err("pm: Failed to request pm_wkup irq\n"); goto err1; } + enable_irq_wake(omap_prcm_event_to_irq("wkup")); /* IO interrupt is shared with mux code */ ret = request_irq(omap_prcm_event_to_irq("io"), - _prcm_int_handle_io, IRQF_SHARED | IRQF_NO_SUSPEND, "pm_io", - omap3_pm_init); - enable_irq(omap_prcm_event_to_irq("io")); - + _prcm_int_handle_io, IRQF_SHARED, "pm_io", omap3_pm_init); if (ret) { pr_err("pm: Failed to request pm_io irq\n"); goto err2; } + enable_irq_wake(omap_prcm_event_to_irq("io")); ret = pwrdm_for_each(pwrdms_setup, NULL); if (ret) { -- 1.9.1
next prev parent reply other threads:[~2015-09-21 15:48 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-09-21 15:46 [PATCH 00/17] PM / wakeup : remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla 2015-09-21 15:46 ` [PATCH 01/17] rtc: pl031: " Sudeep Holla 2015-09-21 15:46 ` [rtc-linux] " Sudeep Holla 2015-10-02 10:40 ` Linus Walleij 2015-10-02 10:40 ` [rtc-linux] " Linus Walleij 2015-10-02 10:45 ` Sudeep Holla 2015-10-02 10:45 ` [rtc-linux] " Sudeep Holla 2015-10-02 13:16 ` Alexandre Belloni 2015-10-02 13:16 ` [rtc-linux] " Alexandre Belloni 2015-10-05 8:49 ` Linus Walleij 2015-10-05 8:49 ` [rtc-linux] " Linus Walleij 2015-10-03 15:20 ` Alexandre Belloni 2015-10-03 15:20 ` [rtc-linux] " Alexandre Belloni 2015-09-21 15:46 ` [PATCH 02/17] rtc: ab8500: " Sudeep Holla 2015-09-21 15:46 ` [rtc-linux] " Sudeep Holla 2015-10-02 10:41 ` Linus Walleij 2015-10-02 10:41 ` [rtc-linux] " Linus Walleij 2015-10-03 15:20 ` Alexandre Belloni 2015-10-03 15:20 ` [rtc-linux] " Alexandre Belloni 2015-09-21 15:46 ` [PATCH 03/17] input: tegra-kbc: drop use " Sudeep Holla 2015-10-05 5:44 ` Thierry Reding 2015-10-05 10:24 ` Laxman Dewangan 2015-10-05 10:24 ` Laxman Dewangan 2015-10-19 17:34 ` Sudeep Holla 2015-10-26 8:37 ` Dmitry Torokhov 2015-09-21 15:47 ` [PATCH 04/17] powerpc: mpic: use IRQCHIP_SKIP_SET_WAKE instead of redundant mpic_irq_set_wake Sudeep Holla 2015-09-22 23:50 ` Scott Wood 2015-09-22 23:50 ` Scott Wood 2015-09-23 2:35 ` Wang Dongsheng 2015-09-23 2:35 ` Wang Dongsheng 2015-09-23 2:35 ` Wang Dongsheng 2015-09-23 3:49 ` Thomas Gleixner 2015-09-23 5:31 ` Wang Dongsheng 2015-09-23 5:31 ` Wang Dongsheng 2015-09-23 8:00 ` Thomas Gleixner 2015-09-23 4:06 ` Scott Wood 2015-09-23 4:06 ` Scott Wood 2015-10-19 17:35 ` Sudeep Holla 2015-10-19 17:46 ` Scott Wood 2015-09-21 15:47 ` [PATCH 05/17] platform: x86: remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla 2015-10-03 16:09 ` Darren Hart 2015-09-21 15:47 ` [PATCH 06/17] rtc: ds1343: " Sudeep Holla 2015-09-21 15:47 ` [rtc-linux] " Sudeep Holla 2015-10-03 15:20 ` Alexandre Belloni 2015-10-03 15:20 ` [rtc-linux] " Alexandre Belloni 2015-09-21 15:47 ` [PATCH 07/17] input: tegra-kbc: drop use " Sudeep Holla 2015-09-21 23:21 ` Lee Jones 2015-09-22 0:43 ` Dmitry Torokhov 2015-09-22 21:08 ` Lee Jones 2015-09-23 8:53 ` Sudeep Holla 2015-09-22 10:00 ` Sudeep Holla 2015-09-25 12:39 ` [PATCH 07/17][UPDATE] mfd: qcom_rpm: Drop " Sudeep Holla 2015-09-25 16:08 ` Lee Jones 2015-09-21 15:47 ` [PATCH 08/17] hwmon: abx500: drop the use of IRQF_NO_SUSPEND Sudeep Holla 2015-09-23 15:32 ` Guenter Roeck 2015-09-21 15:47 ` [PATCH 09/17] MIPS: ttyFDC: replace IRQF_NO_SUSPEND with IRQF_COND_SUSPEND Sudeep Holla 2015-09-21 15:47 ` [PATCH 10/17] tty/serial: st-asc: drop the use of IRQF_NO_SUSPEND Sudeep Holla 2015-09-21 15:47 ` Sudeep Holla 2015-09-21 15:47 ` [PATCH 11/17] pm: bf609: remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla 2015-10-19 17:38 ` Sudeep Holla 2015-10-19 17:38 ` Sudeep Holla 2015-09-21 15:47 ` Sudeep Holla [this message] 2015-09-21 15:47 ` [PATCH 12/17] ARM: OMAP2+: " Sudeep Holla 2015-10-12 20:20 ` Tony Lindgren 2015-10-12 20:20 ` Tony Lindgren 2015-10-12 20:28 ` Tony Lindgren 2015-10-12 20:28 ` Tony Lindgren 2015-10-13 10:42 ` Sudeep Holla 2015-10-13 10:42 ` Sudeep Holla 2015-10-13 14:53 ` Tony Lindgren 2015-10-13 14:53 ` Tony Lindgren 2015-10-13 15:20 ` Sudeep Holla 2015-10-13 15:20 ` Sudeep Holla 2015-10-13 15:20 ` Sudeep Holla 2015-09-21 15:47 ` [PATCH 13/17] net: gianfar: " Sudeep Holla 2015-09-21 16:24 ` Manoil Claudiu 2015-09-21 16:38 ` Sudeep Holla 2015-09-21 16:51 ` Thomas Gleixner 2015-09-22 14:04 ` Manoil Claudiu 2015-09-22 15:09 ` Sudeep Holla 2015-09-23 21:20 ` Li Yang 2015-09-23 22:03 ` Thomas Gleixner 2015-09-24 21:17 ` Li Yang 2015-09-24 21:23 ` David Miller 2015-09-21 15:47 ` [PATCH 14/17] media: st-rc: " Sudeep Holla 2015-09-21 15:47 ` Sudeep Holla 2015-09-21 15:47 ` Sudeep Holla 2015-10-19 17:40 ` Sudeep Holla 2015-10-19 17:40 ` Sudeep Holla 2015-10-19 17:40 ` Sudeep Holla 2015-09-21 15:47 ` [PATCH 15/17] ir-hix5hd2: drop the use of IRQF_NO_SUSPEND Sudeep Holla 2015-09-23 14:26 ` zhangfei 2015-09-23 14:37 ` Sudeep Holla 2015-09-23 14:50 ` zhangfei 2015-09-21 15:47 ` [PATCH 16/17] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla 2015-09-21 18:53 ` Thomas Gleixner 2015-09-22 9:42 ` Sudeep Holla 2015-09-21 15:47 ` [PATCH 17/17] mfd : ab8500/db8500: fix the abuse of IRQF_NO_SUSPEND Sudeep Holla 2015-09-21 15:47 ` Sudeep Holla 2015-09-21 23:20 ` Lee Jones 2015-09-21 23:20 ` Lee Jones 2015-09-22 10:04 ` Sudeep Holla 2015-09-22 10:04 ` Sudeep Holla 2015-09-22 10:04 ` Sudeep Holla 2015-09-22 21:03 ` Lee Jones 2015-09-22 21:03 ` Lee Jones 2015-09-22 21:03 ` Lee Jones 2015-09-23 9:44 ` Sudeep Holla 2015-09-23 9:44 ` Sudeep Holla 2015-09-23 9:44 ` Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1442850433-5903-13-git-send-email-sudeep.holla@arm.com \ --to=sudeep.holla@arm.com \ --cc=khilman@deeprootsystems.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=rjw@rjwysocki.net \ --cc=tglx@linutronix.de \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.