From: Tomeu Vizoso <tomeu.vizoso@collabora.com> To: linux-kernel@vger.kernel.org Cc: Rob Herring <robh+dt@kernel.org>, Stephen Warren <swarren@wwwdotorg.org>, Javier Martinez Canillas <javier@osg.samsung.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Mark Brown <broonie@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, Alan Stern <stern@rowland.harvard.edu>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, linux-arm-kernel@lists.infradead.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>, devicetree@vger.kernel.org, Russell King <rmk+kernel@arm.linux.org.uk>, Linus Walleij <linus.walleij@linaro.org>, Ulf Hansson <ulf.hansson@linaro.org>, linux-acpi@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>, Tomeu Vizoso <tomeu.vizoso@collabora.com> Subject: [PATCH v7 20/20] of/platform: Defer probes of registered devices Date: Tue, 29 Sep 2015 11:10:58 +0200 [thread overview] Message-ID: <1443517859-30376-21-git-send-email-tomeu.vizoso@collabora.com> (raw) In-Reply-To: <1443517859-30376-1-git-send-email-tomeu.vizoso@collabora.com> Instead of trying to match and probe platform and AMBA devices right after each is registered, delay their probes until device_initcall_sync. This means that devices will start probing once all built-in drivers have registered, and after all platform and AMBA devices from the DT have been registered already. This allows us to prevent deferred probes by probing dependencies on demand. Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> --- Changes in v7: - Removed patch that moved deferred probe processing to device_initcall_sync, as it's not currently needed and can be applied later if we find any boards that fail to boot without this change. Changes in v4: - Also defer probes of AMBA devices registered from the DT as they can also request resources. drivers/of/platform.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index 408d89f1d124..7b33e0369374 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -164,7 +164,8 @@ static struct platform_device *of_platform_device_create_pdata( struct device_node *np, const char *bus_id, void *platform_data, - struct device *parent) + struct device *parent, + bool probe_late) { struct platform_device *dev; @@ -178,6 +179,7 @@ static struct platform_device *of_platform_device_create_pdata( dev->dev.bus = &platform_bus_type; dev->dev.platform_data = platform_data; + dev->dev.probe_late = probe_late; of_dma_configure(&dev->dev, dev->dev.of_node); of_msi_configure(&dev->dev, dev->dev.of_node); @@ -209,7 +211,8 @@ struct platform_device *of_platform_device_create(struct device_node *np, const char *bus_id, struct device *parent) { - return of_platform_device_create_pdata(np, bus_id, NULL, parent); + return of_platform_device_create_pdata(np, bus_id, NULL, parent, + false); } EXPORT_SYMBOL(of_platform_device_create); @@ -240,6 +243,7 @@ static struct amba_device *of_amba_device_create(struct device_node *node, dev->dev.of_node = of_node_get(node); dev->dev.parent = parent ? : &platform_bus; dev->dev.platform_data = platform_data; + dev->dev.probe_late = true; if (bus_id) dev_set_name(&dev->dev, "%s", bus_id); else @@ -358,7 +362,8 @@ static int of_platform_bus_create(struct device_node *bus, return 0; } - dev = of_platform_device_create_pdata(bus, bus_id, platform_data, parent); + dev = of_platform_device_create_pdata(bus, bus_id, platform_data, + parent, true); if (!dev || !of_match_node(matches, bus)) return 0; -- 2.4.3
WARNING: multiple messages have this Message-ID (diff)
From: tomeu.vizoso@collabora.com (Tomeu Vizoso) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v7 20/20] of/platform: Defer probes of registered devices Date: Tue, 29 Sep 2015 11:10:58 +0200 [thread overview] Message-ID: <1443517859-30376-21-git-send-email-tomeu.vizoso@collabora.com> (raw) In-Reply-To: <1443517859-30376-1-git-send-email-tomeu.vizoso@collabora.com> Instead of trying to match and probe platform and AMBA devices right after each is registered, delay their probes until device_initcall_sync. This means that devices will start probing once all built-in drivers have registered, and after all platform and AMBA devices from the DT have been registered already. This allows us to prevent deferred probes by probing dependencies on demand. Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> --- Changes in v7: - Removed patch that moved deferred probe processing to device_initcall_sync, as it's not currently needed and can be applied later if we find any boards that fail to boot without this change. Changes in v4: - Also defer probes of AMBA devices registered from the DT as they can also request resources. drivers/of/platform.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index 408d89f1d124..7b33e0369374 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -164,7 +164,8 @@ static struct platform_device *of_platform_device_create_pdata( struct device_node *np, const char *bus_id, void *platform_data, - struct device *parent) + struct device *parent, + bool probe_late) { struct platform_device *dev; @@ -178,6 +179,7 @@ static struct platform_device *of_platform_device_create_pdata( dev->dev.bus = &platform_bus_type; dev->dev.platform_data = platform_data; + dev->dev.probe_late = probe_late; of_dma_configure(&dev->dev, dev->dev.of_node); of_msi_configure(&dev->dev, dev->dev.of_node); @@ -209,7 +211,8 @@ struct platform_device *of_platform_device_create(struct device_node *np, const char *bus_id, struct device *parent) { - return of_platform_device_create_pdata(np, bus_id, NULL, parent); + return of_platform_device_create_pdata(np, bus_id, NULL, parent, + false); } EXPORT_SYMBOL(of_platform_device_create); @@ -240,6 +243,7 @@ static struct amba_device *of_amba_device_create(struct device_node *node, dev->dev.of_node = of_node_get(node); dev->dev.parent = parent ? : &platform_bus; dev->dev.platform_data = platform_data; + dev->dev.probe_late = true; if (bus_id) dev_set_name(&dev->dev, "%s", bus_id); else @@ -358,7 +362,8 @@ static int of_platform_bus_create(struct device_node *bus, return 0; } - dev = of_platform_device_create_pdata(bus, bus_id, platform_data, parent); + dev = of_platform_device_create_pdata(bus, bus_id, platform_data, + parent, true); if (!dev || !of_match_node(matches, bus)) return 0; -- 2.4.3
next prev parent reply other threads:[~2015-09-29 9:12 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-09-29 9:10 [PATCH v7 0/20] On-demand device probing Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-09-29 9:10 ` [PATCH v7 01/20] driver core: handle -EPROBE_DEFER from bus_type.match() Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-10-17 6:51 ` Greg Kroah-Hartman 2015-10-17 6:51 ` Greg Kroah-Hartman 2015-09-29 9:10 ` [PATCH v7 02/20] ARM: amba: Move reading of periphid to amba_match() Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-09-29 9:10 ` [PATCH v7 04/20] of: add function to allow probing a device from a OF node Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-10-17 6:53 ` Greg Kroah-Hartman 2015-10-17 6:53 ` Greg Kroah-Hartman 2015-09-29 9:10 ` [PATCH v7 05/20] gpio: Probe GPIO drivers on demand Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-09-29 9:10 ` [PATCH v7 06/20] pinctrl: Probe pinctrl devices " Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-09-29 9:10 ` [PATCH v7 07/20] regulator: core: Probe regulators " Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-09-29 9:10 ` [PATCH v7 09/20] drm/tegra: Probe dpaux devices " Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-09-29 9:10 ` [PATCH v7 10/20] i2c: core: Probe i2c adapters and " Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso [not found] ` <1443517859-30376-1-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> 2015-09-29 9:10 ` [PATCH v7 03/20] of/platform: Point to struct device from device node Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-09-29 9:10 ` [PATCH v7 08/20] drm: Probe panels on demand Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-09-29 9:10 ` [PATCH v7 11/20] pwm: Probe PWM chip devices " Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-09-29 9:10 ` [PATCH v7 17/20] dma: of: Probe DMA controllers " Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-09-29 9:10 ` [PATCH v7 12/20] backlight: Probe backlight devices " Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-09-29 9:10 ` [PATCH v7 13/20] usb: phy: Probe phy " Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-10-17 6:55 ` Greg Kroah-Hartman 2015-10-17 6:55 ` Greg Kroah-Hartman 2015-09-29 9:10 ` [PATCH v7 14/20] clk: Probe clk providers " Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-09-29 9:10 ` [PATCH v7 15/20] pinctrl: Probe pinctrl devices " Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-09-29 9:10 ` [PATCH v7 16/20] phy: core: Probe phy providers " Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-09-29 9:10 ` [PATCH v7 18/20] power-supply: Probe power supplies " Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso 2015-09-29 9:10 ` [PATCH v7 19/20] driver core: Allow deferring probes until late init Tomeu Vizoso 2015-09-29 9:10 ` Tomeu Vizoso [not found] ` <1443517859-30376-20-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> 2015-10-14 23:12 ` Frank Rowand 2015-10-14 23:12 ` Frank Rowand 2015-10-14 23:12 ` Frank Rowand 2015-09-29 9:10 ` Tomeu Vizoso [this message] 2015-09-29 9:10 ` [PATCH v7 20/20] of/platform: Defer probes of registered devices Tomeu Vizoso 2015-10-14 23:12 ` Frank Rowand 2015-10-14 23:12 ` Frank Rowand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1443517859-30376-21-git-send-email-tomeu.vizoso@collabora.com \ --to=tomeu.vizoso@collabora.com \ --cc=arnd@arndb.de \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.torokhov@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=javier@osg.samsung.com \ --cc=linus.walleij@linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rjw@rjwysocki.net \ --cc=rmk+kernel@arm.linux.org.uk \ --cc=robh+dt@kernel.org \ --cc=stern@rowland.harvard.edu \ --cc=swarren@wwwdotorg.org \ --cc=thierry.reding@gmail.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.