All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: <tony@atomide.com>
Cc: <wsa@the-dreams.de>, <sre@kernel.org>, <pavel@ucw.cz>,
	<pali.rohar@gmail.com>, <linux-omap@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Roger Quadros <rogerq@ti.com>
Subject: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default
Date: Wed, 14 Oct 2015 13:44:16 +0300	[thread overview]
Message-ID: <1444819456-26728-3-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1444819456-26728-1-git-send-email-rogerq@ti.com>

Let's keep the SSI ports disabled in the omap3.dtsi to avoid
getting the following noise on the console for boards that don't
use the SSI ports.

"omap_ssi_port 4805a000.ssi-port: DT data is missing cawake gpio (err=-2)"

As omap3-n900 uses one SSI port, mark it enabled there.

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm/boot/dts/omap3-n900.dts | 1 +
 arch/arm/boot/dts/omap3.dtsi     | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index 5f5e0f3..bdb72fb 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -949,6 +949,7 @@
 };
 
 &ssi_port1 {
+	status = "ok";
 	pinctrl-names = "default";
 	pinctrl-0 = <&ssi_pins>;
 
diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
index 8a2b253..25b0b37 100644
--- a/arch/arm/boot/dts/omap3.dtsi
+++ b/arch/arm/boot/dts/omap3.dtsi
@@ -815,6 +815,7 @@
 				interrupt-parent = <&intc>;
 				interrupts = <67>,
 					     <68>;
+				status = "disabled";
 			};
 
 			ssi_port2: ssi-port@4805b000 {
@@ -828,6 +829,7 @@
 				interrupt-parent = <&intc>;
 				interrupts = <69>,
 					     <70>;
+				status = "disabled";
 			};
 		};
 	};
-- 
2.1.4


WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: tony@atomide.com
Cc: wsa@the-dreams.de, sre@kernel.org, pavel@ucw.cz,
	pali.rohar@gmail.com, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org, Roger Quadros <rogerq@ti.com>
Subject: [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default
Date: Wed, 14 Oct 2015 13:44:16 +0300	[thread overview]
Message-ID: <1444819456-26728-3-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1444819456-26728-1-git-send-email-rogerq@ti.com>

Let's keep the SSI ports disabled in the omap3.dtsi to avoid
getting the following noise on the console for boards that don't
use the SSI ports.

"omap_ssi_port 4805a000.ssi-port: DT data is missing cawake gpio (err=-2)"

As omap3-n900 uses one SSI port, mark it enabled there.

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm/boot/dts/omap3-n900.dts | 1 +
 arch/arm/boot/dts/omap3.dtsi     | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index 5f5e0f3..bdb72fb 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -949,6 +949,7 @@
 };
 
 &ssi_port1 {
+	status = "ok";
 	pinctrl-names = "default";
 	pinctrl-0 = <&ssi_pins>;
 
diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
index 8a2b253..25b0b37 100644
--- a/arch/arm/boot/dts/omap3.dtsi
+++ b/arch/arm/boot/dts/omap3.dtsi
@@ -815,6 +815,7 @@
 				interrupt-parent = <&intc>;
 				interrupts = <67>,
 					     <68>;
+				status = "disabled";
 			};
 
 			ssi_port2: ssi-port@4805b000 {
@@ -828,6 +829,7 @@
 				interrupt-parent = <&intc>;
 				interrupts = <69>,
 					     <70>;
+				status = "disabled";
 			};
 		};
 	};
-- 
2.1.4

  parent reply	other threads:[~2015-10-14 10:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14 10:44 [PATCH 0/2] omap: hsi: Fix warnings on boards that don't use ssi ports Roger Quadros
2015-10-14 10:44 ` Roger Quadros
2015-10-14 10:44 ` [PATCH 1/2] hsi: omap_ssi_port: Prevent warning if cawake_gpio is not defined Roger Quadros
2015-10-14 10:44   ` Roger Quadros
2015-10-14 11:40   ` Sebastian Reichel
2015-10-14 10:44 ` Roger Quadros [this message]
2015-10-14 10:44   ` [PATCH 2/2] ARM: dts: omap3: keep ssi ports by default Roger Quadros
2015-10-14 10:53   ` Pali Rohár
2015-10-14 10:53     ` Pali Rohár
2015-10-14 11:17     ` Sebastian Reichel
2015-10-14 11:19   ` Sebastian Reichel
2015-10-14 11:27     ` Roger Quadros
2015-10-14 11:27       ` Roger Quadros
2015-10-14 11:37       ` Sebastian Reichel
2015-10-14 11:54         ` Roger Quadros
2015-10-14 11:54           ` Roger Quadros
2015-10-19 16:01   ` Tony Lindgren
2015-10-21  8:08     ` Roger Quadros
2015-10-21  8:08       ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444819456-26728-3-git-send-email-rogerq@ti.com \
    --to=rogerq@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.