All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: clemens@ladisch.de, tiwai@suse.de
Cc: alsa-devel@alsa-project.org
Subject: [PATCH 1/5] ALSA: firewire-tascam: remove buffer initialization in driver side
Date: Tue, 20 Oct 2015 23:46:55 +0900	[thread overview]
Message-ID: <1445352419-21827-2-git-send-email-o-takashi@sakamocchi.jp> (raw)
In-Reply-To: <1445352419-21827-1-git-send-email-o-takashi@sakamocchi.jp>

The given buffer to callback function is cleared in caller side.

This commit removes buffer initialization in callee side.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 sound/firewire/tascam/tascam-transaction.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sound/firewire/tascam/tascam-transaction.c b/sound/firewire/tascam/tascam-transaction.c
index d4f64ae..370f932 100644
--- a/sound/firewire/tascam/tascam-transaction.c
+++ b/sound/firewire/tascam/tascam-transaction.c
@@ -67,8 +67,6 @@ static int fill_message(struct snd_rawmidi_substream *substream, u8 *buf)
 	u8 status;
 	int consume;
 
-	buf[0] = buf[1] = buf[2] = buf[3] = 0x00;
-
 	len = snd_rawmidi_transmit_peek(substream, buf + 1, 3);
 	if (len == 0)
 		return 0;
-- 
2.1.4

  reply	other threads:[~2015-10-20 14:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20 14:46 [PATCH 0/5 v2] ALSA: firewire-tascam: fix sending the same MIDI bytes in two transactions Takashi Sakamoto
2015-10-20 14:46 ` Takashi Sakamoto [this message]
2015-10-20 14:46 ` [PATCH 2/5] ALSA: firewire-tascam: change type of valiables according to function prototype Takashi Sakamoto
2015-10-20 14:46 ` [PATCH 3/5] ALSA: firewire-tascam: use better name for local variables to describe their intension Takashi Sakamoto
2015-10-20 14:46 ` [PATCH 4/5] ALSA: firewire-tascam: fix loop condition with some readable variables Takashi Sakamoto
2015-10-20 14:46 ` [PATCH 5/5] ALSA: firewire-tascam: clear extra MIDI bytes in an asynchronous transaction Takashi Sakamoto
2015-10-20 18:11 ` [PATCH 0/5 v2] ALSA: firewire-tascam: fix sending the same MIDI bytes in two transactions Takashi Iwai
2015-10-20 22:46   ` Takashi Sakamoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445352419-21827-2-git-send-email-o-takashi@sakamocchi.jp \
    --to=o-takashi@sakamocchi.jp \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.