From: Jeff Layton <jlayton-vpEMnDpepFuMZCB2o+C8xQ@public.gmane.org> To: bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org Cc: linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Al Viro <viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org> Subject: [PATCH v6 10/19] nfsd: keep some rudimentary stats on nfsd_file cache Date: Tue, 20 Oct 2015 13:33:43 -0400 [thread overview] Message-ID: <1445362432-18869-11-git-send-email-jeff.layton@primarydata.com> (raw) In-Reply-To: <1445362432-18869-1-git-send-email-jeff.layton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org> Per chain count and max length, protected by the per-chain spinlock. When the file is read, we walk the array of buckets and fetch the count from each. Signed-off-by: Jeff Layton <jeff.layton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org> --- fs/nfsd/filecache.c | 40 ++++++++++++++++++++++++++++++++++++++++ fs/nfsd/filecache.h | 1 + fs/nfsd/nfsctl.c | 10 ++++++++++ 3 files changed, 51 insertions(+) diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c index 2cbdf9889993..aca3c3c638ec 100644 --- a/fs/nfsd/filecache.c +++ b/fs/nfsd/filecache.c @@ -11,6 +11,7 @@ #include <linux/sched.h> #include <linux/list_lru.h> #include <linux/fsnotify_backend.h> +#include <linux/seq_file.h> #include "vfs.h" #include "nfsd.h" @@ -30,6 +31,8 @@ struct nfsd_fcache_bucket { struct hlist_head nfb_head; spinlock_t nfb_lock; + unsigned int nfb_count; + unsigned int nfb_maxcount; }; static struct kmem_cache *nfsd_file_slab; @@ -171,6 +174,7 @@ nfsd_file_unhash(struct nfsd_file *nf) trace_nfsd_file_unhash(nf); if (test_bit(NFSD_FILE_HASHED, &nf->nf_flags)) { + --nfsd_file_hashtbl[nf->nf_hashval].nfb_count; clear_bit(NFSD_FILE_HASHED, &nf->nf_flags); hlist_del_rcu(&nf->nf_node); list_lru_del(&nfsd_file_lru, &nf->nf_lru); @@ -587,6 +591,9 @@ retry: list_lru_add(&nfsd_file_lru, &new->nf_lru); hlist_add_head_rcu(&new->nf_node, &nfsd_file_hashtbl[hashval].nfb_head); + ++nfsd_file_hashtbl[hashval].nfb_count; + nfsd_file_hashtbl[hashval].nfb_maxcount = max(nfsd_file_hashtbl[hashval].nfb_maxcount, + nfsd_file_hashtbl[hashval].nfb_count); spin_unlock(&nfsd_file_hashtbl[hashval].nfb_lock); nf = new; new = NULL; @@ -669,3 +676,36 @@ open_file: wake_up_bit(&nf->nf_flags, NFSD_FILE_PENDING); goto out; } + +/* + * Note that fields may be added, removed or reordered in the future. Programs + * scraping this file for info should test the labels to ensure they're + * getting the correct field. + */ +static int nfsd_file_cache_stats_show(struct seq_file *m, void *v) +{ + unsigned int i, count = 0, longest = 0; + + /* + * No need for spinlocks here since we're not terribly interested in + * accuracy. We do take the nfsd_mutex simply to ensure that we + * don't end up racing with server shutdown + */ + mutex_lock(&nfsd_mutex); + if (nfsd_file_hashtbl) { + for (i = 0; i < NFSD_FILE_HASH_SIZE; i++) { + count += nfsd_file_hashtbl[i].nfb_count; + longest = max(longest, nfsd_file_hashtbl[i].nfb_count); + } + } + mutex_unlock(&nfsd_mutex); + + seq_printf(m, "total entries: %u\n", count); + seq_printf(m, "longest chain: %u\n", longest); + return 0; +} + +int nfsd_file_cache_stats_open(struct inode *inode, struct file *file) +{ + return single_open(file, nfsd_file_cache_stats_show, NULL); +} diff --git a/fs/nfsd/filecache.h b/fs/nfsd/filecache.h index a045c7fe3655..756aea5431da 100644 --- a/fs/nfsd/filecache.h +++ b/fs/nfsd/filecache.h @@ -40,4 +40,5 @@ struct nfsd_file *nfsd_file_get(struct nfsd_file *nf); void nfsd_file_close_inode_sync(struct inode *inode); __be32 nfsd_file_acquire(struct svc_rqst *rqstp, struct svc_fh *fhp, unsigned int may_flags, struct nfsd_file **nfp); +int nfsd_file_cache_stats_open(struct inode *, struct file *); #endif /* _FS_NFSD_FILECACHE_H */ diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c index 9690cb4dd588..eff44a277f70 100644 --- a/fs/nfsd/nfsctl.c +++ b/fs/nfsd/nfsctl.c @@ -22,6 +22,7 @@ #include "state.h" #include "netns.h" #include "pnfs.h" +#include "filecache.h" /* * We have a single directory with several nodes in it. @@ -36,6 +37,7 @@ enum { NFSD_Threads, NFSD_Pool_Threads, NFSD_Pool_Stats, + NFSD_File_Cache_Stats, NFSD_Reply_Cache_Stats, NFSD_Versions, NFSD_Ports, @@ -220,6 +222,13 @@ static const struct file_operations pool_stats_operations = { .owner = THIS_MODULE, }; +static struct file_operations file_cache_stats_operations = { + .open = nfsd_file_cache_stats_open, + .read = seq_read, + .llseek = seq_lseek, + .release = single_release, +}; + static struct file_operations reply_cache_stats_operations = { .open = nfsd_reply_cache_stats_open, .read = seq_read, @@ -1138,6 +1147,7 @@ static int nfsd_fill_super(struct super_block * sb, void * data, int silent) [NFSD_Threads] = {"threads", &transaction_ops, S_IWUSR|S_IRUSR}, [NFSD_Pool_Threads] = {"pool_threads", &transaction_ops, S_IWUSR|S_IRUSR}, [NFSD_Pool_Stats] = {"pool_stats", &pool_stats_operations, S_IRUGO}, + [NFSD_File_Cache_Stats] = {"file_cache_stats", &file_cache_stats_operations, S_IRUGO}, [NFSD_Reply_Cache_Stats] = {"reply_cache_stats", &reply_cache_stats_operations, S_IRUGO}, [NFSD_Versions] = {"versions", &transaction_ops, S_IWUSR|S_IRUSR}, [NFSD_Ports] = {"portlist", &transaction_ops, S_IWUSR|S_IRUGO}, -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Layton <jlayton@poochiereds.net> To: bfields@fieldses.org Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Al Viro <viro@ZenIV.linux.org.uk> Subject: [PATCH v6 10/19] nfsd: keep some rudimentary stats on nfsd_file cache Date: Tue, 20 Oct 2015 13:33:43 -0400 [thread overview] Message-ID: <1445362432-18869-11-git-send-email-jeff.layton@primarydata.com> (raw) In-Reply-To: <1445362432-18869-1-git-send-email-jeff.layton@primarydata.com> Per chain count and max length, protected by the per-chain spinlock. When the file is read, we walk the array of buckets and fetch the count from each. Signed-off-by: Jeff Layton <jeff.layton@primarydata.com> --- fs/nfsd/filecache.c | 40 ++++++++++++++++++++++++++++++++++++++++ fs/nfsd/filecache.h | 1 + fs/nfsd/nfsctl.c | 10 ++++++++++ 3 files changed, 51 insertions(+) diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c index 2cbdf9889993..aca3c3c638ec 100644 --- a/fs/nfsd/filecache.c +++ b/fs/nfsd/filecache.c @@ -11,6 +11,7 @@ #include <linux/sched.h> #include <linux/list_lru.h> #include <linux/fsnotify_backend.h> +#include <linux/seq_file.h> #include "vfs.h" #include "nfsd.h" @@ -30,6 +31,8 @@ struct nfsd_fcache_bucket { struct hlist_head nfb_head; spinlock_t nfb_lock; + unsigned int nfb_count; + unsigned int nfb_maxcount; }; static struct kmem_cache *nfsd_file_slab; @@ -171,6 +174,7 @@ nfsd_file_unhash(struct nfsd_file *nf) trace_nfsd_file_unhash(nf); if (test_bit(NFSD_FILE_HASHED, &nf->nf_flags)) { + --nfsd_file_hashtbl[nf->nf_hashval].nfb_count; clear_bit(NFSD_FILE_HASHED, &nf->nf_flags); hlist_del_rcu(&nf->nf_node); list_lru_del(&nfsd_file_lru, &nf->nf_lru); @@ -587,6 +591,9 @@ retry: list_lru_add(&nfsd_file_lru, &new->nf_lru); hlist_add_head_rcu(&new->nf_node, &nfsd_file_hashtbl[hashval].nfb_head); + ++nfsd_file_hashtbl[hashval].nfb_count; + nfsd_file_hashtbl[hashval].nfb_maxcount = max(nfsd_file_hashtbl[hashval].nfb_maxcount, + nfsd_file_hashtbl[hashval].nfb_count); spin_unlock(&nfsd_file_hashtbl[hashval].nfb_lock); nf = new; new = NULL; @@ -669,3 +676,36 @@ open_file: wake_up_bit(&nf->nf_flags, NFSD_FILE_PENDING); goto out; } + +/* + * Note that fields may be added, removed or reordered in the future. Programs + * scraping this file for info should test the labels to ensure they're + * getting the correct field. + */ +static int nfsd_file_cache_stats_show(struct seq_file *m, void *v) +{ + unsigned int i, count = 0, longest = 0; + + /* + * No need for spinlocks here since we're not terribly interested in + * accuracy. We do take the nfsd_mutex simply to ensure that we + * don't end up racing with server shutdown + */ + mutex_lock(&nfsd_mutex); + if (nfsd_file_hashtbl) { + for (i = 0; i < NFSD_FILE_HASH_SIZE; i++) { + count += nfsd_file_hashtbl[i].nfb_count; + longest = max(longest, nfsd_file_hashtbl[i].nfb_count); + } + } + mutex_unlock(&nfsd_mutex); + + seq_printf(m, "total entries: %u\n", count); + seq_printf(m, "longest chain: %u\n", longest); + return 0; +} + +int nfsd_file_cache_stats_open(struct inode *inode, struct file *file) +{ + return single_open(file, nfsd_file_cache_stats_show, NULL); +} diff --git a/fs/nfsd/filecache.h b/fs/nfsd/filecache.h index a045c7fe3655..756aea5431da 100644 --- a/fs/nfsd/filecache.h +++ b/fs/nfsd/filecache.h @@ -40,4 +40,5 @@ struct nfsd_file *nfsd_file_get(struct nfsd_file *nf); void nfsd_file_close_inode_sync(struct inode *inode); __be32 nfsd_file_acquire(struct svc_rqst *rqstp, struct svc_fh *fhp, unsigned int may_flags, struct nfsd_file **nfp); +int nfsd_file_cache_stats_open(struct inode *, struct file *); #endif /* _FS_NFSD_FILECACHE_H */ diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c index 9690cb4dd588..eff44a277f70 100644 --- a/fs/nfsd/nfsctl.c +++ b/fs/nfsd/nfsctl.c @@ -22,6 +22,7 @@ #include "state.h" #include "netns.h" #include "pnfs.h" +#include "filecache.h" /* * We have a single directory with several nodes in it. @@ -36,6 +37,7 @@ enum { NFSD_Threads, NFSD_Pool_Threads, NFSD_Pool_Stats, + NFSD_File_Cache_Stats, NFSD_Reply_Cache_Stats, NFSD_Versions, NFSD_Ports, @@ -220,6 +222,13 @@ static const struct file_operations pool_stats_operations = { .owner = THIS_MODULE, }; +static struct file_operations file_cache_stats_operations = { + .open = nfsd_file_cache_stats_open, + .read = seq_read, + .llseek = seq_lseek, + .release = single_release, +}; + static struct file_operations reply_cache_stats_operations = { .open = nfsd_reply_cache_stats_open, .read = seq_read, @@ -1138,6 +1147,7 @@ static int nfsd_fill_super(struct super_block * sb, void * data, int silent) [NFSD_Threads] = {"threads", &transaction_ops, S_IWUSR|S_IRUSR}, [NFSD_Pool_Threads] = {"pool_threads", &transaction_ops, S_IWUSR|S_IRUSR}, [NFSD_Pool_Stats] = {"pool_stats", &pool_stats_operations, S_IRUGO}, + [NFSD_File_Cache_Stats] = {"file_cache_stats", &file_cache_stats_operations, S_IRUGO}, [NFSD_Reply_Cache_Stats] = {"reply_cache_stats", &reply_cache_stats_operations, S_IRUGO}, [NFSD_Versions] = {"versions", &transaction_ops, S_IWUSR|S_IRUSR}, [NFSD_Ports] = {"portlist", &transaction_ops, S_IWUSR|S_IRUGO}, -- 2.4.3
next prev parent reply other threads:[~2015-10-20 17:33 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-10-20 17:33 [PATCH v6 00/19] nfsd: open file caching Jeff Layton 2015-10-20 17:33 ` Jeff Layton 2015-10-20 17:33 ` [PATCH v6 03/19] fs: add a kerneldoc header to fput Jeff Layton 2015-10-20 17:33 ` [PATCH v6 04/19] fs: rename "delayed_fput" infrastructure to "fput_global" Jeff Layton 2015-10-20 17:33 ` [PATCH v6 06/19] fsnotify: export several symbols Jeff Layton 2015-10-20 17:33 ` [PATCH v6 07/19] locks: create a new notifier chain for lease attempts Jeff Layton 2015-10-20 17:33 ` [PATCH v6 15/19] nfsd: convert nfs4_file->fi_fds array to use nfsd_files Jeff Layton 2015-10-20 17:33 ` [PATCH v6 19/19] nfsd: rip out the raparms cache Jeff Layton [not found] ` <1445362432-18869-1-git-send-email-jeff.layton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org> 2015-10-20 17:33 ` [PATCH v6 01/19] nfsd: move include of state.h from trace.c to trace.h Jeff Layton 2015-10-20 17:33 ` Jeff Layton [not found] ` <1445362432-18869-2-git-send-email-jeff.layton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org> 2015-10-21 15:51 ` J. Bruce Fields 2015-10-21 15:51 ` J. Bruce Fields 2015-10-20 17:33 ` [PATCH v6 02/19] fs: have flush_delayed_fput flush the workqueue job Jeff Layton 2015-10-20 17:33 ` Jeff Layton 2015-10-20 17:33 ` [PATCH v6 05/19] fs: add fput_global Jeff Layton 2015-10-20 17:33 ` Jeff Layton 2015-10-20 17:33 ` [PATCH v6 08/19] sunrpc: add a new cache_detail operation for when a cache is flushed Jeff Layton 2015-10-20 17:33 ` Jeff Layton 2015-10-20 17:33 ` [PATCH v6 09/19] nfsd: add a new struct file caching facility to nfsd Jeff Layton 2015-10-20 17:33 ` Jeff Layton 2015-10-20 17:33 ` Jeff Layton [this message] 2015-10-20 17:33 ` [PATCH v6 10/19] nfsd: keep some rudimentary stats on nfsd_file cache Jeff Layton 2015-10-20 17:33 ` [PATCH v6 11/19] nfsd: allow filecache open to skip fh_verify check Jeff Layton 2015-10-20 17:33 ` Jeff Layton 2015-10-20 17:33 ` [PATCH v6 12/19] nfsd: hook up nfsd_write to the new nfsd_file cache Jeff Layton 2015-10-20 17:33 ` Jeff Layton 2015-10-20 17:33 ` [PATCH v6 13/19] nfsd: hook up nfsd_read to the " Jeff Layton 2015-10-20 17:33 ` Jeff Layton 2015-10-20 17:33 ` [PATCH v6 14/19] nfsd: hook nfsd_commit up " Jeff Layton 2015-10-20 17:33 ` Jeff Layton 2015-10-20 17:33 ` [PATCH v6 16/19] nfsd: have nfsd_test_lock use " Jeff Layton 2015-10-20 17:33 ` Jeff Layton 2015-10-20 17:33 ` [PATCH v6 17/19] nfsd: convert fi_deleg_file and ls_file fields to nfsd_file Jeff Layton 2015-10-20 17:33 ` Jeff Layton 2015-10-20 17:33 ` [PATCH v6 18/19] nfsd: hook up nfs4_preprocess_stateid_op to the nfsd_file cache Jeff Layton 2015-10-20 17:33 ` Jeff Layton 2015-10-21 15:57 ` [PATCH v6 00/19] nfsd: open file caching J. Bruce Fields 2015-10-21 15:57 ` J. Bruce Fields 2015-10-22 21:19 ` J. Bruce Fields 2015-10-22 21:19 ` J. Bruce Fields 2015-10-23 0:21 ` Jeff Layton
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1445362432-18869-11-git-send-email-jeff.layton@primarydata.com \ --to=jlayton-vpemndpepfumzcb2o+c8xq@public.gmane.org \ --cc=bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org \ --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.