All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, patches.audio@intel.com,
	liam.r.girdwood@linux.intel.com,
	Vinod Koul <vinod.koul@intel.com>,
	broonie@kernel.org, Jeeja KP <jeeja.kp@intel.com>
Subject: [PATCH 2/9] ASoC: Intel: Skylake: Remove BE copier blob memcpy
Date: Thu, 22 Oct 2015 23:22:35 +0530	[thread overview]
Message-ID: <1445536362-26670-3-git-send-email-vinod.koul@intel.com> (raw)
In-Reply-To: <1445536362-26670-1-git-send-email-vinod.koul@intel.com>

From: Jeeja KP <jeeja.kp@intel.com>

The BE copier private data allowed endpoint configuration blobs, now these
are queried from BIOS, we don't need to copy the blob, but only capability.

Removing the blob from private data will not allocate memory for module
specific config in which case memcpy will fail. Fix is to assign the ptr
queried from the NHLT table for the endpoint configuration.

Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 sound/soc/intel/skylake/skl-topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
index a5d8420ce69a..7c920857007e 100644
--- a/sound/soc/intel/skylake/skl-topology.c
+++ b/sound/soc/intel/skylake/skl-topology.c
@@ -926,7 +926,7 @@ static int skl_tplg_be_fill_pipe_params(struct snd_soc_dai *dai,
 					params->s_freq, params->stream);
 	if (cfg) {
 		mconfig->formats_config.caps_size = cfg->size;
-		memcpy(mconfig->formats_config.caps, &cfg->caps, cfg->size);
+		mconfig->formats_config.caps = (u32 *) &cfg->caps;
 	} else {
 		dev_err(dai->dev, "Blob NULL for id %x type %d dirn %d\n",
 					mconfig->vbus_id, link_type,
-- 
1.9.1

  parent reply	other threads:[~2015-10-22 17:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-22 17:52 [PATCH 0/9] ASoC: Intel: Skylake: Fixes and updates Vinod Koul
2015-10-22 17:52 ` [PATCH 1/9] ASoC: Intel: Skylake: Fix return for pm_runtime_get_sync() Vinod Koul
2015-10-23 17:47   ` Applied "ASoC: Intel: Skylake: Fix return for pm_runtime_get_sync()" to the asoc tree Mark Brown
2015-10-22 17:52 ` Vinod Koul [this message]
2015-10-23 17:47   ` Applied "ASoC: Intel: Skylake: Remove BE copier blob memcpy" " Mark Brown
2015-10-22 17:52 ` [PATCH 3/9] ASoC: Intel: Skylake: Fix to use correct macros for the path iteration Vinod Koul
2015-10-23 17:47   ` Applied "ASoC: Intel: Skylake: Fix to use correct macros for the path iteration" to the asoc tree Mark Brown
2015-10-22 17:52 ` [PATCH 4/9] ASoC: Intel: Skylake: Fix to fill all sink/source pipe params Vinod Koul
2015-10-23 17:47   ` Applied "ASoC: Intel: Skylake: Fix to fill all sink/source pipe params" to the asoc tree Mark Brown
2015-10-22 17:52 ` [PATCH 5/9] ASoC: Intel: Skylake: Update for ssp node index in copier cfg Vinod Koul
2015-10-23 16:30   ` Mark Brown
2015-10-24 11:56     ` Vinod Koul
2015-10-23 17:47   ` Applied "ASoC: Intel: Skylake: Update for ssp node index in copier cfg" to the asoc tree Mark Brown
2015-10-22 17:52 ` [PATCH 6/9] ASoC: Intel: Skylake: Add support to disable module notifications Vinod Koul
2015-10-23 17:47   ` Applied "ASoC: Intel: Skylake: Add support to disable module notifications" to the asoc tree Mark Brown
2015-10-22 17:52 ` [PATCH 7/9] ASoC: Intel: Skylake: Fix to check return value of dsp init Vinod Koul
2015-10-23 17:47   ` Applied "ASoC: Intel: Skylake: Fix to check return value of dsp init" to the asoc tree Mark Brown
2015-10-22 17:52 ` [PATCH 8/9] ASoC: Intel: Skylake: Fix to set Non gateway copier cfg Vinod Koul
2015-10-23 17:47   ` Applied "ASoC: Intel: Skylake: Fix to set Non gateway copier cfg" to the asoc tree Mark Brown
2015-10-22 17:52 ` [PATCH 9/9] ASoC: Intel: Skylake: Add support to topology for module static pin Vinod Koul
2015-10-23 17:47   ` Applied "ASoC: Intel: Skylake: Add support to topology for module static pin" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445536362-26670-3-git-send-email-vinod.koul@intel.com \
    --to=vinod.koul@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jeeja.kp@intel.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=patches.audio@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.