From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: [PATCH 2/2] drm/i915: shut up gen8+ SDE irq dmesg noise
Date: Fri, 23 Oct 2015 10:56:12 +0200 [thread overview]
Message-ID: <1445590572-23631-2-git-send-email-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <1445590572-23631-1-git-send-email-daniel.vetter@ffwll.ch>
We get tons of cases where the master interrupt handler apparently set
a bit, with the SDEIIR agreeing. No idea what's going on there, but
it's consistent on gen8+, no one seems to care about it and it's
making CI results flaky.
Shut it up.
No idea what's going on here, but we've had fun with PCH interrupts
before:
commit 44498aea293b37af1d463acd9658cdce1ecdf427
Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
Date: Fri Feb 22 17:05:28 2013 -0300
drm/i915: also disable south interrupts when handling them
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/i915/i915_irq.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 9caf22caed89..a614e89fc934 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -2353,9 +2353,13 @@ static irqreturn_t gen8_irq_handler(int irq, void *arg)
spt_irq_handler(dev, pch_iir);
else
cpt_irq_handler(dev, pch_iir);
- } else
- DRM_ERROR("The master control interrupt lied (SDE)!\n");
-
+ } else {
+ /*
+ * Like on previous PCH there seems to be something
+ * fishy going on with forwarding PCH interrupts.
+ */
+ DRM_DEBUG_DRIVER("The master control interrupt lied (SDE)!\n");
+ }
}
I915_WRITE_FW(GEN8_MASTER_IRQ, GEN8_MASTER_IRQ_CONTROL);
--
2.5.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-10-23 8:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 8:56 [PATCH 1/2] drm/i915: Shut up GuC errors when it's disabled Daniel Vetter
2015-10-23 8:56 ` Daniel Vetter [this message]
2015-10-23 9:03 ` [PATCH 2/2] drm/i915: shut up gen8+ SDE irq dmesg noise Chris Wilson
2015-10-23 9:14 ` Daniel Vetter
2015-10-23 14:21 ` Dave Gordon
2015-10-23 9:21 ` Jani Nikula
2015-10-23 9:23 ` Daniel Vetter
2015-10-23 13:33 ` Ville Syrjälä
2015-10-23 13:40 ` Chris Wilson
2015-10-23 13:47 ` Ville Syrjälä
2015-10-23 14:42 ` Daniel Vetter
2015-10-23 15:22 ` Ville Syrjälä
2015-10-27 2:31 ` Daniel Vetter
2015-10-27 8:10 ` Jani Nikula
2015-10-28 0:22 ` Daniel Vetter
2015-10-23 9:00 ` [PATCH] drm/i915: Don't complain about lack of ACPI video bios Daniel Vetter
2015-10-23 11:46 ` Jani Nikula
2015-10-23 9:10 ` [PATCH] drm/i915: Shut up GuC errors when it's disabled Daniel Vetter
2015-10-23 10:56 ` Mika Kuoppala
2015-10-23 11:32 ` Daniel Vetter
2015-10-23 9:21 ` [PATCH 1/2] " kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445590572-23631-2-git-send-email-daniel.vetter@ffwll.ch \
--to=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.