From: Punit Vara <punitvara@gmail.com> To: kvalo@qca.qualcomm.com Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Punit Vara <punitvara@gmail.com> Subject: [RESEND PATCH 06/10] net: wireless: ath: simplify return flow for carl9170_regwrite_result() Date: Wed, 28 Oct 2015 00:32:41 +0530 [thread overview] Message-ID: <1445972565-14963-6-git-send-email-punitvara@gmail.com> (raw) In-Reply-To: <1445972565-14963-1-git-send-email-punitvara@gmail.com> This patch is to the carl9170/phy.c file that fixes warning reported by coccicheck : WARNING: end returns can be simplified I have removed unneccessary variable declaration and simply return flow for carl9170_regwrite_result() Signed-off-by: Punit Vara <punitvara@gmail.com> --- drivers/net/wireless/ath/carl9170/phy.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/carl9170/phy.c b/drivers/net/wireless/ath/carl9170/phy.c index dca6df1..f3b5434 100644 --- a/drivers/net/wireless/ath/carl9170/phy.c +++ b/drivers/net/wireless/ath/carl9170/phy.c @@ -966,7 +966,6 @@ static const struct carl9170_phy_freq_entry carl9170_phy_freq_params[] = { static int carl9170_init_rf_bank4_pwr(struct ar9170 *ar, bool band5ghz, u32 freq, enum carl9170_bw bw) { - int err; u32 d0, d1, td0, td1, fd0, fd1; u8 chansel; u8 refsel0 = 1, refsel1 = 0; @@ -1024,11 +1023,7 @@ static int carl9170_init_rf_bank4_pwr(struct ar9170 *ar, bool band5ghz, carl9170_regwrite(0x1c58e8, fd1); carl9170_regwrite_finish(); - err = carl9170_regwrite_result(); - if (err) - return err; - - return 0; + return carl9170_regwrite_result(); } static const struct carl9170_phy_freq_params * -- 2.5.3
WARNING: multiple messages have this Message-ID (diff)
From: Punit Vara <punitvara@gmail.com> To: kvalo@qca.qualcomm.com Cc: netdev@vger.kernel.org, Punit Vara <punitvara@gmail.com>, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org Subject: [RESEND PATCH 06/10] net: wireless: ath: simplify return flow for carl9170_regwrite_result() Date: Wed, 28 Oct 2015 00:32:41 +0530 [thread overview] Message-ID: <1445972565-14963-6-git-send-email-punitvara@gmail.com> (raw) In-Reply-To: <1445972565-14963-1-git-send-email-punitvara@gmail.com> This patch is to the carl9170/phy.c file that fixes warning reported by coccicheck : WARNING: end returns can be simplified I have removed unneccessary variable declaration and simply return flow for carl9170_regwrite_result() Signed-off-by: Punit Vara <punitvara@gmail.com> --- drivers/net/wireless/ath/carl9170/phy.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/carl9170/phy.c b/drivers/net/wireless/ath/carl9170/phy.c index dca6df1..f3b5434 100644 --- a/drivers/net/wireless/ath/carl9170/phy.c +++ b/drivers/net/wireless/ath/carl9170/phy.c @@ -966,7 +966,6 @@ static const struct carl9170_phy_freq_entry carl9170_phy_freq_params[] = { static int carl9170_init_rf_bank4_pwr(struct ar9170 *ar, bool band5ghz, u32 freq, enum carl9170_bw bw) { - int err; u32 d0, d1, td0, td1, fd0, fd1; u8 chansel; u8 refsel0 = 1, refsel1 = 0; @@ -1024,11 +1023,7 @@ static int carl9170_init_rf_bank4_pwr(struct ar9170 *ar, bool band5ghz, carl9170_regwrite(0x1c58e8, fd1); carl9170_regwrite_finish(); - err = carl9170_regwrite_result(); - if (err) - return err; - - return 0; + return carl9170_regwrite_result(); } static const struct carl9170_phy_freq_params * -- 2.5.3 _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2015-10-27 19:04 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-10-27 19:02 [RESEND PATCH 01/10] net: wireless: ath: Remove unnecessary semicolon Punit Vara 2015-10-27 19:02 ` Punit Vara 2015-10-27 19:02 ` [RESEND PATCH 02/10] " Punit Vara 2015-10-27 19:02 ` Punit Vara 2015-10-27 19:02 ` [RESEND PATCH 03/10] net: wireless: rtwifi: Remove duplicated arguments to | Punit Vara 2015-10-27 19:02 ` Punit Vara 2015-10-27 19:02 ` [RESEND PATCH 04/10] net: wireless: brcm80211: " Punit Vara 2015-10-27 19:02 ` Punit Vara 2015-10-27 19:02 ` [RESEND PATCH 05/10] net: wireless: simplify return flow for zd1201_setconfig16 Punit Vara 2015-10-27 19:02 ` Punit Vara 2015-10-27 19:02 ` Punit Vara [this message] 2015-10-27 19:02 ` [RESEND PATCH 06/10] net: wireless: ath: simplify return flow for carl9170_regwrite_result() Punit Vara 2015-10-27 19:02 ` [RESEND PATCH 07/10] net: wireless: iwlegacy: Remove unneeded variable ret Punit Vara 2015-10-27 19:02 ` Punit Vara 2015-10-28 13:35 ` Sergei Shtylyov 2015-10-28 13:35 ` Sergei Shtylyov 2015-10-28 13:35 ` Sergei Shtylyov 2015-10-28 13:36 ` Sergei Shtylyov 2015-10-28 13:36 ` Sergei Shtylyov 2015-10-27 19:02 ` [RESEND PATCH 08/10] net: wireless: brcm80211: Remove unneeded variable which return 0 Punit Vara 2015-10-27 19:02 ` Punit Vara 2015-10-27 19:02 ` [RESEND PATCH 09/10] net: wireless: brcm80211: Remove unneeded variable ret_code returning 0 Punit Vara 2015-10-27 19:02 ` Punit Vara 2015-10-27 19:02 ` [RESEND PATCH 10/10] net: wireless: ath: Remove unneeded variable ret " Punit Vara 2015-10-27 19:02 ` Punit Vara 2016-02-02 16:42 ` [RESEND,01/10] net: wireless: ath: Remove unnecessary semicolon Sudip Mukherjee 2016-02-02 16:42 ` Sudip Mukherjee
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1445972565-14963-6-git-send-email-punitvara@gmail.com \ --to=punitvara@gmail.com \ --cc=ath10k@lists.infradead.org \ --cc=kvalo@qca.qualcomm.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.