From: Punit Vara <punitvara@gmail.com> To: kvalo@qca.qualcomm.com Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Punit Vara <punitvara@gmail.com> Subject: [RESEND PATCH 09/10] net: wireless: brcm80211: Remove unneeded variable ret_code returning 0 Date: Wed, 28 Oct 2015 00:32:44 +0530 [thread overview] Message-ID: <1445972565-14963-9-git-send-email-punitvara@gmail.com> (raw) In-Reply-To: <1445972565-14963-1-git-send-email-punitvara@gmail.com> This patch is to the brcmsmac/stf.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret_code". Return "0" on line 328 Remove unneccesary variable ret_code created to return zero. Signed-off-by: Punit Vara <punitvara@gmail.com> --- drivers/net/wireless/brcm80211/brcmsmac/stf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/brcm80211/brcmsmac/stf.c b/drivers/net/wireless/brcm80211/brcmsmac/stf.c index dd91627..71ddf42 100644 --- a/drivers/net/wireless/brcm80211/brcmsmac/stf.c +++ b/drivers/net/wireless/brcm80211/brcmsmac/stf.c @@ -306,7 +306,6 @@ int brcms_c_stf_txchain_set(struct brcms_c_info *wlc, s32 int_val, bool force) */ int brcms_c_stf_ss_update(struct brcms_c_info *wlc, struct brcms_band *band) { - int ret_code = 0; u8 prev_stf_ss; u8 upd_stf_ss; @@ -325,7 +324,7 @@ int brcms_c_stf_ss_update(struct brcms_c_info *wlc, struct brcms_band *band) PHY_TXC1_MODE_SISO : PHY_TXC1_MODE_CDD; } else { if (wlc->band != band) - return ret_code; + return 0; upd_stf_ss = (wlc->stf->txstreams == 1) ? PHY_TXC1_MODE_SISO : band->band_stf_ss_mode; } @@ -334,7 +333,7 @@ int brcms_c_stf_ss_update(struct brcms_c_info *wlc, struct brcms_band *band) brcms_b_band_stf_ss_set(wlc->hw, upd_stf_ss); } - return ret_code; + return 0; } int brcms_c_stf_attach(struct brcms_c_info *wlc) -- 2.5.3
WARNING: multiple messages have this Message-ID (diff)
From: Punit Vara <punitvara@gmail.com> To: kvalo@qca.qualcomm.com Cc: netdev@vger.kernel.org, Punit Vara <punitvara@gmail.com>, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org Subject: [RESEND PATCH 09/10] net: wireless: brcm80211: Remove unneeded variable ret_code returning 0 Date: Wed, 28 Oct 2015 00:32:44 +0530 [thread overview] Message-ID: <1445972565-14963-9-git-send-email-punitvara@gmail.com> (raw) In-Reply-To: <1445972565-14963-1-git-send-email-punitvara@gmail.com> This patch is to the brcmsmac/stf.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret_code". Return "0" on line 328 Remove unneccesary variable ret_code created to return zero. Signed-off-by: Punit Vara <punitvara@gmail.com> --- drivers/net/wireless/brcm80211/brcmsmac/stf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/brcm80211/brcmsmac/stf.c b/drivers/net/wireless/brcm80211/brcmsmac/stf.c index dd91627..71ddf42 100644 --- a/drivers/net/wireless/brcm80211/brcmsmac/stf.c +++ b/drivers/net/wireless/brcm80211/brcmsmac/stf.c @@ -306,7 +306,6 @@ int brcms_c_stf_txchain_set(struct brcms_c_info *wlc, s32 int_val, bool force) */ int brcms_c_stf_ss_update(struct brcms_c_info *wlc, struct brcms_band *band) { - int ret_code = 0; u8 prev_stf_ss; u8 upd_stf_ss; @@ -325,7 +324,7 @@ int brcms_c_stf_ss_update(struct brcms_c_info *wlc, struct brcms_band *band) PHY_TXC1_MODE_SISO : PHY_TXC1_MODE_CDD; } else { if (wlc->band != band) - return ret_code; + return 0; upd_stf_ss = (wlc->stf->txstreams == 1) ? PHY_TXC1_MODE_SISO : band->band_stf_ss_mode; } @@ -334,7 +333,7 @@ int brcms_c_stf_ss_update(struct brcms_c_info *wlc, struct brcms_band *band) brcms_b_band_stf_ss_set(wlc->hw, upd_stf_ss); } - return ret_code; + return 0; } int brcms_c_stf_attach(struct brcms_c_info *wlc) -- 2.5.3 _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2015-10-27 19:04 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-10-27 19:02 [RESEND PATCH 01/10] net: wireless: ath: Remove unnecessary semicolon Punit Vara 2015-10-27 19:02 ` Punit Vara 2015-10-27 19:02 ` [RESEND PATCH 02/10] " Punit Vara 2015-10-27 19:02 ` Punit Vara 2015-10-27 19:02 ` [RESEND PATCH 03/10] net: wireless: rtwifi: Remove duplicated arguments to | Punit Vara 2015-10-27 19:02 ` Punit Vara 2015-10-27 19:02 ` [RESEND PATCH 04/10] net: wireless: brcm80211: " Punit Vara 2015-10-27 19:02 ` Punit Vara 2015-10-27 19:02 ` [RESEND PATCH 05/10] net: wireless: simplify return flow for zd1201_setconfig16 Punit Vara 2015-10-27 19:02 ` Punit Vara 2015-10-27 19:02 ` [RESEND PATCH 06/10] net: wireless: ath: simplify return flow for carl9170_regwrite_result() Punit Vara 2015-10-27 19:02 ` Punit Vara 2015-10-27 19:02 ` [RESEND PATCH 07/10] net: wireless: iwlegacy: Remove unneeded variable ret Punit Vara 2015-10-27 19:02 ` Punit Vara 2015-10-28 13:35 ` Sergei Shtylyov 2015-10-28 13:35 ` Sergei Shtylyov 2015-10-28 13:35 ` Sergei Shtylyov 2015-10-28 13:36 ` Sergei Shtylyov 2015-10-28 13:36 ` Sergei Shtylyov 2015-10-27 19:02 ` [RESEND PATCH 08/10] net: wireless: brcm80211: Remove unneeded variable which return 0 Punit Vara 2015-10-27 19:02 ` Punit Vara 2015-10-27 19:02 ` Punit Vara [this message] 2015-10-27 19:02 ` [RESEND PATCH 09/10] net: wireless: brcm80211: Remove unneeded variable ret_code returning 0 Punit Vara 2015-10-27 19:02 ` [RESEND PATCH 10/10] net: wireless: ath: Remove unneeded variable ret " Punit Vara 2015-10-27 19:02 ` Punit Vara 2016-02-02 16:42 ` [RESEND,01/10] net: wireless: ath: Remove unnecessary semicolon Sudip Mukherjee 2016-02-02 16:42 ` Sudip Mukherjee
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1445972565-14963-9-git-send-email-punitvara@gmail.com \ --to=punitvara@gmail.com \ --cc=ath10k@lists.infradead.org \ --cc=kvalo@qca.qualcomm.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.