From: Haozhong Zhang <haozhong.zhang@intel.com> To: qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com> Cc: "Michael S. Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, Peter Maydell <peter.maydell@linaro.org>, Marcelo Tosatti <mtosatti@redhat.com>, James Hogan <james.hogan@imgtec.com>, Aurelien Jarno <aurelien@aurel32.net>, Leon Alrae <leon.alrae@imgtec.com>, Alexander Graf <agraf@suse.de>, Christian Borntraeger <borntraeger@de.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, kvm@vger.kernel.org, qemu-ppc@nongnu.org, Haozhong Zhang <haozhong.zhang@intel.com> Subject: [PATCH v3 3/3] target-i386: load the migrated vcpu's TSC rate Date: Mon, 2 Nov 2015 17:26:43 +0800 [thread overview] Message-ID: <1446456403-29909-4-git-send-email-haozhong.zhang@intel.com> (raw) In-Reply-To: <1446456403-29909-1-git-send-email-haozhong.zhang@intel.com> Set vcpu's TSC rate to the migrated value if the user does not specify a TSC rate by cpu option 'tsc-freq' and a migrated TSC rate does exist. If KVM supports TSC scaling, guest programs will observe TSC increasing in the migrated rate other than the host TSC rate. Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com> --- target-i386/kvm.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index aae5e58..2be70df 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -3042,6 +3042,27 @@ int kvm_arch_setup_tsc_khz(CPUState *cs) int r; /* + * If a TSC rate is migrated and the user does not specify the + * vcpu's TSC rate on the destination, the migrated TSC rate will + * be used on the destination after the migration. + */ + if (env->tsc_khz_saved && !env->tsc_khz) { + if (kvm_check_extension(cs->kvm_state, KVM_CAP_TSC_CONTROL)) { + r = kvm_vcpu_ioctl(cs, KVM_SET_TSC_KHZ, env->tsc_khz_saved); + if (r < 0) { + fprintf(stderr, "KVM_SET_TSC_KHZ failed\n"); + } + } else { + r = -1; + fprintf(stderr, "KVM doesn't support TSC scaling\n"); + } + if (r < 0) { + fprintf(stderr, "Use host TSC frequency instead. " + "Guest TSC may be inaccurate.\n"); + } + } + + /* * Prepare vcpu's TSC rate to be migrated. * * - If the user specifies the TSC rate by cpu option 'tsc-freq', -- 2.4.8
WARNING: multiple messages have this Message-ID (diff)
From: Haozhong Zhang <haozhong.zhang@intel.com> To: qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com> Cc: Peter Maydell <peter.maydell@linaro.org>, James Hogan <james.hogan@imgtec.com>, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, Alexander Graf <agraf@suse.de>, Christian Borntraeger <borntraeger@de.ibm.com>, qemu-ppc@nongnu.org, Haozhong Zhang <haozhong.zhang@intel.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Leon Alrae <leon.alrae@imgtec.com>, Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net> Subject: [Qemu-devel] [PATCH v3 3/3] target-i386: load the migrated vcpu's TSC rate Date: Mon, 2 Nov 2015 17:26:43 +0800 [thread overview] Message-ID: <1446456403-29909-4-git-send-email-haozhong.zhang@intel.com> (raw) In-Reply-To: <1446456403-29909-1-git-send-email-haozhong.zhang@intel.com> Set vcpu's TSC rate to the migrated value if the user does not specify a TSC rate by cpu option 'tsc-freq' and a migrated TSC rate does exist. If KVM supports TSC scaling, guest programs will observe TSC increasing in the migrated rate other than the host TSC rate. Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com> --- target-i386/kvm.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index aae5e58..2be70df 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -3042,6 +3042,27 @@ int kvm_arch_setup_tsc_khz(CPUState *cs) int r; /* + * If a TSC rate is migrated and the user does not specify the + * vcpu's TSC rate on the destination, the migrated TSC rate will + * be used on the destination after the migration. + */ + if (env->tsc_khz_saved && !env->tsc_khz) { + if (kvm_check_extension(cs->kvm_state, KVM_CAP_TSC_CONTROL)) { + r = kvm_vcpu_ioctl(cs, KVM_SET_TSC_KHZ, env->tsc_khz_saved); + if (r < 0) { + fprintf(stderr, "KVM_SET_TSC_KHZ failed\n"); + } + } else { + r = -1; + fprintf(stderr, "KVM doesn't support TSC scaling\n"); + } + if (r < 0) { + fprintf(stderr, "Use host TSC frequency instead. " + "Guest TSC may be inaccurate.\n"); + } + } + + /* * Prepare vcpu's TSC rate to be migrated. * * - If the user specifies the TSC rate by cpu option 'tsc-freq', -- 2.4.8
next prev parent reply other threads:[~2015-11-02 9:30 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-02 9:26 [PATCH v3 0/3] target-i386: save/restore vcpu's TSC rate during migration Haozhong Zhang 2015-11-02 9:26 ` [Qemu-devel] " Haozhong Zhang 2015-11-02 9:26 ` [PATCH v3 1/3] target-i386: add a subsection for migrating vcpu's TSC rate Haozhong Zhang 2015-11-02 9:26 ` [Qemu-devel] " Haozhong Zhang 2015-11-11 14:16 ` Eduardo Habkost 2015-11-11 14:16 ` Eduardo Habkost 2015-11-11 14:27 ` Haozhong Zhang 2015-11-11 14:27 ` [Qemu-devel] " Haozhong Zhang 2015-11-13 2:23 ` Haozhong Zhang 2015-11-13 2:23 ` [Qemu-devel] " Haozhong Zhang 2015-11-13 15:21 ` Eduardo Habkost 2015-11-13 15:21 ` [Qemu-devel] " Eduardo Habkost 2015-11-16 0:10 ` Haozhong Zhang 2015-11-16 0:10 ` Haozhong Zhang 2015-11-02 9:26 ` [PATCH v3 2/3] target-i386: calculate vcpu's TSC rate to be migrated Haozhong Zhang 2015-11-02 9:26 ` [Qemu-devel] " Haozhong Zhang 2015-11-02 9:40 ` James Hogan 2015-11-02 9:40 ` [Qemu-devel] " James Hogan 2015-11-02 13:26 ` Haozhong Zhang 2015-11-02 13:26 ` [Qemu-devel] " Haozhong Zhang 2015-11-05 8:05 ` Christian Borntraeger 2015-11-05 8:05 ` [Qemu-devel] " Christian Borntraeger 2015-11-05 8:14 ` Haozhong Zhang 2015-11-05 8:14 ` [Qemu-devel] " Haozhong Zhang 2015-11-04 21:42 ` Eduardo Habkost 2015-11-04 21:42 ` [Qemu-devel] " Eduardo Habkost 2015-11-05 1:30 ` Haozhong Zhang 2015-11-05 1:30 ` [Qemu-devel] " Haozhong Zhang 2015-11-05 16:05 ` Eduardo Habkost 2015-11-05 16:05 ` [Qemu-devel] " Eduardo Habkost 2015-11-06 2:32 ` haozhong.zhang 2015-11-06 2:32 ` [Qemu-devel] " haozhong.zhang 2015-11-06 15:12 ` Eduardo Habkost 2015-11-06 15:12 ` [Qemu-devel] " Eduardo Habkost 2015-11-09 0:33 ` haozhong.zhang 2015-11-09 0:33 ` [Qemu-devel] " haozhong.zhang 2015-11-09 16:01 ` Eduardo Habkost 2015-11-09 16:01 ` [Qemu-devel] " Eduardo Habkost 2015-11-09 16:37 ` Dr. David Alan Gilbert 2015-11-09 16:37 ` [Qemu-devel] " Dr. David Alan Gilbert 2015-11-10 1:08 ` Haozhong Zhang 2015-11-10 1:08 ` [Qemu-devel] " Haozhong Zhang 2015-11-11 14:54 ` Eduardo Habkost 2015-11-11 14:54 ` [Qemu-devel] " Eduardo Habkost 2015-11-11 15:35 ` Haozhong Zhang 2015-11-11 15:35 ` [Qemu-devel] " Haozhong Zhang 2015-11-10 16:57 ` Haozhong Zhang 2015-11-10 16:57 ` [Qemu-devel] " Haozhong Zhang 2015-11-11 15:23 ` Eduardo Habkost 2015-11-11 15:23 ` [Qemu-devel] " Eduardo Habkost 2015-11-11 15:33 ` Haozhong Zhang 2015-11-11 15:33 ` [Qemu-devel] " Haozhong Zhang 2015-11-02 9:26 ` Haozhong Zhang [this message] 2015-11-02 9:26 ` [Qemu-devel] [PATCH v3 3/3] target-i386: load the migrated vcpu's TSC rate Haozhong Zhang 2015-11-05 16:10 ` Eduardo Habkost 2015-11-05 16:10 ` [Qemu-devel] " Eduardo Habkost 2015-11-06 2:32 ` Haozhong Zhang 2015-11-06 2:32 ` [Qemu-devel] " Haozhong Zhang 2015-11-06 15:15 ` Eduardo Habkost 2015-11-06 15:15 ` [Qemu-devel] " Eduardo Habkost
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1446456403-29909-4-git-send-email-haozhong.zhang@intel.com \ --to=haozhong.zhang@intel.com \ --cc=agraf@suse.de \ --cc=aurelien@aurel32.net \ --cc=borntraeger@de.ibm.com \ --cc=cornelia.huck@de.ibm.com \ --cc=dgilbert@redhat.com \ --cc=ehabkost@redhat.com \ --cc=james.hogan@imgtec.com \ --cc=kvm@vger.kernel.org \ --cc=leon.alrae@imgtec.com \ --cc=mst@redhat.com \ --cc=mtosatti@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=qemu-devel@nongnu.org \ --cc=qemu-ppc@nongnu.org \ --cc=rth@twiddle.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.