From: Marek Szyprowski <m.szyprowski@samsung.com> To: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Marek Szyprowski <m.szyprowski@samsung.com>, Russell King - ARM Linux <linux@arm.linux.org.uk>, Kukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <k.kozlowski@samsung.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Subject: [PATCH 1/2] drivers: amba: properly handle devices with power domains Date: Wed, 25 Nov 2015 13:58:09 +0100 [thread overview] Message-ID: <1448456289-31960-1-git-send-email-m.szyprowski@samsung.com> (raw) In-Reply-To: <1448456127-31842-1-git-send-email-m.szyprowski@samsung.com> To read pid/cid registers, the probed device need to be properly turned on. When it is inside a power domain, the bus code should ensure that the given power domain is enabled before trying to access device's registers. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- drivers/amba/bus.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c index f009936..25715cb 100644 --- a/drivers/amba/bus.c +++ b/drivers/amba/bus.c @@ -373,6 +373,12 @@ int amba_device_add(struct amba_device *dev, struct resource *parent) goto err_release; } + ret = dev_pm_domain_attach(&dev->dev, true); + if (ret) { + iounmap(tmp); + goto err_release; + } + ret = amba_get_enable_pclk(dev); if (ret == 0) { u32 pid, cid; @@ -398,6 +404,7 @@ int amba_device_add(struct amba_device *dev, struct resource *parent) } iounmap(tmp); + dev_pm_domain_detach(&dev->dev, true); if (ret) goto err_release; -- 1.9.2
WARNING: multiple messages have this Message-ID (diff)
From: m.szyprowski@samsung.com (Marek Szyprowski) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] drivers: amba: properly handle devices with power domains Date: Wed, 25 Nov 2015 13:58:09 +0100 [thread overview] Message-ID: <1448456289-31960-1-git-send-email-m.szyprowski@samsung.com> (raw) In-Reply-To: <1448456127-31842-1-git-send-email-m.szyprowski@samsung.com> To read pid/cid registers, the probed device need to be properly turned on. When it is inside a power domain, the bus code should ensure that the given power domain is enabled before trying to access device's registers. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- drivers/amba/bus.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c index f009936..25715cb 100644 --- a/drivers/amba/bus.c +++ b/drivers/amba/bus.c @@ -373,6 +373,12 @@ int amba_device_add(struct amba_device *dev, struct resource *parent) goto err_release; } + ret = dev_pm_domain_attach(&dev->dev, true); + if (ret) { + iounmap(tmp); + goto err_release; + } + ret = amba_get_enable_pclk(dev); if (ret == 0) { u32 pid, cid; @@ -398,6 +404,7 @@ int amba_device_add(struct amba_device *dev, struct resource *parent) } iounmap(tmp); + dev_pm_domain_detach(&dev->dev, true); if (ret) goto err_release; -- 1.9.2
next prev parent reply other threads:[~2015-11-25 12:58 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-25 12:55 [PATCH 0/2] Exynos4210: fix power domain for MDMA1 device Marek Szyprowski 2015-11-25 12:55 ` Marek Szyprowski 2015-11-25 12:55 ` [PATCH] ARM: dts: exynos4210: Add power domain to G2D device Marek Szyprowski 2015-11-25 12:55 ` Marek Szyprowski 2015-11-25 23:55 ` Krzysztof Kozlowski 2015-11-25 23:55 ` Krzysztof Kozlowski 2015-11-26 7:35 ` Krzysztof Kozlowski 2015-11-26 7:35 ` Krzysztof Kozlowski 2015-11-25 12:55 ` [PATCH 2/2] ARM: dts: exynos4210: MDMA1 device belongs to LCD0 power domain Marek Szyprowski 2015-11-25 12:55 ` Marek Szyprowski 2015-11-25 12:58 ` Marek Szyprowski [this message] 2015-11-25 12:58 ` [PATCH 1/2] drivers: amba: properly handle devices with power domains Marek Szyprowski 2015-11-25 13:24 ` Russell King - ARM Linux 2015-11-25 13:24 ` Russell King - ARM Linux 2015-11-25 13:34 ` Marek Szyprowski 2015-11-25 13:34 ` Marek Szyprowski 2015-11-25 13:56 ` Ulf Hansson 2015-11-25 13:56 ` Ulf Hansson 2015-11-25 14:43 ` Marek Szyprowski 2015-11-25 14:43 ` Marek Szyprowski 2015-11-25 18:09 ` Russell King - ARM Linux 2015-11-25 18:09 ` Russell King - ARM Linux 2015-11-26 8:39 ` Marek Szyprowski 2015-11-26 8:39 ` Marek Szyprowski 2015-11-26 10:24 ` Ulf Hansson 2015-11-26 10:24 ` Ulf Hansson 2015-11-26 10:59 ` Russell King - ARM Linux 2015-11-26 10:59 ` Russell King - ARM Linux 2015-11-26 12:33 ` Marek Szyprowski 2015-11-26 12:33 ` Marek Szyprowski 2015-11-26 12:55 ` Marek Szyprowski 2015-11-26 12:55 ` Marek Szyprowski 2015-11-26 15:04 ` Mathieu Poirier 2015-11-26 15:04 ` Mathieu Poirier 2015-11-27 7:42 ` Marek Szyprowski 2015-11-27 7:42 ` Marek Szyprowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1448456289-31960-1-git-send-email-m.szyprowski@samsung.com \ --to=m.szyprowski@samsung.com \ --cc=b.zolnierkie@samsung.com \ --cc=k.kozlowski@samsung.com \ --cc=kgene@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.