From: Eduardo Habkost <ehabkost@redhat.com> To: qemu-devel@nongnu.org Cc: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org, Huaitong Han <huaitong.han@intel.com> Subject: [for-2.6 PATCH 2/3] target-i386: Use xsave structs for ext_save_area Date: Sat, 28 Nov 2015 17:56:50 -0200 [thread overview] Message-ID: <1448740611-3096-3-git-send-email-ehabkost@redhat.com> (raw) In-Reply-To: <1448740611-3096-1-git-send-email-ehabkost@redhat.com> This doesn't introduce any change in the code, as the offsets and struct sizes match what was present in the table. This can be validated by the QEMU_BUILD_BUG_ON lines on target-i386/cpu.h, which ensures the struct sizes and offsets match the existing values in ext_save_area. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- target-i386/cpu.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 11e5e39..bc95437 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -458,17 +458,23 @@ typedef struct ExtSaveArea { static const ExtSaveArea ext_save_areas[] = { [2] = { .feature = FEAT_1_ECX, .bits = CPUID_EXT_AVX, - .offset = 0x240, .size = 0x100 }, + .offset = offsetof(X86XSaveArea, avx_state), + .size = sizeof(XSaveAVX) }, [3] = { .feature = FEAT_7_0_EBX, .bits = CPUID_7_0_EBX_MPX, - .offset = 0x3c0, .size = 0x40 }, + .offset = offsetof(X86XSaveArea, bndreg_state), + .size = sizeof(XSaveBNDREG) }, [4] = { .feature = FEAT_7_0_EBX, .bits = CPUID_7_0_EBX_MPX, - .offset = 0x400, .size = 0x40 }, + .offset = offsetof(X86XSaveArea, bndcsr_state), + .size = sizeof(XSaveBNDCSR) }, [5] = { .feature = FEAT_7_0_EBX, .bits = CPUID_7_0_EBX_AVX512F, - .offset = 0x440, .size = 0x40 }, + .offset = offsetof(X86XSaveArea, opmask_state), + .size = sizeof(XSaveOpmask) }, [6] = { .feature = FEAT_7_0_EBX, .bits = CPUID_7_0_EBX_AVX512F, - .offset = 0x480, .size = 0x200 }, + .offset = offsetof(X86XSaveArea, zmm_hi256_state), + .size = sizeof(XSaveZMM_Hi256) }, [7] = { .feature = FEAT_7_0_EBX, .bits = CPUID_7_0_EBX_AVX512F, - .offset = 0x680, .size = 0x400 }, + .offset = offsetof(X86XSaveArea, hi16_zmm_state), + .size = sizeof(XSaveHi16_ZMM) }, }; const char *get_register_name_32(unsigned int reg) -- 2.1.0
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com> To: qemu-devel@nongnu.org Cc: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org, Huaitong Han <huaitong.han@intel.com> Subject: [Qemu-devel] [for-2.6 PATCH 2/3] target-i386: Use xsave structs for ext_save_area Date: Sat, 28 Nov 2015 17:56:50 -0200 [thread overview] Message-ID: <1448740611-3096-3-git-send-email-ehabkost@redhat.com> (raw) In-Reply-To: <1448740611-3096-1-git-send-email-ehabkost@redhat.com> This doesn't introduce any change in the code, as the offsets and struct sizes match what was present in the table. This can be validated by the QEMU_BUILD_BUG_ON lines on target-i386/cpu.h, which ensures the struct sizes and offsets match the existing values in ext_save_area. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- target-i386/cpu.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 11e5e39..bc95437 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -458,17 +458,23 @@ typedef struct ExtSaveArea { static const ExtSaveArea ext_save_areas[] = { [2] = { .feature = FEAT_1_ECX, .bits = CPUID_EXT_AVX, - .offset = 0x240, .size = 0x100 }, + .offset = offsetof(X86XSaveArea, avx_state), + .size = sizeof(XSaveAVX) }, [3] = { .feature = FEAT_7_0_EBX, .bits = CPUID_7_0_EBX_MPX, - .offset = 0x3c0, .size = 0x40 }, + .offset = offsetof(X86XSaveArea, bndreg_state), + .size = sizeof(XSaveBNDREG) }, [4] = { .feature = FEAT_7_0_EBX, .bits = CPUID_7_0_EBX_MPX, - .offset = 0x400, .size = 0x40 }, + .offset = offsetof(X86XSaveArea, bndcsr_state), + .size = sizeof(XSaveBNDCSR) }, [5] = { .feature = FEAT_7_0_EBX, .bits = CPUID_7_0_EBX_AVX512F, - .offset = 0x440, .size = 0x40 }, + .offset = offsetof(X86XSaveArea, opmask_state), + .size = sizeof(XSaveOpmask) }, [6] = { .feature = FEAT_7_0_EBX, .bits = CPUID_7_0_EBX_AVX512F, - .offset = 0x480, .size = 0x200 }, + .offset = offsetof(X86XSaveArea, zmm_hi256_state), + .size = sizeof(XSaveZMM_Hi256) }, [7] = { .feature = FEAT_7_0_EBX, .bits = CPUID_7_0_EBX_AVX512F, - .offset = 0x680, .size = 0x400 }, + .offset = offsetof(X86XSaveArea, hi16_zmm_state), + .size = sizeof(XSaveHi16_ZMM) }, }; const char *get_register_name_32(unsigned int reg) -- 2.1.0
next prev parent reply other threads:[~2015-11-28 19:57 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-28 19:56 [for-2.6 PATCH 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes Eduardo Habkost 2015-11-28 19:56 ` [Qemu-devel] " Eduardo Habkost 2015-11-28 19:56 ` [for-2.6 PATCH 1/3] target-i386: Define structs for layout of xsave area Eduardo Habkost 2015-11-28 19:56 ` [Qemu-devel] " Eduardo Habkost 2015-11-30 11:18 ` Paolo Bonzini 2015-11-30 11:18 ` [Qemu-devel] " Paolo Bonzini 2015-11-30 14:48 ` Eduardo Habkost 2015-11-30 14:48 ` [Qemu-devel] " Eduardo Habkost 2015-12-01 17:09 ` Richard Henderson 2015-12-01 17:15 ` Eduardo Habkost 2015-12-01 17:15 ` Eduardo Habkost 2015-12-01 17:20 ` Richard Henderson 2015-12-01 17:20 ` Richard Henderson 2015-12-01 17:27 ` Paolo Bonzini 2015-12-01 17:27 ` Paolo Bonzini 2015-12-01 18:34 ` Eduardo Habkost 2015-12-01 18:34 ` Eduardo Habkost 2015-12-01 18:42 ` Richard Henderson 2015-12-01 18:42 ` Richard Henderson 2015-11-28 19:56 ` Eduardo Habkost [this message] 2015-11-28 19:56 ` [Qemu-devel] [for-2.6 PATCH 2/3] target-i386: Use xsave structs for ext_save_area Eduardo Habkost 2015-11-28 19:56 ` [for-2.6 PATCH 3/3] target-i386: kvm: Use X86XSaveArea struct for xsave save/load Eduardo Habkost 2015-11-28 19:56 ` [Qemu-devel] " Eduardo Habkost 2015-11-30 11:21 ` [for-2.6 PATCH 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes Paolo Bonzini 2015-11-30 11:21 ` [Qemu-devel] " Paolo Bonzini 2015-11-30 14:14 ` Eduardo Habkost 2015-11-30 14:14 ` [Qemu-devel] " Eduardo Habkost
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1448740611-3096-3-git-send-email-ehabkost@redhat.com \ --to=ehabkost@redhat.com \ --cc=huaitong.han@intel.com \ --cc=kvm@vger.kernel.org \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.