From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: [PATCH i-g-t] tests/pm_rpm: Don't compare edid blob IDs
Date: Tue, 1 Dec 2015 17:37:40 +0100 [thread overview]
Message-ID: <1448987860-22255-1-git-send-email-daniel.vetter@ffwll.ch> (raw)
The kernel is free to allocate blob ids however it wants to. And also
to reallocate them whenever it sees fit. The only thing we are allowed
to compare is the length and the actual date.
Removing this bogus check makes drm-resources-equal on my snb.
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
tests/pm_rpm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index 37aef96ed267..55fdb31cb723 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -512,7 +512,6 @@ static void assert_drm_edids_equal(drmModePropertyBlobPtr e1,
return;
igt_assert(e1 && e2);
- COMPARE(e1, e2, id);
COMPARE(e1, e2, length);
igt_assert(memcmp(e1->data, e2->data, e1->length) == 0);
--
2.1.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2015-12-01 16:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 16:37 Daniel Vetter [this message]
2015-12-01 16:40 ` [PATCH i-g-t] tests/pm_rpm: Don't compare edid blob IDs Daniel Vetter
2015-12-01 16:40 ` Paulo Zanoni
2015-12-01 16:47 ` Daniel Vetter
2015-12-01 16:54 ` Paulo Zanoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448987860-22255-1-git-send-email-daniel.vetter@ffwll.ch \
--to=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.