All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruenba@redhat.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Jeff Layton <jlayton@poochiereds.net>,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	Dave Chinner <david@fromorbit.com>,
	linux-ext4@vger.kernel.org, xfs@oss.sgi.com,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
	linux-api@vger.kernel.org
Cc: Andreas Gruenbacher <agruenba@redhat.com>
Subject: [PATCH v16 04/22] vfs: Make the inode passed to inode_change_ok non-const
Date: Wed,  2 Dec 2015 22:01:10 +0100	[thread overview]
Message-ID: <1449090088-9281-5-git-send-email-agruenba@redhat.com> (raw)
In-Reply-To: <1449090088-9281-1-git-send-email-agruenba@redhat.com>

We will need to call iop->permission and iop->get_acl from
inode_change_ok() for additional permission checks, and both take a
non-const inode.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Reviewed-by: J. Bruce Fields <bfields@redhat.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
---
 fs/attr.c          | 2 +-
 include/linux/fs.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/attr.c b/fs/attr.c
index 6530ced..328be71 100644
--- a/fs/attr.c
+++ b/fs/attr.c
@@ -28,7 +28,7 @@
  * Should be called as the first thing in ->setattr implementations,
  * possibly after taking additional locks.
  */
-int inode_change_ok(const struct inode *inode, struct iattr *attr)
+int inode_change_ok(struct inode *inode, struct iattr *attr)
 {
 	unsigned int ia_valid = attr->ia_valid;
 
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 7a45120..65cebcb 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2857,7 +2857,7 @@ extern int buffer_migrate_page(struct address_space *,
 #define buffer_migrate_page NULL
 #endif
 
-extern int inode_change_ok(const struct inode *, struct iattr *);
+extern int inode_change_ok(struct inode *, struct iattr *);
 extern int inode_newsize_ok(const struct inode *, loff_t offset);
 extern void setattr_copy(struct inode *inode, const struct iattr *attr);
 
-- 
2.5.0

WARNING: multiple messages have this Message-ID (diff)
From: Andreas Gruenbacher <agruenba@redhat.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
	Theodore Ts'o <tytso@mit.edu>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Jeff Layton <jlayton@poochiereds.net>,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	Dave Chinner <david@fromorbit.com>,
	linux-ext4@vger.kernel.org, xfs@oss.sgi.com,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
	linux-api@vger.kernel.org
Cc: Andreas Gruenbacher <agruenba@redhat.com>
Subject: [PATCH v16 04/22] vfs: Make the inode passed to inode_change_ok non-const
Date: Wed,  2 Dec 2015 22:01:10 +0100	[thread overview]
Message-ID: <1449090088-9281-5-git-send-email-agruenba@redhat.com> (raw)
In-Reply-To: <1449090088-9281-1-git-send-email-agruenba@redhat.com>

We will need to call iop->permission and iop->get_acl from
inode_change_ok() for additional permission checks, and both take a
non-const inode.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Reviewed-by: J. Bruce Fields <bfields@redhat.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
---
 fs/attr.c          | 2 +-
 include/linux/fs.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/attr.c b/fs/attr.c
index 6530ced..328be71 100644
--- a/fs/attr.c
+++ b/fs/attr.c
@@ -28,7 +28,7 @@
  * Should be called as the first thing in ->setattr implementations,
  * possibly after taking additional locks.
  */
-int inode_change_ok(const struct inode *inode, struct iattr *attr)
+int inode_change_ok(struct inode *inode, struct iattr *attr)
 {
 	unsigned int ia_valid = attr->ia_valid;
 
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 7a45120..65cebcb 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2857,7 +2857,7 @@ extern int buffer_migrate_page(struct address_space *,
 #define buffer_migrate_page NULL
 #endif
 
-extern int inode_change_ok(const struct inode *, struct iattr *);
+extern int inode_change_ok(struct inode *, struct iattr *);
 extern int inode_newsize_ok(const struct inode *, loff_t offset);
 extern void setattr_copy(struct inode *inode, const struct iattr *attr);
 
-- 
2.5.0

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2015-12-02 21:01 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-02 21:01 [PATCH v16 00/22] Richacls (Core and Ext4) Andreas Gruenbacher
2015-12-02 21:01 ` Andreas Gruenbacher
2015-12-02 21:01 ` Andreas Gruenbacher
2015-12-02 21:01 ` [PATCH v16 01/22] vfs: Add IS_ACL() and IS_RICHACL() tests Andreas Gruenbacher
2015-12-02 21:01   ` Andreas Gruenbacher
2015-12-02 21:01 ` [PATCH v16 03/22] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD permission flags Andreas Gruenbacher
2015-12-02 21:01   ` Andreas Gruenbacher
2015-12-02 21:01 ` Andreas Gruenbacher [this message]
2015-12-02 21:01   ` [PATCH v16 04/22] vfs: Make the inode passed to inode_change_ok non-const Andreas Gruenbacher
2015-12-02 21:01 ` [PATCH v16 05/22] vfs: Add permission flags for setting file attributes Andreas Gruenbacher
2015-12-02 21:01   ` Andreas Gruenbacher
2015-12-02 21:01 ` [PATCH v16 06/22] richacl: In-memory representation and helper functions Andreas Gruenbacher
2015-12-02 21:01   ` Andreas Gruenbacher
2015-12-02 21:01 ` [PATCH v16 07/22] richacl: Permission mapping functions Andreas Gruenbacher
2015-12-02 21:01   ` Andreas Gruenbacher
2015-12-02 21:01 ` [PATCH v16 08/22] richacl: Compute maximum file masks from an acl Andreas Gruenbacher
2015-12-02 21:01   ` Andreas Gruenbacher
2015-12-02 21:01 ` [PATCH v16 09/22] richacl: Permission check algorithm Andreas Gruenbacher
2015-12-02 21:01   ` Andreas Gruenbacher
2015-12-02 21:01 ` [PATCH v16 10/22] posix_acl: Unexport acl_by_type and make it static Andreas Gruenbacher
2015-12-02 21:01   ` Andreas Gruenbacher
2015-12-02 21:01 ` [PATCH v16 11/22] vfs: Cache base_acl objects in inodes Andreas Gruenbacher
2015-12-02 21:01   ` Andreas Gruenbacher
2015-12-02 21:01 ` [PATCH v16 12/22] vfs: Add get_richacl and set_richacl inode operations Andreas Gruenbacher
2015-12-02 21:01   ` Andreas Gruenbacher
2015-12-02 21:01 ` [PATCH v16 14/22] richacl: Update the file masks in chmod() Andreas Gruenbacher
2015-12-02 21:01   ` Andreas Gruenbacher
2015-12-02 21:01 ` [PATCH v16 15/22] richacl: Check if an acl is equivalent to a file mode Andreas Gruenbacher
2015-12-02 21:01   ` Andreas Gruenbacher
2015-12-02 21:01 ` [PATCH v16 16/22] richacl: Create-time inheritance Andreas Gruenbacher
2015-12-02 21:01   ` Andreas Gruenbacher
2015-12-02 21:01 ` [PATCH v16 17/22] richacl: Automatic Inheritance Andreas Gruenbacher
2015-12-02 21:01   ` Andreas Gruenbacher
2015-12-02 21:01 ` [PATCH v16 18/22] richacl: xattr mapping functions Andreas Gruenbacher
2015-12-02 21:01   ` Andreas Gruenbacher
2015-12-02 21:01 ` [PATCH v16 19/22] richacl: Add richacl xattr handler Andreas Gruenbacher
2015-12-02 21:01   ` Andreas Gruenbacher
2015-12-02 21:01 ` [PATCH v16 20/22] vfs: Add richacl permission checking Andreas Gruenbacher
2015-12-02 21:01   ` Andreas Gruenbacher
2015-12-02 21:01 ` [PATCH v16 21/22] ext4: Add richacl support Andreas Gruenbacher
2015-12-02 21:01   ` Andreas Gruenbacher
2015-12-02 21:01 ` [PATCH v16 22/22] ext4: Add richacl feature flag Andreas Gruenbacher
2015-12-02 21:01   ` Andreas Gruenbacher
2015-12-03 22:17 ` [PATCH v16 00/22] Richacls (Core and Ext4) Andreas Gruenbacher
2015-12-03 22:17   ` Andreas Gruenbacher
2015-12-03 23:24 ` Eric Sandeen
2015-12-04  1:30   ` Eric Sandeen
     [not found] ` <1449090088-9281-1-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-12-02 21:01   ` [PATCH v16 02/22] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags Andreas Gruenbacher
2015-12-02 21:01     ` Andreas Gruenbacher
2015-12-02 21:01     ` Andreas Gruenbacher
2015-12-02 21:01   ` [PATCH v16 13/22] vfs: Cache richacl in struct inode Andreas Gruenbacher
2015-12-02 21:01     ` Andreas Gruenbacher
2015-12-02 21:01     ` Andreas Gruenbacher
2015-12-15 11:12   ` [PATCH v16 00/22] Richacls (Core and Ext4) Andreas Gruenbacher
2015-12-15 11:12     ` Andreas Gruenbacher
2015-12-15 11:12     ` Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449090088-9281-5-git-send-email-agruenba@redhat.com \
    --to=agruenba@redhat.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=anna.schumaker@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=david@fromorbit.com \
    --cc=jlayton@poochiereds.net \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.