From: David Henningsson <david.henningsson@canonical.com>
To: tiwai@suse.de, alsa-devel@alsa-project.org
Cc: David Henningsson <david.henningsson@canonical.com>
Subject: [PATCH] ALSA: hda - Enable power_save_node for CX20722
Date: Thu, 3 Dec 2015 15:46:57 +0100 [thread overview]
Message-ID: <1449154017-5256-1-git-send-email-david.henningsson@canonical.com> (raw)
I've tested it on one device and it works fine, no clicks.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
Alsa-info for this device is available here: https://launchpadlibrarian.net/228090406/AlsaInfo.txt
Possibly it works well for other chips too, but this is the only one
I have tested.
Btw; I noticed another thing which I wonder whether it's correct or not:
If I run "hda-emu AlsaInfo.txt", all nodes are in D3. But after running "P 0 p",
some nodes (e g the internal speaker pin) stays in D0. Is that expected?
I thought all pins would go down to D3 when playback closes.
Same behaviour is seen on the real hardware, too.
sound/pci/hda/patch_conexant.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
index ef19890..6122b8c 100644
--- a/sound/pci/hda/patch_conexant.c
+++ b/sound/pci/hda/patch_conexant.c
@@ -901,6 +901,9 @@ static int patch_conexant_auto(struct hda_codec *codec)
snd_hda_pick_fixup(codec, cxt5051_fixup_models,
cxt5051_fixups, cxt_fixups);
break;
+ case 0x14f150f2:
+ codec->power_save_node = 1;
+ /* Fall through */
default:
codec->pin_amp_workaround = 1;
snd_hda_pick_fixup(codec, cxt5066_fixup_models,
--
1.9.1
next reply other threads:[~2015-12-03 14:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 14:46 David Henningsson [this message]
2015-12-03 14:57 ` [PATCH] ALSA: hda - Enable power_save_node for CX20722 Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449154017-5256-1-git-send-email-david.henningsson@canonical.com \
--to=david.henningsson@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.