All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: xen-devel@lists.xensource.com,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [Qemu-devel] [PATCH v3 13/13] xen-hvm: Mark inappropriate error handling FIXME
Date: Thu, 17 Dec 2015 17:35:21 +0100	[thread overview]
Message-ID: <1450370121-5768-14-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1450370121-5768-1-git-send-email-armbru@redhat.com>

Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 xen-hvm.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/xen-hvm.c b/xen-hvm.c
index 3d78a0c..2a93390 100644
--- a/xen-hvm.c
+++ b/xen-hvm.c
@@ -240,6 +240,7 @@ static void xen_ram_init(PCMachineState *pcms,
 
 void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, MemoryRegion *mr)
 {
+    /* FIXME caller ram_block_add() wants error_setg() on failure */
     unsigned long nr_pfn;
     xen_pfn_t *pfn_list;
     int i;
@@ -1192,6 +1193,12 @@ static void xen_wakeup_notifier(Notifier *notifier, void *data)
 int xen_hvm_init(PCMachineState *pcms,
                  MemoryRegion **ram_memory)
 {
+    /*
+     * FIXME Returns -1 without cleaning up on some errors (harmless
+     * as long as the caller exit()s on error), dies with hw_error()
+     * on others.  hw_error() isn't approprate here.  Should probably
+     * simply exit() on all errors.
+     */
     int i, rc;
     xen_pfn_t ioreq_pfn;
     xen_pfn_t bufioreq_pfn;
-- 
2.4.3

WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: xen-devel@lists.xensource.com,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [PATCH v3 13/13] xen-hvm: Mark inappropriate error handling FIXME
Date: Thu, 17 Dec 2015 17:35:21 +0100	[thread overview]
Message-ID: <1450370121-5768-14-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1450370121-5768-1-git-send-email-armbru@redhat.com>

Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 xen-hvm.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/xen-hvm.c b/xen-hvm.c
index 3d78a0c..2a93390 100644
--- a/xen-hvm.c
+++ b/xen-hvm.c
@@ -240,6 +240,7 @@ static void xen_ram_init(PCMachineState *pcms,
 
 void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, MemoryRegion *mr)
 {
+    /* FIXME caller ram_block_add() wants error_setg() on failure */
     unsigned long nr_pfn;
     xen_pfn_t *pfn_list;
     int i;
@@ -1192,6 +1193,12 @@ static void xen_wakeup_notifier(Notifier *notifier, void *data)
 int xen_hvm_init(PCMachineState *pcms,
                  MemoryRegion **ram_memory)
 {
+    /*
+     * FIXME Returns -1 without cleaning up on some errors (harmless
+     * as long as the caller exit()s on error), dies with hw_error()
+     * on others.  hw_error() isn't approprate here.  Should probably
+     * simply exit() on all errors.
+     */
     int i, rc;
     xen_pfn_t ioreq_pfn;
     xen_pfn_t bufioreq_pfn;
-- 
2.4.3

  parent reply	other threads:[~2015-12-17 16:35 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17 16:35 [Qemu-devel] [PATCH v3 00/13] Clean up some hw_error() misuse Markus Armbruster
2015-12-17 16:35 ` [Qemu-devel] [PATCH v3 01/13] hw: Don't use hw_error() for machine initialization errors Markus Armbruster
2015-12-17 16:35 ` [Qemu-devel] [PATCH v3 02/13] omap: Don't use hw_error() in device init() methods Markus Armbruster
2015-12-17 16:35 ` [Qemu-devel] [PATCH v3 03/13] arm_mptimer: Don't use hw_error() in realize() method Markus Armbruster
2015-12-17 16:35 ` [Qemu-devel] [PATCH v3 04/13] etraxfs_eth: Don't use hw_error() in init() method Markus Armbruster
2015-12-17 16:35 ` [Qemu-devel] [PATCH v3 05/13] raven: Mark use of hw_error() in realize() FIXME Markus Armbruster
2015-12-17 16:35 ` [Qemu-devel] [PATCH v3 06/13] error: Don't append a newline when printing the error hint Markus Armbruster
2015-12-17 16:35 ` [Qemu-devel] [PATCH v3 07/13] hw/arm/virt: Fix property "gic-version" error handling Markus Armbruster
2015-12-18 13:29   ` Markus Armbruster
2015-12-17 16:35 ` [Qemu-devel] [PATCH v3 08/13] sysbus: Don't use hw_error() in machine_init_done_notifiers Markus Armbruster
2015-12-17 16:35 ` [Qemu-devel] [PATCH v3 09/13] isa: Trivially convert remaining PCI-ISA bridges to realize() Markus Armbruster
2015-12-17 16:35 ` [Qemu-devel] [PATCH v3 10/13] isa: Clean up error handling around isa_bus_new() Markus Armbruster
2015-12-17 16:35 ` [Qemu-devel] [PATCH v3 11/13] isa: Clean up inappropriate hw_error() Markus Armbruster
2015-12-17 16:35 ` [Qemu-devel] [PATCH v3 12/13] audio: Clean up inappropriate and unreachable use of hw_error() Markus Armbruster
2015-12-17 16:35 ` Markus Armbruster [this message]
2015-12-17 16:35   ` [PATCH v3 13/13] xen-hvm: Mark inappropriate error handling FIXME Markus Armbruster
2015-12-22 13:50   ` [Qemu-devel] [Xen-devel] " Stefano Stabellini
2015-12-22 13:50     ` Stefano Stabellini
2016-01-11 14:30     ` [Qemu-devel] " Markus Armbruster
2016-01-11 14:30       ` Markus Armbruster
2016-01-13 13:36       ` [Qemu-devel] " Markus Armbruster
2016-01-13 13:36         ` Markus Armbruster
2016-01-13 14:06         ` [Qemu-devel] " Stefano Stabellini
2016-01-13 14:06           ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450370121-5768-14-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.