From: Daniel J Blueman <daniel@numascale.com> To: Bjorn Helgaas <bhelgaas@google.com>, Jeff Kirsher <jeffrey.t.kirsher@intel.com>, Jesse Brandeburg <jesse.brandeburg@intel.com>, Shannon Nelson <shannon.nelson@intel.com>, Carolyn Wyborny <carolyn.wyborny@intel.com>, Don Skidmore <donald.c.skidmore@intel.com>, Bruce Allan <bruce.w.allan@intel.com>, John Ronciak <john.ronciak@intel.com>, Mitch Williams <mitch.a.williams@intel.com> Cc: Daniel J Blueman <daniel@numascale.com>, <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>, <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Steffen Persvold <sp@numascale.com>, Jiang Liu <jiang.liu@linux.intel.com>, Thomas Gleixner <tglx@linutronix.de> Subject: [PATCH 2/2] ixgbe: Use core to device locality interface Date: Wed, 23 Dec 2015 18:01:41 +0800 [thread overview] Message-ID: <1450864901-16712-2-git-send-email-daniel@numascale.com> (raw) In-Reply-To: <1450864901-16712-1-git-send-email-daniel@numascale.com> Rather than assuming cores starting from 0 are local to the ethernet device, use the introduced interface to find near cores. Not only does this improve performance due to spreading interrupts via near NUMA nodes, it prevents assigning cores on distant NUMA nodes, which aren't reachable by device interrupts due to the 8-bit APIC ID limitation. With Numascale NumaConnect2 systems with Intel ixgbe cards on non-primary PCI domains, all ixgbe NICs would previously revector interrupts to cores 0 to 63 (cores 0 to 47 would be considered near the primary PCI domain). Now, cores 48 to 95 are used, increasing performance and addressing interrupt delivery issues: do_IRQ: 79.180 No irq handler for vector (irq -1) do_IRQ: 78.42 No irq handler for vector (irq -1) do_IRQ: 71.172 No irq handler for vector (irq -1) do_IRQ: 70.236 No irq handler for vector (irq -1) do_IRQ: 69.109 No irq handler for vector (irq -1) do_IRQ: 68.189 No irq handler for vector (irq -1) do_IRQ: 72.92 No irq handler for vector (irq -1) do_IRQ: 73.235 No irq handler for vector (irq -1) do_IRQ: 66.185 No irq handler for vector (irq -1) do_IRQ: 67.62 No irq handler for vector (irq -1) do_IRQ: 197 callbacks suppressed Signed-off-by: Daniel J Blueman <daniel@numascale.com> --- drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c index f3168bc..12c4ce1 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c @@ -817,10 +817,8 @@ static int ixgbe_alloc_q_vector(struct ixgbe_adapter *adapter, if ((tcs <= 1) && !(adapter->flags & IXGBE_FLAG_SRIOV_ENABLED)) { u16 rss_i = adapter->ring_feature[RING_F_RSS].indices; if (rss_i > 1 && adapter->atr_sample_rate) { - if (cpu_online(v_idx)) { - cpu = v_idx; - node = cpu_to_node(cpu); - } + cpu = cpu_near_dev(adapter->pdev, v_idx); + node = cpu_to_node(cpu); } } -- 2.5.0
WARNING: multiple messages have this Message-ID (diff)
From: Daniel J Blueman <daniel@numascale.com> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [PATCH 2/2] ixgbe: Use core to device locality interface Date: Wed, 23 Dec 2015 18:01:41 +0800 [thread overview] Message-ID: <1450864901-16712-2-git-send-email-daniel@numascale.com> (raw) In-Reply-To: <1450864901-16712-1-git-send-email-daniel@numascale.com> Rather than assuming cores starting from 0 are local to the ethernet device, use the introduced interface to find near cores. Not only does this improve performance due to spreading interrupts via near NUMA nodes, it prevents assigning cores on distant NUMA nodes, which aren't reachable by device interrupts due to the 8-bit APIC ID limitation. With Numascale NumaConnect2 systems with Intel ixgbe cards on non-primary PCI domains, all ixgbe NICs would previously revector interrupts to cores 0 to 63 (cores 0 to 47 would be considered near the primary PCI domain). Now, cores 48 to 95 are used, increasing performance and addressing interrupt delivery issues: do_IRQ: 79.180 No irq handler for vector (irq -1) do_IRQ: 78.42 No irq handler for vector (irq -1) do_IRQ: 71.172 No irq handler for vector (irq -1) do_IRQ: 70.236 No irq handler for vector (irq -1) do_IRQ: 69.109 No irq handler for vector (irq -1) do_IRQ: 68.189 No irq handler for vector (irq -1) do_IRQ: 72.92 No irq handler for vector (irq -1) do_IRQ: 73.235 No irq handler for vector (irq -1) do_IRQ: 66.185 No irq handler for vector (irq -1) do_IRQ: 67.62 No irq handler for vector (irq -1) do_IRQ: 197 callbacks suppressed Signed-off-by: Daniel J Blueman <daniel@numascale.com> --- drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c index f3168bc..12c4ce1 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c @@ -817,10 +817,8 @@ static int ixgbe_alloc_q_vector(struct ixgbe_adapter *adapter, if ((tcs <= 1) && !(adapter->flags & IXGBE_FLAG_SRIOV_ENABLED)) { u16 rss_i = adapter->ring_feature[RING_F_RSS].indices; if (rss_i > 1 && adapter->atr_sample_rate) { - if (cpu_online(v_idx)) { - cpu = v_idx; - node = cpu_to_node(cpu); - } + cpu = cpu_near_dev(adapter->pdev, v_idx); + node = cpu_to_node(cpu); } } -- 2.5.0
next prev parent reply other threads:[~2015-12-23 10:02 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-23 10:01 [PATCH 1/2] PCI: Add mechanism to find topologically near cores Daniel J Blueman 2015-12-23 10:01 ` [Intel-wired-lan] " Daniel J Blueman 2015-12-23 10:01 ` Daniel J Blueman [this message] 2015-12-23 10:01 ` [Intel-wired-lan] [PATCH 2/2] ixgbe: Use core to device locality interface Daniel J Blueman 2015-12-23 11:15 ` kbuild test robot 2015-12-23 11:15 ` [Intel-wired-lan] " kbuild test robot 2015-12-23 10:35 ` [PATCH 1/2] PCI: Add mechanism to find topologically near cores kbuild test robot 2015-12-23 10:35 ` [Intel-wired-lan] " kbuild test robot 2015-12-23 15:46 ` Bjorn Helgaas 2015-12-23 15:46 ` [Intel-wired-lan] " Bjorn Helgaas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1450864901-16712-2-git-send-email-daniel@numascale.com \ --to=daniel@numascale.com \ --cc=bhelgaas@google.com \ --cc=bruce.w.allan@intel.com \ --cc=carolyn.wyborny@intel.com \ --cc=donald.c.skidmore@intel.com \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=jeffrey.t.kirsher@intel.com \ --cc=jesse.brandeburg@intel.com \ --cc=jiang.liu@linux.intel.com \ --cc=john.ronciak@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=mitch.a.williams@intel.com \ --cc=netdev@vger.kernel.org \ --cc=shannon.nelson@intel.com \ --cc=sp@numascale.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.