All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: clemens@ladisch.de, tiwai@suse.de
Cc: alsa-devel@alsa-project.org, stefanr@s5r6.in-berlin.de,
	ffado-devel@lists.sf.net
Subject: [PATCH 5/5] ALSA: dice: expand timeout to wait for Dice notification
Date: Fri, 25 Dec 2015 10:13:15 +0900	[thread overview]
Message-ID: <1451005995-12098-6-git-send-email-o-takashi@sakamocchi.jp> (raw)
In-Reply-To: <1451005995-12098-1-git-send-email-o-takashi@sakamocchi.jp>

Some users have reported that their Dice based models generate ETIMEDOUT
when starting PCM playback. It means that current timeout (=100msec) is
not enough for their models to transfer notifications.

This commit expands the timeout up to 2 sec. As a result, in a worst case,
any operations to start AMDTP streams takes 2 sec or more. Then, in
userspace, snd_pcm_hw_params(), snd_pcm_prepare(), snd_pcm_recover(),
snd_rawmidi_open(), snd_seq_connect_from() and snd_seq_connect_to() may
take the time.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 sound/firewire/dice/dice-transaction.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/firewire/dice/dice-transaction.c b/sound/firewire/dice/dice-transaction.c
index d5f7de7..de5cd6c 100644
--- a/sound/firewire/dice/dice-transaction.c
+++ b/sound/firewire/dice/dice-transaction.c
@@ -9,7 +9,7 @@
 
 #include "dice.h"
 
-#define NOTIFICATION_TIMEOUT_MS	100
+#define NOTIFICATION_TIMEOUT_MS	(2 * MSEC_PER_SEC)
 
 static u64 get_subaddr(struct snd_dice *dice, enum snd_dice_addr_type type,
 		       u64 offset)
-- 
2.5.0

  parent reply	other threads:[~2015-12-25  1:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-25  1:13 [PATCH 0/5 v3] ALSA: dice: improve card registration processing Takashi Sakamoto
2015-12-25  1:13 ` [PATCH 1/5] ALSA: dice: split subaddress check from category check Takashi Sakamoto
2015-12-25  1:13 ` [PATCH 2/5] ALSA: dice: postpone card registration Takashi Sakamoto
2015-12-25  1:13 ` [PATCH 3/5] ALSA: dice: ensure to release sound devices after sound card registration fails Takashi Sakamoto
2015-12-25  1:13 ` [PATCH 4/5] ALSA: dice: purge transaction initialization at timeout of Dice notification Takashi Sakamoto
2015-12-25  1:13 ` Takashi Sakamoto [this message]
2015-12-26  3:35 [PATCH 0/5 v4] ALSA: dice: improve card registration processing Takashi Sakamoto
2015-12-26  3:35 ` [PATCH 5/5] ALSA: dice: expand timeout to wait for Dice notification Takashi Sakamoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1451005995-12098-6-git-send-email-o-takashi@sakamocchi.jp \
    --to=o-takashi@sakamocchi.jp \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=ffado-devel@lists.sf.net \
    --cc=stefanr@s5r6.in-berlin.de \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.